RunUO Community

This is a sample guest message. Register a free account today to become a member! Once signed in, you'll be able to participate on this site by adding your own topics and posts, as well as connect with other members through your own private inbox!

Arcane Gem Script Problem

I have a shard running on RunUO v2.1

I have a script that compiles but does not work.

Most of the players on the shard have equipment with LRC added. As a result, Arcane Gems that are typically used to add LRC (with charges) have become less useful.

My idea was to allow Arcane Gems to also add SDI. The script below compiles with no errors but the SDI attribute does not get added to the IArcane item. It seems the line in the script adding SDI is simply ignored (Certainly it is not functional).

In the script I have commented at line 75 where I am trying to add SDI. Can anyone tell me what the problem is with the way I am trying to do this?

Here is the script in its current form:
Code:
using System;
using System.Collections;
using System.Collections.Generic;
using Server;
using Server.Targeting;
using Server.SpellCrafting;
using Server.SpellCrafting.Crafts;

namespace Server.Items
{
    public class ArcaneGem : Item
    {
        public override string DefaultName
        {
            get { return "arcane gem"; }
        }

        [Constructable]
        public ArcaneGem() : base( 0x1EA7 )
        {
            Stackable = Core.ML;
            Weight = 1.0;
        }

        public ArcaneGem( Serial serial ) : base( serial )
        {
        }

        public override void OnDoubleClick( Mobile from )
        {
            if ( !IsChildOf( from.Backpack ) )
            {
                from.SendLocalizedMessage( 1042001 ); // That must be in your pack for you to use it.
            }
            else
            {
                from.BeginTarget( 2, false, TargetFlags.None, new TargetCallback( OnTarget ) );
                from.SendMessage( "What do you wish to use the gem on?" );
            }
        }

        public int GetChargesFor( Mobile m )
        {
            int v = (int)(m.Skills[SkillName.Tailoring].Value / 5);

            if ( v < 16 )
                return 16;
            else if ( v > 24 )
                return 24;

            return v;
        }

        public const int DefaultArcaneHue = 2117;

        public void OnTarget( Mobile from, object obj )
        {
            if ( !IsChildOf( from.Backpack ) )
            {
                from.SendLocalizedMessage( 1042001 ); // That must be in your pack for you to use it.
                return;
            }

            if ( obj is IArcaneEquip && obj is Item )
            {
                Item item = (Item)obj;
                IArcaneEquip eq = (IArcaneEquip)obj;

                if ( !item.IsChildOf( from.Backpack ) )
                {
                    from.SendLocalizedMessage( 1042001 ); // That must be in your pack for you to use it.
                    return;
                }

//Line 75 - Try to add SDI here:
                if (item is Cloak)
                {
                    Cloak cloak = (Cloak)item;
                    cloak.Identified = true;
                    cloak.Attributes.SpellDamage = (cloak.Attributes.SpellDamage + 10);
                }

                int charges = GetChargesFor( from );

                if ( eq.IsArcane )
                {
                    if ( eq.CurArcaneCharges >= eq.MaxArcaneCharges )
                    {
                        from.SendMessage( "That item is already fully charged." );
                    }
                    else
                    {
                        if ( eq.CurArcaneCharges <= 0 )
                            item.Hue = DefaultArcaneHue;

                        if ( (eq.CurArcaneCharges + charges) > eq.MaxArcaneCharges )
                            eq.CurArcaneCharges = eq.MaxArcaneCharges;
                            else
                            {
                                eq.CurArcaneCharges += charges;
                        }

                        from.SendMessage( "You recharge the item." );
                        if ( Amount <= 1 )
                            Delete();
                        else Amount--;
                    }
                }
                else if ( from.Skills[SkillName.Tailoring].Value >= 80.0 )
                {
                    bool isExceptional = false;

                    if ( item is BaseClothing )
                        isExceptional = ( ((BaseClothing)item).Quality == ClothingQuality.Exceptional );
                    else if ( item is BaseArmor )
                        isExceptional = ( ((BaseArmor)item).Quality == ArmorQuality.Exceptional );
                    else if ( item is BaseWeapon )
                        isExceptional = ( ((BaseWeapon)item).Quality == WeaponQuality.Exceptional );

                    if ( isExceptional )
                    {
                        if ( item is BaseClothing )
                            ((BaseClothing)item).Crafter = from;
                        else if ( item is BaseArmor )
                            ((BaseArmor)item).Crafter = from;
                        else if ( item is BaseWeapon )
                            ((BaseWeapon)item).Crafter = from;

                        eq.CurArcaneCharges = eq.MaxArcaneCharges = charges;

                        item.Hue = DefaultArcaneHue;

                        from.SendMessage( "You enhance the item with your gem." );
                        if ( Amount <= 1 )
                            Delete();
                        else Amount--;
                    }
                    else
                    {
                        from.SendMessage( "Only exceptional items can be enhanced with the gem." );
                    }
                }
                else
                {
                    from.SendMessage( "You do not have enough skill in tailoring to enhance the item." );
                }
            }
            else
            {
                from.SendMessage( "You cannot use the gem on that." );
            }
        }

        public static bool ConsumeCharges( Mobile from, int amount )
        {
            List<Item> items = from.Items;
            int avail = 0;

            for ( int i = 0; i < items.Count; ++i )
            {
                Item obj = items[i];

                if ( obj is IArcaneEquip )
                {
                    IArcaneEquip eq = (IArcaneEquip)obj;

                    if ( eq.IsArcane )
                        avail += eq.CurArcaneCharges;
                }
            }

            if ( avail < amount )
                return false;

            for ( int i = 0; i < items.Count; ++i )
            {
                Item obj = items[i];

                if ( obj is IArcaneEquip )
                {
                    IArcaneEquip eq = (IArcaneEquip)obj;

                    if ( eq.IsArcane )
                    {
                        if ( eq.CurArcaneCharges > amount )
                        {
                            eq.CurArcaneCharges -= amount;
                            break;
                        }
                        else
                        {
                            amount -= eq.CurArcaneCharges;
                            eq.CurArcaneCharges = 0;
                        }
                    }
                }
            }

            return true;
        }

        

        public override void Serialize( GenericWriter writer )
        {
            base.Serialize( writer );

            writer.Write( (int) 0 );
        }

        public override void Deserialize( GenericReader reader )
        {
            base.Deserialize( reader );

            int version = reader.ReadInt();
        }
    }
}

If anyone can help it would be appreciated.

Many Thanks
 

HangWithWang

Wanderer
im sure by now youve figured it out. it was a simple fix for me

//Line 75 - Try to add SDI here:
if (item is Cloak)
{
Cloak cloak = (Cloak)item;
cloak.Attributes.SpellDamage = (cloak.Attributes.SpellDamage + 10);
}

my 2.6 runuo couldnt compile cloak.Identified = true; i removed it, and it worked. i couldnt find a reference to identified in base clothing or basecloak on a base runuo 2.6 but that is how i got it to work
 
Top