You asked me if I would use this script for my level system so after going over it, I must say, no, I would not add this script as it is.
I have a few issues with it, some small, some large
1) here in BaseSoulGem
is this meant to have 2 different Bonus Hits attributes?
I would be taking this out and adding something else as on my shard, bonus hits doesnt work.
Attributes.BonusHits = 30;
Attributes.RegenHits = 10;
Attributes.BonusHits = 20;
2) Timer priority
Priority = TimerPriority.OneSecond;
is that not a bit too much for something that takes 7 days? I cant be having so many timers in my worls ticking each second, with over 500 accounts, this can pose a problem.
I personally don't like to use timers unless there is no other way, and then with a moderate to low priority to reduce cpu load.
3) Colors
whats with the colored gems? how do these come into play? I looked around but couldnt find how players get them, am I to make the distinction and give out the colored gems? or does it turn a random color from the base soul gem?, or how does that work?
I would need to do some editing before using this script. I like the idea for the cursed item auto equip and might add a few things to it (like setting the cursed item to become non movable on equip)
4) this is a small issue but valid nonetheless
in your script where you post what to add to the playermobile, you surround the entire script with comment tags, not only is this unneeded, but its counter productive, I have to delete all those in order to copy it to add to the PM
a simple /* and */ would do just fine, and maybe add a // to a line over it to explain what it does.
Ok, issues aside...
It seems to be a well thought out script and will look forward to trying it out further. I'm not sure how I'll be able to use this for my level system, but I'll look into it.
__________________
The Den of KillerBeeZ... Kender's Komments, uncensored commentary from the Kender. Plus anything else the Kender might have in his pouches.
|