View Single Post
Old 06-13-2004, 04:20 AM   #12 (permalink)
KillerBeeZ
Forum Expert
 
KillerBeeZ's Avatar
 
Join Date: Jun 2003
Location: Live Oak FL
Age: 31
Posts: 2,005
Default

well done, esp for a first script

Without critisism though, scripts will never get better, so here are my 2 cents

1) your code is a bit sloppy, its not bad but to make it easier for others to edit, a script needs to be clean and look good.

I have taken the liberty of doing that (attatched)

2) the timer priority is very high, in general, timers are bad because they take up system resources, so timers need to be used only when there are no other options, and they need to be set to the lowest possible priority.

the priority of this is 250 ms but I dont see any harm in making it 1 second.

Other than these 2 issues this seems like an awsome script. Well done and by all means keep scripting.
Attached Files
File Type: cs TSwordII.cs (5.5 KB, 130 views)
__________________
The Den of KillerBeeZ...Kender's Komments, uncensored commentary from the Kender. Plus anything else the Kender might have in his pouches.
KillerBeeZ is offline   Reply With Quote