Forget about your friends PC for the moment and focus on getting your server published on the internet first. Have you made any changes to your /Scripts/Misc/ServerList.cs? If so, paste a copy of that in a reply, surrounded by code-tags. Check the LAN IP number of the PC running the server (>Command prompt>ipconfig/all) and post it.
Next, you should go in to the configuration of you router and look for 'Customer defined service' rule; that will enable you to do the port forwarding.
HTML Code:
1. Enter in a Description [Name] for this custom setting (RunUO)
2. Configure the Traffic or Data [Type] that you want to forward. (TCP)
3. Set the [LAN Server IP] of the PC that you want this traffic/data redirected to (10.5.2.2?)
4. You can also configure [Remote IPs] option to limit access to this specific port from the WAN side. This can be configured for 3 different access types:
a. Any IP Address [Any] - choose this option to allow access from any public IP address. (Default)
b. Single IP Address [Single Address] - choose this option to only allow access from a single public IP address.
c. IP Address Range [Address Range] - choose the option to only allow a range of public IP addresses. (Default)
5. Set the [Start Public Port] and [End Public Port] that this application will use on the WAN (Internet) side. The Gateway will listen for incoming traffic/data to its WAN IP on these ports. (2593)
6. Set the [Private Ports] that the Gateway will forward this traffic to on the LAN. If there is a range of ports, enter the starting private port in [Private Ports], select [Enable Port Range] checkbox, and the Gateway will automatically calculate the end private port. The LAN PC server will listen for traffic/data on this/these ports.(2593)
I'm not sure if it will accept a public and private port that are identical; if not change the port of your local server to something else (like 2592) and put that in as your local port above.
When done, saved, and restarted you should try the following link:
Open Port Check Tool and enter your public port (2593).
Edit: At this time 'craigcohen.no-ip.biz' resolves to: 64.231.254.213 and I get no ping response. I do get it from 64.231.255.239; is your NO-IP setup correctly?