Process Stopping

[Storm33229]

static void stopProcess()
        {
                System.Console.Write("What process would you like to stop?: ");
                string pname = System.Console.ReadLine();
                Process[] processes = Process.GetProcessesByName(pname);
                if ((pname.Contains(Convert.ToString(processes))))
                {
                    foreach (Process process in processes)
                    {
                        process.Kill();
                        System.Console.WriteLine(pname + " has been stopped.");
                    }
                }
                else if (!(pname.Contains(processes.ToString())) && pname != "None")
                {
                    System.Console.WriteLine(pname + " is not a valid process name. Please try again.");
                    stopProcess();
                }
                else if (pname == "None")
                {
                        CommandHandler(commandGiven);
                }
        }

I seem to be having some difficulties with this for some odd reason. I don't get any errors, it just simlpy doesn't work. Help? Thanks much!

[arul]

if ((pname.Contains(Convert.ToString(processes))))

Get rid of this line, makes no sense.

[Storm33229]

Code Block Update:

static void stopProcess()
        {
            System.Console.Write("What process would you like to stop?: ");
            string pname = System.Console.ReadLine().ToUpper();
            Process[] processes = Process.GetProcessesByName(pname);
            foreach (Process process in processes)
            {
                if (Convert.ToString(process).ToUpper().Contains(pname.ToUpper()))
                {
                    process.Kill();
                    System.Console.WriteLine(pname + " has been stopped.");
                }
                else if (!(Convert.ToString(process).ToUpper().Contains(pname.ToUpper())) && !(pname == "None"))
                {
                    System.Console.WriteLine(pname + " is not a valid process name. Please try again.");
                    stopProcess();
                }
                else if (pname == "None")
                {
                    System.Console.WriteLine("Process stopper canceled.");
                    CommandHandler(commandGiven);
                }
            }
        }

[Joeku]

Process Members

Try this:

static void stopProcess()
{
	System.Console.Write("What process would you like to stop?: ");
	string pname = System.Console.ReadLine().ToUpper();
	Process[] processes = Process.GetProcessesByName(pname);
	Process process = null;

	if( pname == "NONE" )
	{
		System.Console.WriteLine("Process stopper canceled.");
		CommandHandler(commandGiven);
		return;
	}

	string temp;
	foreach (Process p in processes)
	{
		temp = p.ProcessName.ToUpper();

		//if (Convert.ToString(process).ToUpper().Contains(pname.ToUpper()))
		if( temp.IndexOf( pname ) > -1 )
		{
			process = p;
			break;
		}
	}

	if( process != null )
	{
		process.Kill();
		System.Console.WriteLine(process.ProcessName + " has been stopped.");
	}
	else
	{
		System.Console.WriteLine(pname + " is not a valid process name. Please try again.");
		stopProcess();
	}
}

[Storm33229]

Originally Posted by Joeku

Process Members

Try this:

static void stopProcess()
{
    System.Console.Write("What process would you like to stop?: ");
    string pname = System.Console.ReadLine().ToUpper();
    Process[] processes = Process.GetProcessesByName(pname);
    Process process = null;

    if( pname == "NONE" )
    {
        System.Console.WriteLine("Process stopper canceled.");
        CommandHandler(commandGiven);
        return;
    }

    string temp;
    foreach (Process p in processes)
    {
        temp = p.ProcessName.ToUpper();

        //if (Convert.ToString(process).ToUpper().Contains(pname.ToUpper()))
        if( temp.IndexOf( pname ) > -1 )
        {
            process = p;
            break;
        }
    }

    if( process != null )
    {
        process.Kill();
        System.Console.WriteLine(process.ProcessName + " has been stopped.");
    }
    else
    {
        System.Console.WriteLine(pname + " is not a valid process name. Please try again.");
        stopProcess();
    }
}

Yay it works now