Sorious' [ViewStabled Command...

[Jeff]

Ok, very simple, every wanna check what a player has in his stable. Well I have, yet never knew the command for it( or if one existed ). Anyway I recently saw a post on one of the forums of someone wondering how to do this, so i through this together. I am not going to support this with further update. It is what it is and will not be improved on cause frankly I don't have time. I wil l however try to fix crash related bugs if they occur.

Update 1.01
-Fixed a crash bug.

Installation:
The installation is very simple.

1. Unzip the package, and extract it to somewhere in your Scripts folder.
2. Reboot server.
3. Type [viewstabled and click on a target.

Known Bugs:
None at the moment.

Things to know:
There are a few flaws that will happen from using this command. It does not pay attention to the follower count on the specified player( this was done on purpose but you need to know it ). If you open the gump and click on one of the pets it will be sent to the player that owns it, thus upping the count of followers they have so be aware of this.

Hope you like it.

[Joeku]

        public override void OnResponse( NetState sender, RelayInfo info )
        {
            int index = info.ButtonID - 1;

            BaseCreature pet = ( BaseCreature )m_List[index];

            pet.SetControlMaster( m_Targeted );

            if( pet.Summoned )
                pet.SummonMaster = m_Targeted;

            pet.ControlTarget = m_Targeted;
            pet.ControlOrder = OrderType.Follow;

            pet.MoveToWorld( m_Targeted.Location, m_Targeted.Map );

            pet.IsStabled = false;
            m_Targeted.Stabled.Remove( pet );
        }

Add:

if( m_Targeted.Followers + pet.ControlSlots > m_Targeted.FollowersMax )
{
   m_Targeted.SendMessage("You cannot un-stable this pet, because you don't have enough control slots to do so!");
   return;
}

[Jeff]

Originally Posted by Joeku

        public override void OnResponse( NetState sender, RelayInfo info )
        {
            int index = info.ButtonID - 1;

            BaseCreature pet = ( BaseCreature )m_List[index];

            pet.SetControlMaster( m_Targeted );

            if( pet.Summoned )
                pet.SummonMaster = m_Targeted;

            pet.ControlTarget = m_Targeted;
            pet.ControlOrder = OrderType.Follow;

            pet.MoveToWorld( m_Targeted.Location, m_Targeted.Map );

            pet.IsStabled = false;
            m_Targeted.Stabled.Remove( pet );
        }

Add:

if( m_Targeted.Followers + pet.ControlSlots > m_Targeted.FollowersMax )
{
   m_Targeted.SendMessage("You cannot un-stable this pet, because you don't have enough control slots to do so!");
   return;
}

Then you gotta have the player put there pet away to check out what they have, i left it out on purpose. I was just warning everyone, But if anyone wants it they can add it themselves thanks for the reply tho.

[Joeku]

I meant on the OnResponse method (the button that they click to unstable the pet, not to view their pets.) Unless I am incorrect in my assumption of what this script is...

[Jeff]

Originally Posted by Joeku

I meant on the OnResponse method (the button that they click to unstable the pet, not to view their pets.) Unless I am incorrect in my assumption of what this script is...

ya, it simple brings up the same gump you get when you say [claimlist, thus clicking on a pet would call it out of the stable. This is what I intended it to do, I could extend on the idea a bit but like I said in my post this was a simple thing I did cause I needed it, and this is all I needed. If anyone wants to take on this script and mod it to something more useful well, be my guest...

[Lord Neo]

First Time I tried using this it crashed the server. It crashes right when you right click the gump to close it.
Heres the crash report in debug mode.

Server Crash Report
===================

Operating System: Microsoft Windows NT 5.1.2600.0
.NET Framework: 1.1.4322.2032
Time: 2/1/2006 6:29:54 AM
Mobiles: 20921
Items: 371802
Clients:
- Count: 2


Exception:
System.ArgumentOutOfRangeException: Index was out of range.  Must be non-negative and less than the size of the collection.
Parameter name: index
   at System.Collections.ArrayList.get_Item(Int32 index)
   at Server.StableHelper.StabledGump.OnResponse(NetState sender, RelayInfo info) in c:\Program Files\RUNUO\RunUO Software Team\RunUO 1.0\Scripts\Custom\ALL New Stuff\StableHelper\StableHelper.cs:line 98
   at Server.Network.PacketHandlers.DisplayGumpResponse(NetState state, PacketReader pvSrc)
   at Server.Network.MessagePump.HandleReceive(NetState ns)
   at Server.Network.MessagePump.Slice()
   at Server.Core.Main(String[] args)

[Jeff]

Originally Posted by Lord Neo

First Time I tried using this it crashed the server. It crashes right when you right click the gump to close it.
Heres the crash report in debug mode.

Server Crash Report
===================

Operating System: Microsoft Windows NT 5.1.2600.0
.NET Framework: 1.1.4322.2032
Time: 2/1/2006 6:29:54 AM
Mobiles: 20921
Items: 371802
Clients:
- Count: 2


Exception:
System.ArgumentOutOfRangeException: Index was out of range.  Must be non-negative and less than the size of the collection.
Parameter name: index
   at System.Collections.ArrayList.get_Item(Int32 index)
   at Server.StableHelper.StabledGump.OnResponse(NetState sender, RelayInfo info) in c:\Program Files\RUNUO\RunUO Software Team\RunUO 1.0\Scripts\Custom\ALL New Stuff\StableHelper\StableHelper.cs:line 98
   at Server.Network.PacketHandlers.DisplayGumpResponse(NetState state, PacketReader pvSrc)
   at Server.Network.MessagePump.HandleReceive(NetState ns)
   at Server.Network.MessagePump.Slice()
   at Server.Core.Main(String[] args)

Hmm odd, weird it did that, cause I didnt code it, its the code straight out of the distro, of well, ill look at it today if possible.

[goddessoflight]

thanks for another good script but i do have a question for you sorious i dont know what time you have but im working on a quest and have hit a snag and was woundering if you could help me with it contact me by email and ill explain it all if you have the time thanks

[arul]

Originally Posted by Sorious

Hmm odd, weird it did that, cause I didnt code it, its the code straight out of the distro, of well, ill look at it today if possible.

When you close the gump (right click) it sends to the server gumpresponse with button id 0, which in this case results in negative index and exception is thrown.

[Jeff]

Originally Posted by Seanchen.net

Simple fix:

int index = 0;
if ( info.ButtonID > 0 )
{
index = info.ButtonID - 1;
}

It might complain about doing that, if it does move the code inside the if block. There is only one possible error, its going to complain about setting a value within a if block, if you get any other error besides that then its your fault. I give permission to use this block of code to anyone who wants to support it, but do not contact me for help, because I will not answer your questions about it.

Thanks Seanchen.net

[Lord Neo]

might be a good idea to update the script in the first post.

[Jeff]

Originally Posted by Lord Neo

might be a good idea to update the script in the first post.

Updated

[Lord Neo]

Originally Posted by Sorious

Updated

The script does not crash the server anymore, but when you go to close the GUMP by right clicking it, it will pull ONE of the players PETS from the stable!

[arul]

The way it is fixed is quite complicated in vain.
Simply do

if( info.ButtonID == 0 )
     return;

int index = info.ButtonID - 1;

// rest of the code...