[2.0 RC1, 1.0 Final] Knives' TownHouses 2.0

[Prohor Meletevich]

Originally Posted by Rocko Wang

Not sure if this issue has ever been brought up or if it was just my own issue:

I am using the TownHouse 2.0, I create a townhouse on one of the static house, then set the ban location to somewhere outside the house.

Then on a server restart, if I use the player context menu entry "leave house" (single click on myself) while I am inside the house, regardless whether I am the owner of the house or not, I will be ported to not the ban location (as it supposed to) but the top left corner inside the house region.

If I reset the ban location, as long as I do not restart server, it will port me correctly to the ban location. However, on a server restart, it will go back to the previous behavior.

Has anyone seen something like this?

Thanks,
Rocko

Cose ban location property saves only in ancestor class from custom house class, but its need to override it instead of create a new DefaultBanLocation property. It is bug in the scipt.

[kmwill23]

Originally Posted by Prohor Meletevich

Cose ban location property saves only in ancestor class from custom house class, but its need to override it instead of create a new DefaultBanLocation property. It is bug in the scipt.

You are correct! I am surprised no one mentioned this bug earlier =) Now I have to look at what files I changed so I can put a patch up...

[DevXLX]

Got a smaller issue to report.

Perhaps this is only for large production shards, but:

When a players rent's a home or demolishes, the shard suffers a small .5 sec lagspike.
(tested many times on a shard with 500players online, but we got really powerful hardware which supposedly reduces the spike time)


Feature's I'd love to see (for 1.0 and 2.0 version):

First: Ability for the Staff to decide if the house is ONLY Private or ONLY Public or Default (player can decide then as with a normal house)
Why? because if we setup homes for young players in towns they won't stop using them because they can make them public
and run the most perfect vendor shop. Also because it would be nice being able to create some homes that are public ONLY, so strangers
don't flag grey inside them and vice versa it'd be nice to setup some that are not allowed going public, so they are only useful for storage.

Second: Ability for staff to disallow trading of the house (as the normal house sign menu allows players to trade the building away to another)

Finaly, this is a question:
If you set the home to only be allowed rented by youngs, does it take into consideration once the owner character is no longer young and kick him/her?

Thanks for reading



/

[Twilightal]

problem aboutt his si when some house signs are deleted it crashes the shard...

[kmwill23]

Originally Posted by DevXLX

Got a smaller issue to report.

Perhaps this is only for large production shards, but:

When a players rent's a home or demolishes, the shard suffers a small .5 sec lagspike.
(tested many times on a shard with 500players online, but we got really powerful hardware which supposedly reduces the spike time)


Feature's I'd love to see (for 1.0 and 2.0 version):

First: Ability for the Staff to decide if the house is ONLY Private or ONLY Public or Default (player can decide then as with a normal house)
Why? because if we setup homes for young players in towns they won't stop using them because they can make them public
and run the most perfect vendor shop. Also because it would be nice being able to create some homes that are public ONLY, so strangers
don't flag grey inside them and vice versa it'd be nice to setup some that are not allowed going public, so they are only useful for storage.

Second: Ability for staff to disallow trading of the house (as the normal house sign menu allows players to trade the building away to another)

Finaly, this is a question:
If you set the home to only be allowed rented by youngs, does it take into consideration once the owner character is no longer young and kick him/her?

Thanks for reading

/

Nice ideas! I will also look at the lag spike. I imagine it is the moving of items to the player's bank.

Finally, the system does check young status every server save =)

It's nice to see a report from a larger shard. Your ideas will really help stablize and expand the system =)

[kmwill23]

Originally Posted by Twilightal

problem aboutt his si when some house signs are deleted it crashes the shard...

This crash is a RunUO bug, and has been fixed in the SVN. It does suck, no doubt. It's also fairly unpredictable. Sometimes homes delete without any problems.

[kmwill23]

I've decided there are enough ideas now to warrent a 2.01 =) I will begin work on it April 1st!

[WonderlandADnc]

i cant wait kmwill23 great work, i am alway trying to think of somthing to add to your townhouses. and one day i hope to do so. all the best

[DevXLX]

Originally Posted by kmwill23

Nice ideas! I will also look at the lag spike. I imagine it is the moving of items to the player's bank.

Finally, the system does check young status every server save =)

It's nice to see a report from a larger shard. Your ideas will really help stablize and expand the system =)

Thanks, I very much appreciate the swift reply!

I just want to add that the spike occurs when renting or purchasing the house, the second you accept the sign conditions (click ok), the spike happends.
Same with demolish, the second you click ok to the demolish, a spike occurs.

It's not long, usually 0.5 seconds - but on large shards if you create many of these homes it can be a problem.

Also, I want to applaud that you support this script for 1.0.
Many contributors have completely forgotten that 1.0 is still latest RunUO release that is adviced for production servers and 2.0 is specificly not adviced.

So on behalf of all the online 1.0 base shards, I applaud your efforts to service both sides of the community.

/

[qwerty84]

How I can modify the cost calculator?
My purpose is the increasing of my cost to 5k per title

[kmwill23]

Open up TownHouses/Misc/General.cs, and right near the top you'll find exactly what you are looking for =)

[qwerty84]

Thank you for the information I would require new information how I can disable the push button for the distruction

[zartanian]

Is it possible to have the player sign a lease?
Is it possible to have a player sign a lease on a rental agreement?

Owning a home in the middle of Brit is great, but has to come with a price. I want to be able to increase the players rent when his lease is up for renewal (based on the age of the account). The older the account the higher the rent would be. I basically want the homes rented by new players to give them a better understanding of the game (but still giving the vet the option to keep his home at a higher cost) while own a home they normally could not. I considered doing it via a skill point system but that always leaves room for an exploit.

Any advice would be great!

[iwantmypot]

What I'd like to see is the ability to make some houses customizable. Preferably as an option in the setup.

The reason I would like this is because I was considering making it so I could hide townhouses in forest clearings that won't normally allow a house, and allow players to just keep it a clearing and lock down their items, OR build their own house within the clearing.

Of course, custom houses would have to lock themselves between 3 and 4 floor levels instead of allowing it to be assigned to anything. (otherwise you'd probably have to modify the house builder)


--EDIT--

Another thing I just thought of... you might want to make it not delete statics that have the Wall flag... There was a building in Haven I turned into a house, that didn't have a piece of wall as part of the map file, and when someone bought it without the items in it, the wall vanished.

--another edit--

Maybe include statics with the surface flag, so it doesn't delete floors, but I think this would leave a lot of extra pieces because I believe the surface flag is what makes things not highlight when you mouse-over them.

The only way to guarantee no walls or floors are deleted, and everything else is, would be to compile a list of floor and wall itemid's to exclude from the items list. That'd be a pain in the butt.

[kmwill23]

Originally Posted by iwantmypot

What I'd like to see is the ability to make some houses customizable. Preferably as an option in the setup.

The reason I would like this is because I was considering making it so I could hide townhouses in forest clearings that won't normally allow a house, and allow players to just keep it a clearing and lock down their items, OR build their own house within the clearing.

Of course, custom houses would have to lock themselves between 3 and 4 floor levels instead of allowing it to be assigned to anything. (otherwise you'd probably have to modify the house builder)


--EDIT--

Another thing I just thought of... you might want to make it not delete statics that have the Wall flag... There was a building in Haven I turned into a house, that didn't have a piece of wall as part of the map file, and when someone bought it without the items in it, the wall vanished.

--another edit--

Maybe include statics with the surface flag, so it doesn't delete floors, but I think this would leave a lot of extra pieces because I believe the surface flag is what makes things not highlight when you mouse-over them.

The only way to guarantee no walls or floors are deleted, and everything else is, would be to compile a list of floor and wall itemid's to exclude from the items list. That'd be a pain in the butt.

Unfortunately, the kind of customizing you are looking for can't be done with the system as it currently is. Even then, adding new items to the house would be tricky, and removing them even trickier. I've actually tried both of these =) You would also never be able to remove map statics, which is one thing many players really want.

You are right, excluding specific items from deletion on buying a home is tedious, and not really worth the effort. There also may be cases where a shard may not want to exclude walls and surfaces from this. In your specific case, I recommend selecting the option not to delete anything, and not to give the items to the player.

[kmwill23]

Originally Posted by zartanian

Is it possible to have the player sign a lease?
Is it possible to have a player sign a lease on a rental agreement?

Owning a home in the middle of Brit is great, but has to come with a price. I want to be able to increase the players rent when his lease is up for renewal (based on the age of the account). The older the account the higher the rent would be. I basically want the homes rented by new players to give them a better understanding of the game (but still giving the vet the option to keep his home at a higher cost) while own a home they normally could not. I considered doing it via a skill point system but that always leaves room for an exploit.

Any advice would be great!

Expanding on the current rental system may not be a bad idea =)

[Grimklash]

I did notice something you might want to add in.

Neither staff or players can place a vendor rental contract in a townhouse.

[kmwill23]

We place vendor contracts in town houses all the time. I think it might have a blind Owner check, which may discount staff. Check the owner of the home.

[kmwill23]

April 2nd! As promised, I have started updating to version 2.01!

Here's my plans for this update:

- Forced Private, Public options
- No Trading option
- Expanded [TownHouses menu, including a listing for regular houses
-- Normal houses are always difficult to get a [props on, so I will add props buttons, goto buttons, and displaying who the owner is.

And more ideas from everyone in this direction? Or other directions! I know there was a suggestion for a rental system expansion, but that is a major effort better left to its own update. Also requires quite a bit of design work =) So not this update!

~

Addition:

I am also curious on your thoughts about possibly expanding the TownHouses project into the realm of regular homes. Examples: You can rent parts of homes currently; I will be adding regular home searches and lists; I can impose rules on regular homes, like preventing trading, forcing private or public.

Of course I'd need more ideas to pull something like this off. What would you find useful in having more control over regular home features like this?

[zartanian]

I think the system so far is awesome and love the ability to rent homes inside towns.

One feature I would love to see is a lease agreement. When the lease expires it will automatically increase at a predetermined percentage. Player must agree to the increased rent (within a set time) or be evicted/moved to the bank and have the house returned to the market.

[MetallicSomber]

Im having a weird message appear in the server window when my GM makes a room rentable. each time he has done it now it spams a pair of 1s in the server window.

RunUO - [www.runuo.com] Version 2.0, Build 2357.32527
Core: Running on .NET Framework Version 2.0.50727
...
Client: 75.126.37.2: Connected. [2 Online]
Client: 75.126.37.2: Disconnected. [1 Online]
1
1
1
1
1
1
1
1
1
1

any ideas what causes this? Ive had this problem before but have never been able to figure out what exactly was causing it.

[kmwill23]

Originally Posted by MetallicSomber

Im having a weird message appear in the server window when my GM makes a room rentable. each time he has done it now it spams a pair of 1s in the server window.

RunUO - [www.runuo.com] Version 2.0, Build 2357.32527
Core: Running on .NET Framework Version 2.0.50727
...
Client: 75.126.37.2: Connected. [2 Online]
Client: 75.126.37.2: Disconnected. [1 Online]
1
1
1
1
1
1
1
1
1
1

any ideas what causes this? Ive had this problem before but have never been able to figure out what exactly was causing it.

I am almost 100% certain that is not TownHouses. I have looked through all the scripts, and all the Console calls are accounted for. You are running 2.0?

[MetallicSomber]

Originally Posted by kmwill23

I am almost 100% certain that is not TownHouses. I have looked through all the scripts, and all the Console calls are accounted for. You are running 2.0?

Ya 2.0 RC1. It happens everytime the GM makes a room rentable. If its not this system doing it any ideas on where to look to find an answer? so far it hasn't done any 'harm" that i can see. just wondering how to fix it of it it really is damageing in some way.

Sorry for the late reply I have had a crazy past few days.

[qwerty84]

 + Custom/System/Twon Houses/Items/TownHouse.cs:
    CS0114: Line 46: 'Knives.TownHouses.TownHouse.BaseBanLocation' hides inherited member 'Knives.TownHouses.VersionHouse.BaseBanLocation'. To make the current member override that implementation, add the override keyword. Otherwise add the new keyword.