[2.0 RC1, 1.0 Final] Knives' TownHouses 2.0

[qwerty84]

I have of the large problems with English I try to signal with my possibility.

[qwerty84]

 + Multis/BaseHouse.cs:
    CS0429: Line 58: Unreachable expression code detected
    CS0162: Line 61: Unreachable code detected
 + Multis/HouseSign.cs:
    CS0429: Line 103: Unreachable expression code detected
    CS0162: Line 105: Unreachable code detected

This problem is resolving with removing following code?

remove in basehouse.cs:

public virtual bool IsInside( Point3D p, int height )
		{
			if ( Deleted )
				return false;

			MultiComponentList mcl = Components;

			int x = p.X - (X + mcl.Min.X);
			int y = p.Y - (Y + mcl.Min.Y);

			if ( x < 0 || x >= mcl.Width || y < 0 || y >= mcl.Height )
				return false;

			if ( this is HouseFoundation && y < (mcl.Height-1) && p.Z >= this.Z )
				return true;

			Tile[] tiles = mcl.Tiles[x][y];

			for ( int j = 0; j < tiles.Length; ++j )
			{
				Tile tile = tiles[j];
				int id = tile.ID & 0x3FFF;
				ItemData data = TileData.ItemTable[id];

				// Slanted roofs do not count; they overhang blocking south and east sides of the multi
				if ( (data.Flags & TileFlag.Roof) != 0 )
					continue;

				// Signs and signposts are not considered part of the multi
				if ( (id >= 0xB95 && id <= 0xC0E) || (id >= 0xC43 && id <= 0xC44) )
					continue;

				int tileZ = tile.Z + this.Z;

				if ( p.Z == tileZ || (p.Z + height) > tileZ )
					return true;
			}

			return false;
		}

And add this code:

public virtual bool IsInside(Point3D p, int height)
        {
            Sector sector = Map.GetSector(p);

            foreach (BaseMulti m in sector.Multis)
            {
                if (m != this
                && m is Knives.TownHouses.TownHouse
                && ((Knives.TownHouses.TownHouse)m).ForSaleSign is Knives.TownHouses.RentalContract
                && ((Knives.TownHouses.TownHouse)m).IsInside(p, height))
                    return false;
            }

            return Region.Contains(p);
        }

?????????

excuse my terible english

[kmwill23]

I know exactly what you are asking =)

That part bugs me too. It's been a while since I've looked at it, maybe I'll find something new.

[Dr. Phillie]

Leave house/ban bug, we need patch for this, NOW!

[HellRazor]

Well. That was rude.

[Dr. Phillie]

Dont take it too serious

[HellRazor]

But the internet is SERIOUS BUSINESS! :P

Throw a smiley on the end next time. Otherwise the joke gets lost in the translation.

[Dr. Phillie]

Okey papa bear

[kmwill23]

Once I get around to uploading the new version, the fix is in there =) RL is dragging me along atm!

[Dr. Phillie]

Any plans when you will release the 2.1?
My players are getting angry about that bug :P
Any way of some small Hotfix for that?

[kmwill23]

Update!

It's a bit late, but here you go =) Let me know if there are any problems!

[Dr. Phillie]

Errors:
 + custom/Town Houses v2.01/Misc/GumpResponse.cs:
    CS0266: Line 28: Cannot implicitly convert type 'System.Collections.Generic.
IEnumerable<Server.Gumps.Gump>' to 'System.Collections.Generic.List<Server.Gumps
.Gump>'. An explicit conversion exists (are you missing a cast?)

[kmwill23]

You are using RunUO 1.0?

Thanks for finding this, I will update it immediately.

~

Addition:

Try this file and let me know =)

[Dr. Phillie]

Errors:
 + custom/Town Houses v2.01/Misc/GumpResponse.cs:
    CS1502: Line 28: The best overloaded method match for 'System.Collections.Ar
rayList.ArrayList(int)' has some invalid arguments
    CS1503: Line 28: Argument '1': cannot convert from 'System.Collections.Gener
ic.IEnumerable<Server.Gumps.Gump>' to 'int'

RunUO 2 svn

[Alari]

With RunUO 2.0 SVN I got this error with the new Townhouses download:

Errors:
+ _Custom/Packages/Knives/Town Houses v2.01/Misc/GumpResponse.cs:
CS0266: Line 28: Cannot implicitly convert type 'System.Collections.Generic.IEnumerable<Server.Gum ps.Gump>' to 'System.Collections.Generic.List<Server.Gumps.Gump >'. An explicit conversion exists (are you missing a cast?)

I tried that updated GumpResponse.cs and got:

Errors:
+ _Custom/Packages/Knives/Town Houses v2.01/Misc/GumpResponse.cs:
CS1502: Line 28: The best overloaded method match for 'System.Collections.ArrayList.ArrayList(int)' has some invalid arguments
CS1503: Line 28: Argument '1': cannot convert from System.Collections.Generic.IEnumerable<Server.Gump s.Gump>' to 'int'

[kmwill23]

That was me assuming RunUO 1.0 =)

Try this new one. Removing the one that didn't work!

[Alari]

It compiles. ^.^ (Haven't tested it yet, but I'm sure it works) Thanks!

[Zorteper]

I get this Error when Compiling :

RunUO - [www.runuo.com] Version 2.0, Build 2357.32527
Core: Running on .NET Framework Version 2.0.50727
Core: Optimizing for 2 processors
Scripts: Compiling C# scripts...failed (1 errors, 0 warnings)
Errors:
 + Custom/Town Houses v2.01/Items/TownHouse.cs:
    CS0246: Line 10: The type or namespace name 'VersionHouse' could not be found (are you missing a using directive or an assembly reference?)
Scripts: One or more scripts failed to compile or no script files were found.
 - Press return to exit, or R to try again.

The line @ that spot is :

	public class TownHouse : VersionHouse

Can't seem to find a Solution for this one... Please advice

[Neouni]

RUOVersion.cs defines it,
you probably didn't install it properly

[Zorteper]

Originally Posted by Neouni

RUOVersion.cs defines it,
you probably didn't install it properly

d'oh ... That did the trick

I misread... sorry.. I thought you only needed RUOVersion.cs if you ran on the 1.0 Core... Thanks alot, Neouni

[moonrune]

Thanks, this town house system is really wonderful and bring a new live in the shard cities.

[Gaia the Goddess]

When a player demolished, the server crashes and I get this error:

Any fix for this?

Exception:
System.NullReferenceException: Object reference not set to an instance of an object.
   at Server.Map.RemoveMulti(BaseMulti m, Sector start, Sector end)
   at Server.Map.OnLeave(Item item)
   at Server.Item.Delete()
   at Server.Gumps.HouseDemolishGump.OnResponse(NetState state, RelayInfo info)
   at Server.Network.PacketHandlers.DisplayGumpResponse(NetState state, PacketReader pvSrc)
   at Server.Network.MessagePump.HandleReceive(NetState ns)
   at Server.Network.MessagePump.Slice()
   at Server.Core.Main(String[] args)

Thanks in advanced !!

[kmwill23]

This crash is caused by a RunUO 2.0 bug. If you are able to download and compile the most recent SVN, the problem is corrected.

[Rhionnan]

What files on the SVN that thing just confuses the heck out of me.

[Drachnyen]

If I was gonna give you a grade on all your scripts i would give you a
A++++++++++ Because Your Scripts Are Allways great man