[RunUO 2.0 Svn][OSI] Mondain's Legacy

[Trip3033]

this system is all unorginazed.... the scripts are everywhere and not in right sub sections. get alot of namespace already excists

[Erica]

Originally Posted by koluch

// discord
public virtual bool CanDiscord{ get{ return true; } }
public virtual int DiscordDuration{ get{ return 20; } }
public virtual int DiscordMinDelay{ get{ return 22; } }
public virtual int DiscordMaxDelay{ get{ return 5; } }
public virtual double DiscordModifier{ get{ return 0.28; } }

// provocation
public virtual bool CanProvoke{ get{ return true; } }
public virtual int ProvokeMinDelay{ get{ return 5; } }
public virtual int ProvokeMaxDelay{ get{ return 5; } }

Discord MinDelay is 22
Discord MaxDelay is 5

Just noticed those numbers and wanted to confirm that is correct?

Thanks!

Koluch

Should look like this.

public virtual bool CanDiscord{ get{ return true; } }
public virtual int DiscordDuration{ get{ return 20; } }
public virtual int DiscordMinDelay{ get{ return 5; } }
public virtual int DiscordMaxDelay{ get{ return 22; } }
public virtual double DiscordModifier{ get{ return 0.28; } }

MinDelay 5 and MaxDelay 22

[koluch]

Originally Posted by Erica

Should look like this.

public virtual bool CanDiscord{ get{ return true; } }
public virtual int DiscordDuration{ get{ return 20; } }
public virtual int DiscordMinDelay{ get{ return 5; } }
public virtual int DiscordMaxDelay{ get{ return 22; } }
public virtual double DiscordModifier{ get{ return 0.28; } }

MinDelay 5 and MaxDelay 22

:]
Yeah figured he might want to change that in his release.

Out of curiousity...Ill ask once more if anyone else is having the set armor self repair issue, i.e. It doesnt self repair on sets?

Thanks!

Koluch

[mitty]

Every time I post here Mal I get no friggin help. I figured out the walls and switches myself. Just got done placing em by hand. Your Citadel CFG is messed up and also all the peerless timers are wacked. If you leave any boss area before your timers boot ya after looting (10 mins) You can leave early and it pops you back to the exit area when the timer runs out!(No matter where ya go! I posted my errors at Ericas asking and even pmed you 2 times. I'm not being a jerk or an ass but I try to respond ASAP to others when they post anywhere on the forums. I at least say/respond I don't have an answer. I try to be a part of a community and give and take equally, but very frustrated at any help here, for this script/package.

[koluch]

Originally Posted by mitty

If you leave any boss area before your timers boot ya after looting (10 mins) You can leave early and it pops you back to the exit area when the timer runs out!(No matter where ya go! I posted my errors at Ericas asking and even pmed you 2 times. I'm not being a jerk or an ass but I try to respond ASAP to others when they post anywhere on the forums. I at least say/respond I don't have an answer. I try to be a part of a community and give and take equally, but very frustrated at any help here, for this script/package.

This is a very complicated system to say the least.
I personally have not had any issues as you posted above with being popped back to the exit area after leaving, and we have done all but Prox and the Citidel may times each.(we do not have those areas spawned as of yet and open to players)

This thread is huge and lots of things are posted.
The SVN made tracking easier, but that has shut down and had to be replaced with the google link.

I'd say...go slow, hang in there.
I know everyone is working to find little issues to help Mal out on this release.
If it werent for his work....well we would stil have ....wait, that wasnt completed either..ok AOS then :]

Koluch :]

[Melchior]

As of SVN 300 the interface ICommodity (defined in CommodityDeed.cs) is expanded to contain an additional member: 'int DescriptionNumber{ get; }';as a result the last ML SVN (10) wont compile because Switch.cs does not completely adheres to that interface.

I added the line in red to remedy this:

using System;

namespace Server.Items
{
	public class Switch : Item, ICommodity
	{
		public override int LabelNumber{ get{ return 1073464; } } // Switch
		
		string ICommodity.Description
		{
			get
			{
				return String.Format( "{0} switch", Amount );
			}
		}

		int ICommodity.DescriptionNumber { get { return LabelNumber; } }
		
		[Constructable]
		public Switch() : this( 1 )
		{
		}
	
		[Constructable]
		public Switch( int amount ) : base( 0x2F5F )
		{
			Weight = 1;
			Stackable = true;
			Amount = amount;
		}

		public Switch( Serial serial ) : base( serial )
		{
		}

		public override void Serialize( GenericWriter writer )
		{
			base.Serialize( writer );
			
			writer.Write( (int) 0 ); // version
		}

		public override void Deserialize( GenericReader reader )
		{
			base.Deserialize( reader );
			
			int version = reader.ReadInt();
		}
	}
}

Furthermore, the included (in Distro) container.cs does not include a 'commented out' block in the deserialize function while the installation instruction still require that the block should be un-commented directly after the first start and shutdown (with save).

[Grom09]

im sorry, i posted something back in the 30 pages, i stopped for a while
where is the DL for the ML pack, i remember you had something different. but i really need the mondains package, i've been trying to get it since i got SVN.

[Melchior]

As stated on the first post on this thread, you can download ML from the google repository at:

mondains-legacy - Google Code

You will need to have a compatible SVN management package installed like TortoiseSVN to get the software.

Also, Lokai has made a simple ML installer available combined wit Nerun's release at:

[RunUO 2.0 SVN] Mondain's Legacy Simple Installs (with Nerun's Distro)

[Melchior]

@ koluch:

Are you still looking into that self repair issue on armor sets? As i see it, it is caused by the discrepancies that are introduced due to the current expansion. Some pieces of software require AOS to be true (to get paragons p.e.) othes require ML (like treasures of tokuno); it seems that the current expansion types are mutually exclusive while is some cases both should be true. Possible solution is to change basearmor.cs and let the repair be done: 'if OAS or ML' instead of just 'if AOS'.

Added:

Seems to be more to it: When i checked, m_AosArmorAttributes.SelfRepair was zero when it was supposed to be three. Somehow the values of SetArmorAttribute dont seem to propagate properly, so i must look a bit further.

[MalGanis]

ello every1, sorry for the delay, ive been veeery busy lately.

@mitty
First of all, did you merge Decorate.cs. Check if you have latest \Mondain's Legacy\Items\Doors\SlidingDoors.cs and \Mondain's Legacy\Items\Misc\The Citadel\Teleporters.cs and all the doors inside. (compare them with Revision 11: /trunk )

@Melchior
Thanks for the reports.

Since latest SVN (11) you need Abilities for Mondain's Legacy or [RunUO 2.0] Closer to OSI ML weapon abilities

[mitty]

I figured it out and added them all manually. Sorry for venting but I had players freaking and couldnt figure it out. So I put nose to grindstone just added manually. This is a great package and thanks again for coming up with it. (Only human I am).

[Grom09]

ok, when i put the simple installation for ML.
almost everything has the ! red mark for what was changed. and i get this
Errors:
+ Items/Containers/LockableContainer.cs:
CS0246: Line 8: The type or namespace name 'IShipwreckedItem' could not be f
ound (are you missing a using directive or an assembly reference?)

maybe i did it wrong.
becauase i had tortoise when i got SVN. and i had to rename the server.exe or something so it could work.

[MalGanis]

Check in if you have latest RunUO SVN of Items\Skill Items\Fishing\Misc\ShipwreckedItem.cs

[Melchior]

@MalGanis:

It seems that the mapping of AosAttributes is working, but the mapping of AosArmorAttributes is not. I don't really know how this should be implemented, or if there are specific OSI rules to comply to when implementing armor sets. Should it be possible to set self repair on a part of a set, and be able to set a full set self repair bonus? (AosArmorAttributes.SelfRepair = 1 and SetArmoAttributes.SelfRepair = 5). This won't work in the current implementation; doesn't show properly on the property list and is also not functioning.

[MalGanis]

I know that you can't have both aos and set properties because theres no duplicate clilocs to display both.

[Melchior]

@MalGanis:

Thanks for your reply. It is as I expected, though I still don't understand the interoperatabilty between AOS and ML: Is it mutually exclusive? That would mean that a lot of functionality would disappear when AOS needs to be disabled because ML is enabled? Anyway, still trying to find a solutions for the self repair on armor sets I tried the following:

OnHit extract taken from BaseArmor.cs SVN 11:

		public virtual int OnHit( BaseWeapon weapon, int damageTaken )
		{
			// Console.WriteLine("m_SetArmorAttributes " + m_SetArmorAttributes.SelfRepair.ToString() + " " + this.LabelNumber.ToString());

			double HalfAr = ArmorRating / 2.0;
			int Absorbed = (int)(HalfAr + HalfAr*Utility.RandomDouble());

			damageTaken -= Absorbed;
			if ( damageTaken < 0 ) 
				damageTaken = 0;

			if ( Absorbed < 2 )
				Absorbed = 2;


			if ( 25 > Utility.Random( 100 ) ) // 25% chance to lower durability, or to repair
			{
				if ( Core.AOS && m_AosArmorAttributes.SelfRepair > Utility.Random( 10 ) )
				{
					HitPoints += 2;
				}
				else
				{
					#region Mondain's Legacy
					if (( Core.ML) && (this is ISetItem))
					{
						// The hit can be on any piece of a set (this.LabelNumber identifies the specific piece (Type, not itemID))
						ISetItem item = (ISetItem) this;
						if (item.SetEquipped && (m_SetArmorAttributes.SelfRepair > Utility.Random( 10 )))
						{
							// Console.WriteLine("Repair in progress on: " + this.LabelNumber.ToString());
							HitPoints += 2;
						}
					}
					#endregion

This works for the armor sets, but because current expansion is set to Core.ML, AOS armor looses the abillity for self repair. Is this how it should be? If so, then (stated in Paragon.cs) paragon creatures are not allowed in ML?

Edit:

LOL! I found the next section in BaseWeapon.cs:

				// Mondain's Legacy Mod
				if ( Core.AOS && m_AosWeaponAttributes.SelfRepair + ( IsSetItem && m_SetEquipped ? m_SetWeaponAttributes.SelfRepair : 0 ) > Utility.Random( 10 ) )
				{
					HitPoints += 2;
				}

Bit more elegant and high school programming I guess but does the same trick.

[Lokai]

Originally Posted by Melchior

Is this how it should be?

Probably not.

Core.AOS means Expansion >= AOS. So if Expansion is ML, then Core.AOS should be True.

[Grom09]

ok, i have that file, but.
somehow the error dissapeared, and 5 new ones showed up, i did SVN update. and now there are 3... this is messed up, any advice.

ok after some SVN updating files, i get these 3.. i ReallY Want the ML so i can spawn monsters and finally be done with it!

sry. now i get this
Errors:
 + Engines/Harvest/Core/HarvestDefinition.cs:
    CS0246: Line 25: The type or namespace name 'BonusHarvestResource' could not
 be found (are you missing a using directive or an assembly reference?)
    CS0246: Line 56: The type or namespace name 'BonusHarvestResource' could not
 be found (are you missing a using directive or an assembly reference?)
    CS0246: Line 134: The type or namespace name 'BonusHarvestResource' could no
t be found (are you missing a using directive or an assembly reference?)

[Melchior]

Thanks Lokai! I finally get it. I had not seen the file ExpansionInfo.cs yet! Cleaned up my code and all is working properly. Just need to make sure that ML set armor never uses the AosAttributes and AosArmorAttributes.

[MalGanis]

@Grom09
Chek if you have: \Engines\Harvest\Core\BonusHarvestResource.cs

[koluch]

Originally Posted by Melchior

Thanks Lokai! I finally get it. I had not seen the file ExpansionInfo.cs yet! Cleaned up my code and all is working properly. Just need to make sure that ML set armor never uses the AosAttributes and AosArmorAttributes.

ACK!
Ok you had me...then ya lost me(not really that difficult :P ).
Usually I have a revelation at 3am or so but I guess on this Ill have to wait.

Is there a certain code that needs to be changed or implemented?
(Ill keep checking the google SVN, thanks !!!! )

Koluch ;]

**NOTE**
Just looking at the SetArmor.cs, I do not see self repair defined in that script.
I take it the self repair is called in the BaseArmor.cs, but.....but....ok lost my thought on this sorry , hehe.

[Melchior]

LOL! But if you are referring to the self repair not working on armor sets, then take a look at post #1441; that's how I did it. Took me a long time to figure out how this all inter-operates. When I finally did i thoughy; how about self repair a weapon sets and looked at BaseWeapon.cs, and there if found the solution implemented by Mal! (and a lot more elegant than I did, but I'm a c# apprentice).

The same piece of code can be used for BaseArmor.cs with some small changes.My guess is that Mal simply forgot to put this bit of code in BaseArmor

[koluch]

Originally Posted by Melchior

LOL! But if you are referring to the self repair not working on armor sets, then take a look at post #1441; that's how I did it. Took me a long time to figure out how this all inter-operates. When I finally did i thoughy; how about self repair a weapon sets and looked at BaseWeapon.cs, and there if found the solution implemented by Mal! (and a lot more elegant than I did, but I'm a c# apprentice).

The same piece of code can be used for BaseArmor.cs with some small changes.My guess is that Mal simply forgot to put this bit of code in BaseArmor

public virtual int OnHit( BaseWeapon weapon, int damageTaken )
{
double HalfAr = ArmorRating / 2.0;
int Absorbed = (int)(HalfAr + <