a small fix for contaiiners

[Lord_Greywolf]

UPDATED!!!

have you ever noticed that when a container is full on items, but some of them are stackable
and you want to add more into it that go with the stackable ones, that you can't?

well here is a simple fix for it

this also makes it nice for combining piles if they ever happen again lol - just drag insame bag and they combine up if possible

only draw back is you can not have multiple stacks of the same item that could stack (i.e. 5 stacks of 1 coin each, would need to be 30001 or more each)
also not tested but probably will hapen is in treasure chests, etc etc that stacks of reagent, etc will combine where same type

it does not effect the max stacking of 60k, etc, still abides by it, etc

the adding in part is optional - that would probably keep them from combining if you want seperate stacks when placing by hand in there
but still need the line moved for best results

open container.cs in the tiem/containers directory

there are 2 sections to find
1 just needs a line moved and some inserted
the 2nd one needs a line moved and a section added

find the lines in blue and make their sections match up with the parts in red (remember to remove the 1st line in each)

		public override bool TryDropItem( Mobile from, Item dropped, bool sendFullMessage )
		{
			BaseHouse house = BaseHouse.FindHouseAt( this );
			if ( house != null && house.IsLockedDown( this ) )
			{
				if ( dropped is VendorRentalContract || ( dropped is Container && ((Container)dropped).FindItemByType( typeof( VendorRentalContract ) ) != null ) )
				{
					from.SendLocalizedMessage( 1062492 );
					return false;
				}
				if ( !house.LockDown( from, dropped, false ) ) return false;
			}
			if (!(this.RootParentEntity is PlayerVendor || this.RootParentEntity is BaseVendor))
			{
				List<Item> list = this.Items;
				for ( int i = 0; i < list.Count; ++i )
				{
					Item item = list[i];
					if ( !(item is Container) && item.StackWith( from, dropped, false ) ) return true;
				}
			}
			if ( !CheckHold( from, dropped, sendFullMessage, true ) ) return false;//was 1st line in this section
			DropItem( dropped );
			return true;
		}

		public override bool OnDragDropInto( Mobile from, Item item, Point3D p )
		{
			BaseHouse house = BaseHouse.FindHouseAt( this );
			if ( house != null && house.IsLockedDown( this ) )
			{
				if ( item is VendorRentalContract || ( item is Container && ((Container)item).FindItemByType( typeof( VendorRentalContract ) ) != null ) )
				{
					from.SendLocalizedMessage( 1062492 );
					return false;
				}
				if ( !house.LockDown( from, item, false ) ) return false;
			}
			//added section for combining
			if (!(this.RootParentEntity is PlayerVendor || this.RootParentEntity is BaseVendor))
			{
				List<Item> list = this.Items;
				for ( int i = 0; i < list.Count; ++i )
				{
					Item item1 = list[i];
					if ( !(item1 is Container) && item1.StackWith( from, item, false ) )
					{	
						from.SendSound( GetDroppedSound( item1 ), GetWorldLocation() );
						return true;
					}
				}
			}
			if ( !CheckHold( from, item, true, true ) ) return false; // was 1st line
			item.Location = new Point3D( p.X, p.Y, 0 );
			AddItem( item );
			from.SendSound( GetDroppedSound( item ), GetWorldLocation() );
			return true;
		}

nice and simple

[Corpsecrank]

Reminds me of ultima 8. You could drop all your stackables in chest or bags and they would auto-combine.

[Lord_Greywolf]

had a small problem when placing items on a player vendor to sell (like recall scrolls or ingots, etc)

so i made the fix and the 1st post has been updated to reflect this

[oiii88]

Will this fix only work with locked down / secured containers? Or will it fix the issue with when using the [grab system gold not stacking after item count or weight max iis reached?

[Lord_Greywolf]

it might fix all of claim/grab issues with that - i am not certain because i had others also
but the claim/grab is what got me to do this

i found other claim grab issues though of going over weight, etc - just keeps stacking, etc - so suddenly the pack has 15 tons in it lol
plus if you use bless bags or bags of reduction with have item limits, it goes bonkers too when in them

I had to make a lot of adjustments to claim/grab to get it working right and working with the blessed & reduction bags

[oiii88]

OK Thank you that was the issue I was having.. The 15000000 items, which in the end crash people when they recall or go into a moongate. I do not use the bless bags or reduction packs so Im hoping it wont require any editing to the claim to get it to stack gold and regs.

[Lord_Greywolf]

it should stack right BUT will still allow to go overweight though

this is how i fixed that problem

make this section look simular

		public static void DropLoot( Mobile from, Item loot, Container lootBag )
		{
			List<Item> list = lootBag.Items;
			for ( int i = 0; i < list.Count; ++i )
			{
				Item item1 = list[i];
				if ( !(item1 is Container) && item1.StackWith( from, loot, false ) )
				{
					from.PlaySound( 0x2E6 );
					return;
				}
			}
			if ( !lootBag.TryDropItem( from, loot, false ) ) loot.MoveToWorld( from.Location, from.Map );
			from.PlaySound( 0x2E6 );
		}

and i think that should fix you up then
can do gold and silver drop simular also so they do not go overweight also

and that is in claim.cs

[oiii88]

Originally Posted by Lord_Greywolf

it should stack right BUT will still allow to go overweight though

this is how i fixed that problem

make this section look simular

		public static void DropLoot( Mobile from, Item loot, Container lootBag )
		{
			List<Item> list = lootBag.Items;
			for ( int i = 0; i < list.Count; ++i )
			{
				Item item1 = list[i];
				if ( !(item1 is Container) && item1.StackWith( from, loot, false ) )
				{
					from.PlaySound( 0x2E6 );
					return;
				}
			}
			if ( !lootBag.TryDropItem( from, loot, false ) ) loot.MoveToWorld( from.Location, from.Map );
			from.PlaySound( 0x2E6 );
		}

and i think that should fix you up then
can do gold and silver drop simular also so they do not go overweight also

and that is in claim.cs

Thanks much for the snippet of code. I will give it a shot this evening once the work day ends and see how it goes.