Luck and suggested patch

[Fluke]

Because bugzilla doesn`t work I`m asking here, what actually seggested patch for bug in luck sistem in 1.0 do. The bug was that loot from creatures that drop 1 item has more increased bonuses than other with richer loot. The patch was:
lootpack.cs

public void Generate( Mobile from, Container cont, bool spawning, int luckChance )
{
	if ( cont == null )
		return;

	bool checkLuck = Core.AOS;

	for ( int i = 0; i < m_Entries.Length; ++i )
	{
		LootPackEntry entry = m_Entries[i];

		bool shouldAdd = ( entry.Chance > Utility.Random( 10000 ) );

		if ( !shouldAdd && checkLuck )
		{
			checkLuck = false;
			shouldAdd = LootPack.CheckLuck( luckChance );
//***NEW LINES ^START^
			if ( LootPack.CheckLuck( luckChance ) )
				shouldAdd = ( entry.Chance > Utility.Random( 10000 ) );
//***NEW LINES ^END^
		}

		if ( !shouldAdd )
			continue;

		Item item = entry.Construct( from, luckChance, spawning );

		if ( item != null )
		{
			if ( !item.Stackable || !cont.TryDropItem( from, item, false ) )
				cont.DropItem( item );
		}
	}
}

For me it looks like it lowers the luck chance for all and it lowers it a lot, because of the two same checks.
I`m I wright?
Is there anybody has better suggestion if I`m wright.
And again sory I`m posting it here.

[psz]

This was actually already fixed in Bugzilla ;->

I'll try AGAIN to get Ryan to fix it.

[Fluke]

I know, I`m listing the bugzilla fix and asking what the fix actualy do - doble checks your chance, so it lowers chance to get bonus double times!
Am I wrong?
Please help!

[psz]

The initial bug was that low level creatures (Slimes and corpsers, for example) were showing up with medium to high end magical equipment.

The fix, IIRC, makes it so that the chance of the low level creatures having ANY magical loot is very VERY VERY low.

[Fluke]

Ok, 10x for the answer, but does it lowers the chance for all creatures?
Because for me it looks like it lowers the chance for all. There is no check for type of the creature - low or hight.

[hirrus]

Originally Posted by psz

The initial bug was that low level creatures (Slimes and corpsers, for example) were showing up with medium to high end magical equipment.

The fix, IIRC, makes it so that the chance of the low level creatures having ANY magical loot is very VERY VERY low.

Since the bugzilla is broken for now,would it be possible to paste the Runuo Team fix here?It would be very appreciated if possible!

[Fluke]

The fix from bugzila is listed in my first post - up there, just replace function Generate in lootpack.cs or copy two lines between //***NEW LINES ^START^
and //***NEW LINES ^END^ in the source listing.
But remember that this fix will lower luck chances for all creatures, making your loot very low. I make my tests and Im sure!

I suggest another fix. Since the problem are low level creatures I suggest just disabling LootPack.Poor.
In file \Scripts\Engines\AI\Creature\BaseCreature.cs
make this:

public virtual void AddLoot( LootPack pack )
		{
			if ( Summoned )
				return;

			Container backpack = Backpack;

			if ( backpack == null )
			{
				backpack = new Backpack();

				backpack.Movable = false;

				AddItem( backpack );
			}

			pack.Generate( this, backpack, m_Spawning, m_KillersLuck );
		}

Look like this:

public virtual void AddLoot( LootPack pack )
		{
			if ( Summoned )
				return;
			
			if ( pack == LootPack.Poor )
				return;

			Container backpack = Backpack;

			if ( backpack == null )
			{
				backpack = new Backpack();

				backpack.Movable = false;

				AddItem( backpack );
			}

			pack.Generate( this, backpack, m_Spawning, m_KillersLuck );
		}

this way very low level creatures will not give items, like it was in b36, but all other creatures will give based on luck like it shoud be.

[bean56]

Would this explain why the collectors quest gives out +100 tactic weapons on my pre-aos shard? Although since it's aos is set to false i don't see how it would have any effect. However, I don't think it would explain why earth elementals now give out a magic item and I think not as many gems as they used to. I've also gotten reports of gettin statues with weird names like faction status blah.