Bug Fix in SVN - SpellHelper.cs

[HellRazor]

While playing around with the XMLAttachments system I found a bug in SpellHelper.cs.

SpellHelper.cs has a method to call Damage where the source of the spell (from) is NULL.

public static void Damage( TimeSpan delay, Mobile target, double damage, int phys, int fire, int cold, int pois, int nrgy )
{
  Damage( delay, target, null, damage, phys, fire, cold, pois, nrgy );
}

XMLAttachments make use of this so you can add an attachment to say, a cannon, and make it fire spells at people who come into range.

The bug pops up later in SpellHelper.cs when DoLeech is called. DoLeech requires from to be a mobile, but has no error checking. This results in a crash if from is null.

To fix, right before:

DoLeech( damageGiven, from, target );

add:

 if (from != null )

Also, in the OnTick method, right before:

DoLeech( damageGiven, m_From, m_Target );

Add:

if( m_From != null )

[osd_daedalus]

Surely I'm dumb and noob - but BaseCreature? I mean, do BaseCreature contain PlayerMobile also? Wouldn't this break the leeching effect for players?

What if, instead, the if statement checks Mobile instead of BaseCreature?

[HellRazor]

Originally Posted by osd_daedalus

Surely I'm dumb and noob - but BaseCreature? I mean, do BaseCreature contain PlayerMobile also? Wouldn't this break the leeching effect for players?

What if, instead, the if statement checks Mobile instead of BaseCreature?

Good catch, you're right.

Should have just inserted a check to ensure from != null. I'll update my post to correct the fix. Thanks!

[osd_daedalus]

Originally Posted by HellRazor

Good catch, you're right.

Should have just inserted a check to ensure from != null. I'll update my post to correct the fix. Thanks!

enjoy

I have also reported it in Demise forums since, as I stated almost everywhere, the RunUO official development is moving from there: maybe you want to have a look here too