Core: Item.cs

[Kamuflaro]

The mobile got a public virtual void OnMapChange( Map oldMap )
but the item doesn't remember the old map in OnMapChange().
So I'd like to have that changed to something working like in the Mobile.cs, if possible.

[Phantom]

Originally Posted by Kamuflaro

The mobile got a public virtual void OnMapChange( Map oldMap )
but the item doesn't remember the old map in OnMapChange().
So I'd like to have that changed to something working like in the Mobile.cs, if possible.

The Item doesn't have a public Map property so it really doesn't matter, at least I don't remeber it having one.

[Kamuflaro]

In the Item class:

		[CommandProperty( AccessLevel.Counselor, AccessLevel.GameMaster )]
		public Map Map
		{
			get
			{
				return m_Map;
			}
			set
			{
				if ( m_Map != value )
				{
					Map old = m_Map;

					if ( m_Map != null && m_Parent == null )
					{
						m_Map.OnLeave( this );
						SendRemovePacket();
					}

					List<Item> items = LookupItems();

					if ( items != null )
					{
						for ( int i = 0; i < items.Count; ++i )
							items[i].Map = value;
					}

					m_Map = value;

					if ( m_Map != null && m_Parent == null )
						m_Map.OnEnter( this );

					Delta( ItemDelta.Update );

					this.OnMapChange();

					if ( old == null || old == Map.Internal )
						InvalidateProperties();
				}
			}
		}

You see the OnMapChange is called, but when it is called it is too late to do anything on the map where it came from, because you don't know from which map it was removed.

[Kamron]

this.OnMapChange( old );

wouldn't work?

[Kamuflaro]

no... to get it working is the idea :P

[Kamron]

My point was to rewrite the OnMapChange function to say

public virtual void OnMapChange( Map oldmap )
{
blah blah
}

Then where it says
this.OnMapChange();
in the Map property, change it to
this.OnMapChange( old );

And you are done.