virtual OnWarmodeChanged

[Quick_silver]

It would be very nice if you add the following lines to the Mobile.cs

Line 7649:

[CommandProperty( AccessLevel.GameMaster )]
		public bool Warmode
		{
			get
			{
				return m_Warmode;
			}
			set
			{
				if( m_Deleted )
					return;

				if( m_Warmode != value )
				{
					if( m_AutoManifestTimer != null )
					{
						m_AutoManifestTimer.Stop();
						m_AutoManifestTimer = null;
					}

					m_Warmode = value;
					Delta( MobileDelta.Flags );
					OnWarmodeChanged( !m_Warmode );

					if( m_NetState != null )
						Send( SetWarMode.Instantiate( value ) );

					if( !m_Warmode )
						Combatant = null;

					if( !Alive )
					{
						if( value )
							Delta( MobileDelta.GhostUpdate );
						else
							SendRemovePacket( false );
					}
				}
			}
		}

		public virtual void OnWarmodeChanged( bool oldWarmode )
		{
		}

It is very usefull for custom scripts, to Open gumps on warmode change or other events.
Making the Warmode property virtual could be also nice.

[Courageous]

If the WarModeChanged(), whatever the current war mode is, by the time your method is called, the old one is it's opposite. It doesn't need to be pushed onto the stack.

My opinion: there's many places in the core that could provide better support for 'hooks' like this one. Yours is a good idea.

C//

[Quick_silver]

Ok, I think the "OldWarmode" is realy useless, but then you can remove the "oldFemale" some lines above, too.

[Quick_silver]

Any comments from the coders? Is it possible to add this?

[Kenko]

Of course it is, why don't you add it yourself?

[HellRazor]

He's asking if the change can be supported in the official core.

[Quick_silver]

I wrote a patch file. I Hope anyone will include it before the final release of the 2.0

[Mark]

I didn't realize this was missing. Implemented SVN 237.

public virtual void OnWarmodeChanged()