virtual OnChop in BaseAddon

[Brutus5000]

I would like to see this function virtual by default in \Items\Addons\BaseAddon.cs:

public virtual void OnChop( Mobile from )

There are a lot of Addons that might have a function or something like this and are not always allowed to be redeeded. This would allow more control about the redeed process without any modifications in BaseAddon.cs (and I think the less you have to change for a custom script, the less mistakes people make, who also want to use this script).

Example, what gives an error with current BaseAddon.cs, but works with the virtual method:

public class UltimateMachine: BaseAddon
{
[...]

  public override void OnChop(Mobile from) 
  {
      if (m_Public)
            from.LocalOverheadMessage(MessageType.Regular, 0x33, false, NotYourOwnMessage);
      else
            base.OnChop(from);
  }

[...]
}

[Malaperth]

If that method there is an override, that means that somewhere there is a virtual one that already exists that you can use, otherwise, there would be nothing to override...

[Brutus5000]

That's exactly what I mean.
Make the OnChop method in the BaseAddon.cs virtual. Otherwise you can not override the method in derived classes anyway.

[Malaperth]

You can override an override...

[Brutus5000]

In the standard RunUO Distro (RC or SVN) the OnChop method is not virtual so you can not override it anyway.

[Malaperth]

Which is exactly why I answered with this:

If that method there is an override, that means that somewhere there is a virtual one

What you posted is not part of any code in any release. And, since BaseAddon is not a core script, it is more than simple to make it virtual by yourself.

[Brutus5000]

Sorry i misunderstood (english is not my native language). What I posted is an example of a custom script that might use it. You are right it's easy to make it virtual myself but:

A lot of people release their scripts and say copy this files to your folder an override existing files. This makes trouble if you mix up several custom scripts. That's the reason why I would like to see the BaseAddon-OnChop function virtual in the release code of RunUO. As you agree it's not a big thing. You make it on your own, but it just one word, so why don't put it into the svn?

Hope you understand why i created this topic
Maybe it's a crappy idea. So far you can delete this thread. Whatever.

[Kenko]

Originally Posted by Malaperth

Which is exactly why I answered with this:



What you posted is not part of any code in any release. And, since BaseAddon is not a core script, it is more than simple to make it virtual by yourself.

Originally Posted by BaseAddon.cs Ln 53

public void OnChop( Mobile from )

That is the distro code, it isn't an overrode method in BaseAddon.cs.