Region.getPlayerCount()

[syznow]

If possible, could there be a change to the Region.GetPlayerCount() method so that it will only count players, not staff. It is a problem that when a staff member goes to the gauntlet, he will often trigger an increased spawn count. This is quite annoying for players, but it also effectively notifies the players that a staff member is watching them.

If there is ever a need to count staff and player together in a regions, could this method take a boolean or could a second method be added so you could count both with/without staff.

Since core modifications are discouraged for support reasons, it would be very handy for the RUNUO team fix this in the region code.

[Jeff]

Just make a RegionUtility class, and it it write this method yourself. It'd be pretty simple.

something like

public static int CountPlayersInRegion(Region region, bool countStaff)
{
     int count = 0;
     foreach( Mobile m in World.Mobiles.Values )
     {
           if( m != null && m.Player && m.Region == region )
           {
                if(((PlayerMobile)m).AccessLevel != AccessLevel.Player && !countStaff)
                      continue;
                 
                count++;
           }
     }

      return count;
}

I havent coded RunUO Stuff for over a year so some of this API could be wrong, but you should get the Idea.

[syznow]

Jeff, thanks for the post. I do realize it can be worked around, however depending on the player count and the slice interval I can see this iteration could be pretty inefficient compared to having this change made in the core Region.cs code.

I just wanted to enter it as a suggestion for to consideration, since hidden staff should probably not trigger spawn count increases whenever they enter the Gauntlet.

[TheOutkastDev]

Originally Posted by syznow

Jeff, thanks for the post. I do realize it can be worked around, however depending on the player count and the slice interval I can see this iteration could be pretty inefficient compared to having this change made in the core Region.cs code.

Just call GetMobiles and iterate over that list instead of using World.Mobiles.Values if you're really concerned about efficiency.