Character list sort

[pinco]

when someone delete a character in the list remain a "hole", with this modification we solve the problem. Let's start the editing from Packet.cs in the core files.

after line 2922, exactly after this:

 for ( int i = 0; i < a.Length; ++i ) 
{ 
if ( a != null ) 
highSlot = i; 
}

and after line 2891, exactly after this:

 m_Stream.Write( (byte) a.Count );

add this code block:

 // Sort for update list by Keldron Isenhart 
for ( int i = 0; i < a.Length; ++i ) 
{ 
for ( int j = i; j < a.Length; ++j ) 
{ 
if (a==null) 
{ 
a=a[j]; 
a[j]=null; 
} 
} 
} 
//end sort 

at last, compile the core and try, the problem is solved

[psz]

Hehehe. OSI still has the "hole" problem as well.


You should send this fix in to them ^_^


(j/k, of course)

[pinco]

I like the osi style, but replicate the bug is not good

[Noxih]

I got a quetion on this, Does this problem slow down the server?

[Alis]

no it doesnt slow down..

[noobie]

are you sure that code is correct

i think this is what you meant:

for ( int i = 0; i < a.Length; ++i ) 
{ 
  if (a[i] == null)
  {
     for ( int j = i+1; j < a.Length; ++j ) 
    { 
       if (a[j] != null)
       {
          for(int k=i; j<a.Length; k++,j++)
         {
           a[k]=a[j]; 
           a[j]=null; 
          }
          break;
       }
    } 
  } 
}