RC1's revision number (SVN)

[GhostRiderGrey]

Could someone possibly tell me what the first SVN revision number was after RC1 was released (or what SVN number RC1 was)?

Thanks!
-GhostRiderGrey

[GhostRiderGrey]

or do the SVN numbers start after the release of RC1? I'm looking for a fix for the obeycap problem in RC1

there is a bug in RC1 that obeycap = false does not work

so jewelry or other bonuses (incluing GM's setting skill higher) wil not work above the caps

and would like to know how far forward I need to come in the svns to fix this (I read newer than svn 66 but would like to verify). I do not want to go too far, as the shard is trying to maintain compatibility with client versions 5.0.6.c (so no RC2 or later)

Thanks,
-GhostRiderGrey

[Alrick]

Get the sources for RC1 and check the Skills.cs, it should contain this (or similar) method for checking the caps (and some other stuff as well):

		[CommandProperty( AccessLevel.Counselor )]
		public double NonRacialValue
		{
			get
			{
				double baseValue = Base;
				double inv = 100.0 - baseValue;

				if( inv < 0.0 ) inv = 0.0;

				inv /= 100.0;

				double statsOffset = ((m_UseStatMods ? m_Owner.Owner.Str : m_Owner.Owner.RawStr) * m_Info.StrScale) + ((m_UseStatMods ? m_Owner.Owner.Dex : m_Owner.Owner.RawDex) * m_Info.DexScale) + ((m_UseStatMods ? m_Owner.Owner.Int : m_Owner.Owner.RawInt) * m_Info.IntScale);
				double statTotal = m_Info.StatTotal * inv;

				statsOffset *= inv;

				if( statsOffset > statTotal )
					statsOffset = statTotal;

				double value = baseValue + statsOffset;

				m_Owner.Owner.ValidateSkillMods();

				List<SkillMod> mods = m_Owner.Owner.SkillMods;

				double bonusObey = 0.0, bonusNotObey = 0.0;

				for( int i = 0; i < mods.Count; ++i )
				{
					SkillMod mod = mods[i];

					if( mod.Skill == (SkillName)m_Info.SkillID )
					{
						if( mod.Relative )
						{
							if( mod.ObeyCap )
								bonusObey += mod.Value;
							else
								bonusNotObey += mod.Value;
						}
						else
						{
							bonusObey = 0.0;
							bonusNotObey = 0.0;
							value = mod.Value;
						}
					}
				}

				value += bonusNotObey;

				if( value < Cap )
				{
					value += bonusObey;

					if( value > Cap )
						value = Cap;
				}

				return value;
			}
		}

This is taken from SVN 295
If the method in your Skills.cs is different, use the one above and try to recompile the core with hopes that it wont break anything else

[GhostRiderGrey]

Thanks Alrick, unfortunately the code you listed for skills.cs is the same as what I used to compile from.

I'm still looking for a fix for the obeycap problem in RC1. Also trying to verify what SVN number RC1 was. Any further help appreciated.

Thanks
-GhostRiderGrey

[Radwen]

Try around 187?