Work-around to make RunUO accept commands from the GM: prompt

[Serp]

I don't want to call this "fix" as the GM: prompt might show up to be something else than a thing for us to enter commands with.

Core
Network/PacketHandlers.cs
Add the line in red to the MessageType enum:

public enum MessageType
{
	Regular = 0x00,
	System = 0x01,
	Emote = 0x02,
	Label = 0x06,
	Focus = 0x07,
	Whisper = 0x08,
	Yell = 0x09,
	Spell = 0x0A,
	Encoded = 0xC0,
	GM = 0x0F,
}

Scripts
PlayerMobile.cs

Add the lines in red to the PlayerMobile class:

public class PlayerMobile : Mobile
{
	public override void DoSpeech( string text, int[] keywords, MessageType type, int hue )
	{
		if ( type == MessageType.GM ) // If the message is of type GM
			text = String.Format( "{0}{1}", Commands.CommandPrefix, text ); // then add the prefix to it
		base.DoSpeech( text, keywords, type, hue ); // Process the same way as always
	}

[Rothhear]

Remodevd.......................................... ......

[Greystar]

Originally Posted by Rothhear

ok i cant find PacketHandlers.cs i found it inRunUO 1.0\Scripts\Engines\RemoteAdmin but it dont look like tat help ?

Nope, this is a CORE mod

[Greystar]

Originally Posted by Jakob

I don't want to call this "fix" as the GM: prompt might show up to be something else than a thing for us to enter commands with.

Core
Network/PacketHandlers.cs
Add the line in red to the MessageType enum:

public enum MessageType
{
	Regular = 0x00,
	System = 0x01,
	Emote = 0x02,
	Label = 0x06,
	Focus = 0x07,
	Whisper = 0x08,
	Yell = 0x09,
	Spell = 0x0A,
	Encoded = 0xC0,
	GM = 0x0F,
}

Scripts
PlayerMobile.cs

Add the lines in red to the PlayerMobile class:

public class PlayerMobile : Mobile
{
	public override void DoSpeech( string text, int[] keywords, MessageType type, int hue )
	{
		if ( type == MessageType.GM ) // If the message is of type GM
			text = String.Format( "{0}{1}", Commands.CommandPrefix, text ); // then add the prefix to it
		base.DoSpeech( text, keywords, type, hue ); // Process the same way as always
	}

BTW thanks

[Rothhear]

Removed......................................

[Tannis]

If you're not completely sure on what you're doing, don't modify your core. You could really mess something up if it goes bad. Also, Run UO doesn't support modified cores, so if you did mess something up, you wouldn't get help putting it right again.

[Phantom]

I would say this is the only modification, if you make any to the core, that you should do.

This is the only one, I would still help after finding out about.

[ASayre]

Originally Posted by Phantom

I would say this is the only modification, if you make any to the core, that you should do.

This is the only one, I would still help after finding out about.

You technically don't even need to mod the core, if you jsut want a quick patcherup fix to let it use [

(different way than above ofcourse)

[Phantom]

Originally Posted by ASayre8

You technically don't even need to mod the core, if you jsut want a quick patcherup fix to let it use [

(different way than above ofcourse)

I cannot think of another way, since the argument is a MessageType, would be better if it was type :-)

[soldierfortune]

Unless I'm missing something here I have no idea why someone would want to modify the core for this. All you have to do is go into Handlers.cs in the Commands directory and change this line:

Server.Commands.CommandPrefix = "[";

All you have to do is change the default "[" to whatever u want the new comand to be. I just changed it to "{" and all is working just fine.

Dan

[Serp]

Originally Posted by soldierfortune

Unless I'm missing something here I have no idea why someone would want to modify the core for this. All you have to do is go into Handlers.cs in the Commands directory and change this line:

Server.Commands.CommandPrefix = "[";

All you have to do is change the default "[" to whatever u want the new comand to be. I just changed it to "{" and all is working just fine.

Dan

A lot of people have been asking about this and I'm posting a solution. If you don't like it, don't use it. I believe in giving people options and letting them decide what suits them best.

[Zippy]

Here is a code snippet like the one above that does not require you to modify the core:

Scripts
PlayerMobile.cs

Add the lines in red to the PlayerMobile class:

public class PlayerMobile : Mobile
{
	public override void DoSpeech( string text, int[] keywords, MessageType type, int hue )
	{
		if ( (int)type == 0x0F ) // If the message is of type GM
			text = String.Format( "{0}{1}", Commands.CommandPrefix, text ); // then add the prefix to it
		base.DoSpeech( text, keywords, type, hue ); // Process the same way as always
	}

[Serp]

Originally Posted by Zippy

Here is a code snippet like the one above that does not require you to modify the core:

Scripts
PlayerMobile.cs

Add the lines in red to the PlayerMobile class:

public class PlayerMobile : Mobile
{
	public override void DoSpeech( string text, int[] keywords, MessageType type, int hue )
	{
		if ( (int)type == 0x0F ) // If the message is of type GM
			text = String.Format( "{0}{1}", Commands.CommandPrefix, text ); // then add the prefix to it
		base.DoSpeech( text, keywords, type, hue ); // Process the same way as always
	}

That's the one I posted first but I removed it as there is code in the core preventing it from working:

if ( !Enum.IsDefined( typeof( MessageType ), type ) )
	type = MessageType.Regular;

[Ravatar]

That code has nothing to do with what Zippy does above, his clip converts a GM messagetype to a CommandPrefix at the beginning of the line of text, for Commands.Handle to work with.

[Serp]

Originally Posted by Ravatar

That code has nothing to do with what Zippy does above, his clip converts a GM messagetype to a CommandPrefix at the beginning of the line of text, for Commands.Handle to work with.

Zippy wrote:

if ( (int)type == 0x0F ) // If the message is of type GM

The variable type can never be 0x0F. If the client sends a message with the type 0x0F (this is done when you use the GM: prompt) this code

if ( !Enum.IsDefined( typeof( MessageType ), type ) )
	type = MessageType.Regular;

detects that there is no value in the MessageType enum that is equal to 0x0F, so it sets the type to MessageType.Regular;

Thus, when it arrives to PlayerMobile.DoSpeech the type is 0x00 (RegularSpeech) instead of 0x0F. You need to add the line I wrote into the core to prevent the core from changing type from 0x0F to 0x00.

[Gandy897]

Originally Posted by Jakob

Zippy wrote:

if ( (int)type == 0x0F ) // If the message is of type GM

The variable type can never be 0x0F. If the client sends a message with the type 0x0F (this is done when you use the GM: prompt) this code

if ( !Enum.IsDefined( typeof( MessageType ), type ) )
	type = MessageType.Regular;

detects that there is no value in the MessageType enum that is equal to 0x0F, so it sets the type to MessageType.Regular;

Thus, when it arrives to PlayerMobile.DoSpeech the type is 0x00 (RegularSpeech) instead of 0x0F. You need to add the line I wrote into the core to prevent the core from changing type from 0x0F to 0x00.

Umm dude.. Zippy is a core developer .. why not just say thanks zippy for the assist and let it be.. sheesh

[soldierfortune]

Originally Posted by Jakob

A lot of people have been asking about this and I'm posting a solution. If you don't like it, don't use it. I believe in giving people options and letting them decide what suits them best.

I never said I didnt like your idea and all I was doing was offering an easier way to do this. Your way requires CORE modifications which most people cannot do and also CORE mods are not supported by RunUO.

Dan

[Serp]

Originally Posted by soldierfortune

Your way requires CORE modifications which most people cannot do and also CORE mods are not supported by RunUO.

I see what you're saying, but I personally like to use the [ prefix and after all, this thread is posted under Core Modifications.

[Ravatar]

PlayerMobile OnSpeech overrides Mobile OnSpeech, therefore it'll hit Zippy's code first, then travel down to

base.DoSpeech( text, keywords, type, hue ); // Process the same way as always

[Serp]

Originally Posted by Ravatar

PlayerMobile OnSpeech overrides Mobile OnSpeech, therefore it'll hit Zippy's code first, then travel down to

base.DoSpeech( text, keywords, type, hue ); // Process the same way as always

type will still be changed to 0x00 (RegularMessage) before it even gets to the DoSpeech method.

This is how it looks in the core:

if ( !Enum.IsDefined( typeof( MessageType ), type ) )
	type = MessageType.Regular;

from.Language = lang;
from.DoSpeech( text, keywords, type, Utility.ClipDyedHue( hue ) );

[Ravatar]

Ahh I thought the script you posted at first was Mobile.cs

[XxSP1DERxX]

Jakob is right, and Zippy was most likley not paying attention to the code he wrote (since he wanted to shut all of you up).

If you look at the core, the message type handling is done before the DoSpeech is called, therefore Zippy's code would not work.

[soldierfortune]

Originally Posted by Jakob

I see what you're saying, but I personally like to use the [ prefix and after all, this thread is posted under Core Modifications.

LOL now I feel Dumb, I just noticed it was under core mods
Dan

Some of my players went to OSI and got the latest patch, then couldn't use the [chat command (Thank you Knives, we love your system)... and staff that patched wasn't able to pull up either, because the GM thing came up, too.

One of the players came up with an immediate work around. Type a space before you hit the [ and it'll recognize without issue.

We haven't had to modify anything more than our typing.

[Greystar]

Originally Posted by Vilanne

Some of my players went to OSI and got the latest patch, then couldn't use the [chat command (Thank you Knives, we love your system)... and staff that patched wasn't able to pull up either, because the GM thing came up, too.

One of the players came up with an immediate work around. Type a space before you hit the [ and it'll recognize without issue.

We haven't had to modify anything more than our typing.

yah but this was posted cause some people didnt like havint to have to add a " " ie Space before the [. Personally I did this mod, but for the most part I dont ask for much help. If I cant fix it right away Ill come up with it eventually, but I also use more then one prefix so fixing it didnt really matter to me. I just dont like when things get broke when its not my fault