Loop not crafting enough - RunUO

Kelloggs Goatios · 02-09-2007, 07:28 PM

Quote:

Assistant.Macros.ForAction|14
Assistant.Macros.IfAction|4|0|you have worn out your tool
Assistant.Macros.DoubleClickTypeAction|3997|True
Assistant.Macros.WaitForGumpAction|949095101|False |300
Assistant.Macros.GumpResponseAction|21|0|0
Assistant.Macros.PauseAction|00:00:01
Assistant.Macros.ElseAction
Assistant.Macros.PauseAction|00:00:00.5000000
Assistant.Macros.GumpResponseAction|21|0|0
Assistant.Macros.PauseAction|00:00:01
Assistant.Macros.EndIfAction
Assistant.Macros.EndForAction

Here is a for loop I have that should
1. Craft 14 items
2. Target a new sewingkit should I wear out my tool.

I am running a macro with this loop in it, and it is not producing 14 items, whether or not I wear my kit out or not.

Is there a solution for this?

Malaperth · 02-09-2007, 07:30 PM

What exactly is it doing? In the past with crafting macros I found that I could set it for x number and not get that number due to failures etc.

Kelloggs Goatios · 02-09-2007, 07:32 PM

Well its a tailoring macro for crafting cloth items; I have 120 tailoring so this should not be a failure type of scenario.

I have plenty of cloth. I have adequite space in my backpack as far as stones or weight goes. I have the sewing supplies.

The loop just is not putting out the right amount of items

Malaperth · 02-09-2007, 07:35 PM

What amount is it adding?

Kelloggs Goatios · 02-09-2007, 07:45 PM

Quote:

Originally Posted by Malaperth

What amount is it adding?

Don't exactly know what you mean by this so let me break it down.

Before the loop I have a setup to determine what type of item to craft.

Then it crafts this item (1 of them) and then enters the

For 1 to 14 Loop

It should add 14 items to my backpack.

But I'm coming up with arbitrary numbers of items, like 10, 11, 13, etc. But not 14.

Malaperth · 02-09-2007, 07:47 PM

If it's a random number, I don't know why, but I always thought that there was a chance of failure at any skill level (even if the menu said 100% etc).

You get no messages about success or failure at all?

Kelloggs Goatios · 02-09-2007, 07:57 PM

Quote:

Originally Posted by Malaperth

If it's a random number, I don't know why, but I always thought that there was a chance of failure at any skill level (even if the menu said 100% etc).

You get no messages about success or failure at all?

I know it's not failure. It may just be that I don't have a long enough wait in between crafts. I'm going to play around with the pauses and see what I get.

Edison-hybrid · 02-09-2007, 10:56 PM

The only thing that jumps out at me is the wait lines after crafting

Assistant.Macros.PauseAction|00:00:01

Bit of a long shot, but you might want to try making that pause 2 or 3 seconds, it could be looping a bit too quick and the gump may not be up when it passes through the loop on the next iteration.

Lord_Greywolf · 02-10-2007, 01:49 AM

i have found that 2.2 second pauses work a lot better

2.0 can - but sometimes barely miss

and remember during system saves - it will be les also

Killamus · 02-10-2007, 03:17 AM

Throw a wait for gump in there.

Kelloggs Goatios · 02-10-2007, 03:40 AM

Thanks for the replies everyone. I think I may have this problem all but licked.

I changed the pauses between the loops to 1.75, which worked fine on my desktop. I haven't tested on my laptop, but I imagine that I may need to change it to 2 - 2.2 when I'm working with my laptop.

Thanks

**Zippy** · 02-10-2007, 12:44 PM

The entire point of "Wait for Gump" is that it will wait the minimum amount of time possible and still work every time.

Why would you not use "Wait for Gump" here?

Lord_Greywolf · 02-10-2007, 01:44 PM

because the wait for gump does not always work and it goes into the time out wait and then restarts the macro then

the wait for target and wait for gump have always been buggy that way and just "hang" after a while

mordero · 02-10-2007, 01:48 PM

if thats the case you probably need to increase your Object Delay a bit

Lord_Greywolf · 02-10-2007, 01:52 PM

well the delay is up to 10 seconds (or 12 - forget) - does not matter - you can see the gump come back up and razor just sits there doing nothing sometimes --- and then after a couple of sec - it does the time out deal
has done this as long as i can remember using razor - same with wait for target - folowed by absolute target, or target by types, etc - many times just hangs there

so i stoped using the "wait for"s and used direct pauses

02-09-2007, 07:30 PM	#2 (permalink)
Malaperth Master of the Internet Join Date: Oct 2005 Age: 45 Posts: 6,283	What exactly is it doing? In the past with crafting macros I found that I could set it for x number and not get that number due to failures etc. __________________ Why is it that I'm never as smart as I thought I was yesterday? My vast knowledge is only surpassed by my infinite ignorance. <TheOutkastDev> i might have to hire an assassin to killl mal so that i can jump in front of the bullet and piss on him

02-09-2007, 07:32 PM	#3 (permalink)
Kelloggs Goatios Forum Novice Join Date: Dec 2006 Location: 20 ping Posts: 838	Well its a tailoring macro for crafting cloth items; I have 120 tailoring so this should not be a failure type of scenario. I have plenty of cloth. I have adequite space in my backpack as far as stones or weight goes. I have the sewing supplies. The loop just is not putting out the right amount of items __________________ teh goat - die irl - equilibrium - demise wow yourmom flyff

02-09-2007, 07:35 PM	#4 (permalink)
Malaperth Master of the Internet Join Date: Oct 2005 Age: 45 Posts: 6,283	What amount is it adding? __________________ Why is it that I'm never as smart as I thought I was yesterday? My vast knowledge is only surpassed by my infinite ignorance. <TheOutkastDev> i might have to hire an assassin to killl mal so that i can jump in front of the bullet and piss on him

02-09-2007, 07:47 PM	#6 (permalink)
Malaperth Master of the Internet Join Date: Oct 2005 Age: 45 Posts: 6,283	If it's a random number, I don't know why, but I always thought that there was a chance of failure at any skill level (even if the menu said 100% etc). You get no messages about success or failure at all? __________________ Why is it that I'm never as smart as I thought I was yesterday? My vast knowledge is only surpassed by my infinite ignorance. <TheOutkastDev> i might have to hire an assassin to killl mal so that i can jump in front of the bullet and piss on him

02-10-2007, 01:49 AM	#9 (permalink)
Lord_Greywolf Forum Master Join Date: Dec 2005 Posts: 6,626	i have found that 2.2 second pauses work a lot better 2.0 can - but sometimes barely miss and remember during system saves - it will be les also __________________ http://www.AoAUO.com :) ..... Come for the Customs, Play for the Fun. Return to see your new Friends ..... :)

02-09-2007, 10:56 PM	#8 (permalink)
Edison-hybrid Forum Newbie Join Date: Dec 2005 Posts: 3	The only thing that jumps out at me is the wait lines after crafting Assistant.Macros.PauseAction\|00:00:01 Bit of a long shot, but you might want to try making that pause 2 or 3 seconds, it could be looping a bit too quick and the gump may not be up when it passes through the loop on the next iteration.

02-10-2007, 03:17 AM	#10 (permalink)
Killamus Forum Expert Join Date: Dec 2003 Location: Sitting in a chair fulfilling my life's goal Age: 22 Posts: 2,650	Throw a wait for gump in there. __________________ Procrastinators unite! Tomorrow. Saying that Java is nice because it works on all OS's is like saying that anal sex is nice because it works on all genders.

02-10-2007, 03:40 AM	#11 (permalink)
Kelloggs Goatios Forum Novice Join Date: Dec 2006 Location: 20 ping Posts: 838	Thanks for the replies everyone. I think I may have this problem all but licked. I changed the pauses between the loops to 1.75, which worked fine on my desktop. I haven't tested on my laptop, but I imagine that I may need to change it to 2 - 2.2 when I'm working with my laptop. Thanks __________________ teh goat - die irl - equilibrium - demise wow yourmom flyff

02-10-2007, 12:44 PM	#12 (permalink)
Zippy Administrator Join Date: Aug 2002 Location: Baltimore, MD Age: 25 Posts: 4,868	The entire point of "Wait for Gump" is that it will wait the minimum amount of time possible and still work every time. Why would you not use "Wait for Gump" here? __________________ Zippy, Razor Creator and RunUO Core Developer The RunUO Software Team "Intuition, like a flash of lightning, lasts only for a second. It generally comes when one is tormented by a difficult decipherment and when one reviews in his mind the fruitless experiments already tried. Suddenly the light breaks through and one finds after a few minutes what previous days of labor were unable to reveal." ~The Cryptonomicon

02-10-2007, 01:44 PM	#13 (permalink)
Lord_Greywolf Forum Master Join Date: Dec 2005 Posts: 6,626	because the wait for gump does not always work and it goes into the time out wait and then restarts the macro then the wait for target and wait for gump have always been buggy that way and just "hang" after a while __________________ http://www.AoAUO.com :) ..... Come for the Customs, Play for the Fun. Return to see your new Friends ..... :)

02-10-2007, 01:48 PM	#14 (permalink)
mordero Forum Expert Join Date: Nov 2003 Location: Illinois, USA Age: 22 Posts: 2,911	if thats the case you probably need to increase your Object Delay a bit __________________ Useful links (Use them or die in a fire!!!): Ultimate Little Guide, C# Tutorials & Docs, RunUO Basic Scripts, Run UO How to..., Configure server for connections, Scripting for Dummies, Common Problem Solutions, FAQ Forum, RunUO Wiki, Basic Generics, Xml Tutorial

02-10-2007, 01:52 PM	#15 (permalink)
Lord_Greywolf Forum Master Join Date: Dec 2005 Posts: 6,626	well the delay is up to 10 seconds (or 12 - forget) - does not matter - you can see the gump come back up and razor just sits there doing nothing sometimes --- and then after a couple of sec - it does the time out deal has done this as long as i can remember using razor - same with wait for target - folowed by absolute target, or target by types, etc - many times just hangs there so i stoped using the "wait for"s and used direct pauses __________________ http://www.AoAUO.com :) ..... Come for the Customs, Play for the Fun. Return to see your new Friends ..... :)

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode