Concept Item

[Greystar]

The Larger file is the newer one. It eliminates the seperate colors as seperate items and condences them down into one item.


This is similair to an Item I created in my AD&D game. It was originally a gift from an evil god, given to those who are his chosen. I since expanded on it when other gods followers where being slaughtered because of this item. The item grants certain powers after it "Bonds" with a player. Only way to remove the item is to die. At which point if someone else picks up the item it will start bonding with them.

Installation instructions are at the bottom of the script in comments. If you dont want to add that part of the script then remove every reference to it in the scripts...

Edit: Extra Installation Instructions that update what I put at the end if the script

If anyone could tell me how to modify this script to not use timers I'd be more then happy to adjust for that.

     To make this script work you need to add    
     the following to your PlayerMobile.cs         

		private bool m_Attackable;						private bool m_Red;					

		[CommandProperty( AccessLevel.Administrator )]
		public bool IsKiller
		{
			get{ return m_Red; }
			set{ m_Red = value; }
		}

		[CommandProperty( AccessLevel.Administrator )]
		public bool IsAttackable
		{
			get{ return m_Attackable; }
			set{ m_Attackable = value; }
		}	

Add the above near all the other properties

ie somewhere around

		[CommandProperty( AccessLevel.GameMaster )]
		public int Profession
		{
			get{ return m_Profession; }
			set{ m_Profession = value; }
		}

i put it right above that.....

							
This section of Notoriety.cs is what I changed to make this work


		public static int MobileNotoriety( Mobile source, Mobile target )
		{
			if ( Core.AOS && (target.Blessed || (target is BaseVendor && ((BaseVendor)target).IsInvulnerable) || target is PlayerVendor || target is TownCrier) )
				return Notoriety.Invulnerable;
/*
			if ( target.AccessLevel > AccessLevel.Player )
				return Notoriety.CanBeAttacked;
*/
			if ( target is PlayerMobile )
			{
				if ( ((PlayerMobile)target).IsAttackable )
					return Notoriety.CanBeAttacked;
				else if ( ((PlayerMobile)target).IsKiller )
					return Notoriety.Murderer;
			}

			if ( source.Player && !target.Player && source is PlayerMobile && target is BaseCreature )
			{
				BaseCreature bc = (BaseCreature)target;

				if ( !bc.Summoned && !bc.Controled && ((PlayerMobile)source).EnemyOfOneType == target.GetType() )
					return Notoriety.Enemy;
			}

			if ( target.Kills >= 5 || (target.Body.IsMonster && IsSummoned( target as BaseCreature ) && !(target is BaseFamiliar) && !(target is Golem)) || (target is BaseCreature && (((BaseCreature)target).AlwaysMurderer || ((BaseCreature)target).IsAnimatedDead)) )
				return Notoriety.Murderer;

			if ( target.Criminal )
				return Notoriety.Criminal;

			Guild sourceGuild = GetGuildFor( source.Guild as Guild, source );
			Guild targetGuild = GetGuildFor( target.Guild as Guild, target );

			if ( sourceGuild != null && targetGuild != null )
			{
				if ( sourceGuild == targetGuild || sourceGuild.IsAlly( targetGuild ) )
					return Notoriety.Ally;
				else if ( sourceGuild.IsEnemy( targetGuild ) )
					return Notoriety.Enemy;
			}

			if ( SkillHandlers.Stealing.ClassicMode && target is PlayerMobile && ((PlayerMobile)target).PermaFlags.Contains( source ) )
				return Notoriety.CanBeAttacked;

			if ( target is BaseCreature && ((BaseCreature)target).AlwaysAttackable )
				return Notoriety.CanBeAttacked;

			if ( CheckHouseFlag( source, target, target.Location, target.Map ) )
				return Notoriety.CanBeAttacked;

			if ( !(target is BaseCreature && ((BaseCreature)target).InitialInnocent) )
			{
				if ( !target.Body.IsHuman && !target.Body.IsGhost && !IsPet( target as BaseCreature ) )
					return Notoriety.CanBeAttacked;
			}

			if ( CheckAggressor( source.Aggressors, target ) )
				return Notoriety.CanBeAttacked;

			if ( CheckAggressed( source.Aggressed, target ) )
				return Notoriety.CanBeAttacked;

			if ( target is BaseCreature )
			{
				BaseCreature bc = (BaseCreature)target;

				if ( bc.Controled && bc.ControlOrder == OrderType.Guard && bc.ControlTarget == source )
					return Notoriety.CanBeAttacked;
			}

			return Notoriety.Innocent;
		}

the IsKiller hasnt been tested, but the other parts do indeed work. At this time it doesnt check to see if you are already wearing one of these before trying to equip it so you can wear multiple of these. I do intend on changing that. If someone decides to do it before I post an Update please feel free to post it.

PS: This should work as is in Beta36 as well... but since im not running Beta36 anymore let me know whoever may use this in B36 if it works or not.

PPS: thanks to the original 41 people for the download. Instructions are now updated in the script and TimerPriority adjusted.

[SingularityZero]

Sorry, but I'm not really sure as to 'where', I have to add the line of code.
Could you give me an example?
Maybe two lines of code it has to be inserted inbetween?
Tried adding the code to the end of the two scripts and it didn't seem to work. *S*

Nice idea though, I sincerly hope I can make it work.

[KillerBeeZ]

You asked me if I would use this script for my level system so after going over it, I must say, no, I would not add this script as it is.

I have a few issues with it, some small, some large

1) here in BaseSoulGem

is this meant to have 2 different Bonus Hits attributes?

I would be taking this out and adding something else as on my shard, bonus hits doesnt work.

Attributes.BonusHits = 30;
Attributes.RegenHits = 10;
Attributes.BonusHits = 20;

2) Timer priority

Priority = TimerPriority.OneSecond;

is that not a bit too much for something that takes 7 days? I cant be having so many timers in my worls ticking each second, with over 500 accounts, this can pose a problem.

I personally don't like to use timers unless there is no other way, and then with a moderate to low priority to reduce cpu load.

3) Colors

whats with the colored gems? how do these come into play? I looked around but couldnt find how players get them, am I to make the distinction and give out the colored gems? or does it turn a random color from the base soul gem?, or how does that work?

I would need to do some editing before using this script. I like the idea for the cursed item auto equip and might add a few things to it (like setting the cursed item to become non movable on equip)

4) this is a small issue but valid nonetheless

in your script where you post what to add to the playermobile, you surround the entire script with comment tags, not only is this unneeded, but its counter productive, I have to delete all those in order to copy it to add to the PM
a simple /* and */ would do just fine, and maybe add a // to a line over it to explain what it does.

Ok, issues aside...

It seems to be a well thought out script and will look forward to trying it out further. I'm not sure how I'll be able to use this for my level system, but I'll look into it.

[Greystar]

Originally Posted by KillerBeeZ

You asked me if I would use this script for my level system so after going over it, I must say, no, I would not add this script as it is.

I have a few issues with it, some small, some large

1) here in BaseSoulGem

is this meant to have 2 different Bonus Hits attributes?

I would be taking this out and adding something else as on my shard, bonus hits doesnt work.

Attributes.BonusHits = 30;
Attributes.RegenHits = 10;
Attributes.BonusHits = 20;

2) Timer priority

Priority = TimerPriority.OneSecond;

is that not a bit too much for something that takes 7 days? I cant be having so many timers in my worls ticking each second, with over 500 accounts, this can pose a problem.

I personally don't like to use timers unless there is no other way, and then with a moderate to low priority to reduce cpu load.

3) Colors

whats with the colored gems? how do these come into play? I looked around but couldnt find how players get them, am I to make the distinction and give out the colored gems? or does it turn a random color from the base soul gem?, or how does that work?

I would need to do some editing before using this script. I like the idea for the cursed item auto equip and might add a few things to it (like setting the cursed item to become non movable on equip)

4) this is a small issue but valid nonetheless

in your script where you post what to add to the playermobile, you surround the entire script with comment tags, not only is this unneeded, but its counter productive, I have to delete all those in order to copy it to add to the PM
a simple /* and */ would do just fine, and maybe add a // to a line over it to explain what it does.

Ok, issues aside...

It seems to be a well thought out script and will look forward to trying it out further. I'm not sure how I'll be able to use this for my level system, but I'll look into it.

When I did some editing to post it to the boards it got some added stuff left in it. Was not intentional... the second bonushits was supposed to be bonus stam. the /* */ comments was back from my Mud days when all extra comments I'd use where done that way to make it look nice (in my eyes). The multi-colors for the gems is they have different resistances. The black and the white gems are directly apposing to each other... or are supposed to be. I intend on adding in an ability later that makes it so that when the apposing gems are in range of each other they will tell their master. Like I said its mostly a concept idea... I know it needs work and I thought it was something other scriptors/admins could use to make an otherwise lets say "Ordinary" headless into an extraordinary one because some supernatural creature decided they needed some improvements. I intend on adding them to the chaos and order gaurds for sure. Not every gaurd mind you but some of them (will be random). as far as the colors go... I wasnt sure what I was doing with them. I knew that some people where asking how to add skill and stat bonuses to items so thats part of the reason why I added this... as far as the timer goes it was my test timer... I changed it back to 7days but forgot to adjust the Priority... that and im still learning about how to use the priorty... as I stated any comments suggestions fixxes are appreciated. Im always looking for help on improvements. I'm going to be releasing another item that I made too... It needs work but works at this point... doesnt seem to crash the shard either.

[KillerBeeZ]

Originally Posted by Greystar

When I did some editing to post it to the boards it got some added stuff left in it. Was not intentional... the second bonushits was supposed to be bonus stam. the /* */ comments was back from my Mud days when all extra comments I'd use where done that way to make it look nice (in my eyes). The multi-colors for the gems is they have different resistances. The black and the white gems are directly apposing to each other... or are supposed to be. I intend on adding in an ability later that makes it so that when the apposing gems are in range of each other they will tell their master. Like I said its mostly a concept idea... I know it needs work and I thought it was something other scriptors/admins could use to make an otherwise lets say "Ordinary" headless into an extraordinary one because some supernatural creature decided they needed some improvements. I intend on adding them to the chaos and order gaurds for sure. Not every gaurd mind you but some of them (will be random). as far as the colors go... I wasnt sure what I was doing with them. I knew that some people where asking how to add skill and stat bonuses to items so thats part of the reason why I added this... as far as the timer goes it was my test timer... I changed it back to 7days but forgot to adjust the Priority... that and im still learning about how to use the priorty... as I stated any comments suggestions fixxes are appreciated. Im always looking for help on improvements. I'm going to be releasing another item that I made too... It needs work but works at this point... doesnt seem to crash the shard either.

oh believe me I'm all for making the script look good, and good for you for doing so, its just that function needs to go before form.

the timer priority and extra bonus hits is an easy fix

so, these are not for players but for monsters?

I'll download it and try it out on my test server for a bit and see what I can come up with.

[Greystar]

Originally Posted by KillerBeeZ

oh believe me I'm all for making the script look good, and good for you for doing so, its just that function needs to go before form.

the timer priority and extra bonus hits is an easy fix

so, these are not for players but for monsters?

I'll download it and try it out on my test server for a bit and see what I can come up with.

They are for players in the long run... thats how I intend on destributing them since I dont use a reward system.... and most players are QUICK to "Wear a new Item" I might just leave my timer so that if a player realizes what they have they can drop it, but make it have 30 seconds instead of the 7days... Like I said its something that would work as is, people would just have to figure out how to destribute it. The newer version should make it so that IsKiller works and makes you red. I dont know if it will make gaurds attack though since for the moment I have gaurded regions turned off.

Is there any timer priority greater than OneMinute? Cause if there is I cant seem to find it... Otherwise if you could help me out with makeing it use another Non-Timer Method I'd be interested... Since timers have been annoying me anyway.

[Greystar]

Some Ideas I've been throwing around for this script. Having the item check the players Karma levels if positive become white if negative become black. but like I said its all Ideas im throwing around. I dont think there should be any problem making morphing items. But I really would like to know how to not use the timer for the "bonding" period. Since I might make this a morphing item that would have its own timer.

[Tru]

actually I think I'll be able to use these as Infinity Gems (modified a bit of course)....
Thanks

[KillerBeeZ]

Originally Posted by Greystar

Some Ideas I've been throwing around for this script. Having the item check the players Karma levels if positive become white if negative become black. but like I said its all Ideas im throwing around. I dont think there should be any problem making morphing items. But I really would like to know how to not use the timer for the "bonding" period. Since I might make this a morphing item that would have its own timer.

maybe an instant bond and get rid of the timer all together?

[Greystar]

The new version of my script does things a little differently. Next Version Might contain a way to destribute these throughout the world as well. May have some redundant code.

I commented out the Resurrect part of the code since it doesnt seem to work yet.
Besides that the new version seems to work fine.

[Greystar]

Originally Posted by Greystar

The new version of my script does things a little differently. Next Version Might contain a way to destribute these throughout the world as well. May have some redundant code.

I commented out the Resurrect part of the code since it doesnt seem to work yet.
Besides that the new version seems to work fine.

I don't know if anyone has tested this on their shard yet, but something I noticed recently.... If you die and requip this (either through the timer or doubleclicking it) it sometimes disappears... to be never seen from again. Not sure why this is happening or whats causing it, but I will attempt at fixing it.

[KillerBeeZ]

Originally Posted by Greystar

I don't know if anyone has tested this on their shard yet, but something I noticed recently.... If you die and requip this (either through the timer or doubleclicking it) it sometimes disappears... to be never seen from again. Not sure why this is happening or whats causing it, but I will attempt at fixing it.

1) if there is no code telling it to delete then its likely still in the world, maybe in the internal map

2) Try to equip something in the same spot to see if its just invisible

3) let me know what you find

[Greystar]

Originally Posted by KillerBeeZ

1) if there is no code telling it to delete then its likely still in the world, maybe in the internal map

2) Try to equip something in the same spot to see if its just invisible

3) let me know what you find

I think I figured out what the problem is... It only happens when you try to re-equip the item when you are Invulnerable (ie after you die if you have the Anti-reskill timer installed). I tested it and the only time it would duplicate is when you where blessed... im going to see if the mods I made to it that just prevent you from wearing it at all while blessed... Im sure there is a better way to do this, but this should do the fix for me.

[Varkasal]

[quote=KillerBeeZ]
I would need to do some editing before using this script. I like the idea for the cursed item auto equip and might add a few things to it (like setting the cursed item to become non movable on equip)
QUOTE]

I definately like that idea for cursed items ..... As far as the question of destributing them is there a way to make them seem to be something else when seen then once handled thier true nature becomes apparent ... Like cursed items in AD&D ? Sorry havent looked at the script yet really but the cursed Item Idea got me thinking .... lol

[KillerBeeZ]

[quote=Varkasal]

Originally Posted by KillerBeeZ

I would need to do some editing before using this script. I like the idea for the cursed item auto equip and might add a few things to it (like setting the cursed item to become non movable on equip)
QUOTE]

I definately like that idea for cursed items ..... As far as the question of destributing them is there a way to make them seem to be something else when seen then once handled thier true nature becomes apparent ... Like cursed items in AD&D ? Sorry havent looked at the script yet really but the cursed Item Idea got me thinking .... lol

aye there is, there is a script in submissions for a transmutable item that does this, wouldn't be hard to merge the 2