part of a script

[dean968]

does anyone see something wrong with this?

[code:1]private class newTimer2 : Timer
{
private Mobile a;
public newTimer2( Mobile m ) : base( TimeSpan.FromSeconds( 5 ) )
{
a = m;
}

protected override void OnTick()
{
a.SendMessage( "Your score has reduced by one" );
}
}
}
}[/code:1]

[Crack177]

I might see a problem, but u can't trust me.
[code:1]
public newTimer2( Mobile m ) : base( TimeSpan.FromSeconds( 5 ) )[/code:1]

Here there is usually another time span

[Crack177]

That's probably wrong but I tried. Take a look at this part of a script like I was talking about.
[code:1]public IdleTimer( serventofakasha owner ) : base( TimeSpan.FromSeconds( 6.0 ), TimeSpan.FromSeconds( 6.5 ) )
[/code:1]

[dean968]

ok so whats the reason for the second time to set up a time frame? like from 6mins -6.5 mins

[Crack177]

It would be so it had a distance of time. Like I told you, you should not trust me i'm not the greatest at this.

[David]

I don't see anything wrong, what is it doing or not doing, or any compile errors?

The first (or only) TimeSpan will cause the Timer to fire after that amount of time. An optional second TimeSpan will cause the Timer to repeat at whatever interval the second TimeSpan states.

[roadmaster]

If there is something wrong with your script you need to post the entire script with the errors you are receiving, this will help us to help you.

your problem may be in how you are calling the timer, we dont know since you didnt post your script.


roadmaster

[dean968]

heres the crash

Error:
System.NullReferenceException: Object reference not set to an instance of an obj
ect.
at Server.Items.newTimer2.OnTick()
at Server.Timer.Slice()
at Server.Core.Main(String[] args)
Crash: Backing up...done
Crash: Generating report...done
Crash: Restarting...done
Warning:
System.Threading.ThreadAbortException: Thread was being aborted.
at System.Threading.Thread.Sleep(Int32 millisecondsTimeout)
at Server.TimerThread.TimerMain()

[dean968]

its a town war script and the crash happen when 2 diffrent town members went out hunting together and one got killed by a dragon they were both fighting together

[XxSP1DERxX]

[code:1]if (a != null && !a.Deleted)[/code:1]

add that check.

[dean968]

so like this?

[code:1]private class newTimer2 : Timer
{
private Mobile a;
public newTimer2( Mobile m ) : base( TimeSpan.FromSeconds( 5 ) )
{
a = m;
}

protected override void OnTick()
if (a != null && !a.Deleted)
{
a.SendMessage( "Your score has reduced by one" );
}
}
}
}[/code:1]


or
[code:1]
private class newTimer2 : Timer
{
private Mobile a;
public newTimer2( Mobile m ) : base( TimeSpan.FromSeconds( 5 ) )
{
if (a != null && !a.Deleted)
a = m;
}

protected override void OnTick()
{
a.SendMessage( "Your score has reduced by one" );
}
}
}
}
[/code:1][/code]

[David]

Like this
[code:1]private class newTimer2 : Timer
{
private Mobile a;
public newTimer2( Mobile m ) : base( TimeSpan.FromSeconds( 5 ) )
{
a = m;
}

protected override void OnTick()
{
if (a != null && !a.Deleted)
a.SendMessage( "Your score has reduced by one" );
}
}
}
}[/code:1]