Client crashes when opening spellbook (client ver. 6.0.9.2)

[vermillion2083]

Good afternoon everyone,

I've noticed a nasty little bug that causes any player on my server client to crash upon opening any spell book. I'm not entirally sure what is causing this, but I know it's a client issue as anyone patched to the highest client version suffers from this bug, but people using clients under 5.0.9.1 don't feel the effects. Anyone have any suggestions on this? Thank you all in advance for your assistance.

[Tassyon T]

Originally Posted by vermillion2083

Good afternoon everyone,

I've noticed a nasty little bug that causes any player on my server client to crash upon opening any spell book. I'm not entirally sure what is causing this, but I know it's a client issue as anyone patched to the highest client version suffers from this bug, but people using clients under 5.0.9.1 don't feel the effects. Anyone have any suggestions on this? Thank you all in advance for your assistance.

Hmm. Are mul files updated in a new client release? If some IDs in the files have been deleted, or something strange like that, maybe the spellbook gump is feeding them invalid ItemIDs, GumpIDs, etc? Also, a cliloc might have been moved around? Just thoughts on what it might be...

[Karmageddon]

I had the same problem on my server if anyone patched above 6.0.1.4 I think it was. Now are you using the AllSpells system? If so you did not update the Spellbook.cs with the new coding for the higher clients. I had the same problem and that is what fixed problem. If you want I could send you the Spellbook.cs I am using.

[FingersMcSteal]

This sounds like something that happened a while ago.

This was from a few years ago, same or almost sounds the same error happening...

Spellbook problems

Hope that points you in the right direction.

[Tassyon T]

Originally Posted by Tassyon T

Hmm. Are mul files updated in a new client release? If some IDs in the files have been deleted, or something strange like that, maybe the spellbook gump is feeding them invalid ItemIDs, GumpIDs, etc? Also, a cliloc might have been moved around? Just thoughts on what it might be...

You could record the gump IDs and itemIDs and clilocs fed to the clients by looking at the spellbook gump scripts and compare them to the mul IDs using InsideUO. For the clilocs you'd need a cliloc editor.

[vermillion2083]

Originally Posted by Karmageddon

I had the same problem on my server if anyone patched above 6.0.1.4 I think it was. Now are you using the AllSpells system? If so you did not update the Spellbook.cs with the new coding for the higher clients. I had the same problem and that is what fixed problem. If you want I could send you the Spellbook.cs I am using.

I am not running the AllSpells system but I do have 4 custom spell classes that I have created over the last few years, so I'm assuming it's the same problem resulting from my older spellbook.cs. I will go through the newest SVN version of spellbook.cs and try to find the cause of my problem. Thank you all for your advice, I will report back my findings.

p.s. Does anyone have the newest SVN version of SpellBook.cs that is unmodified? It would save me some time. Thank you greatly in advance for your assistance.

[HellRazor]

Here it is.

[vermillion2083]

Thanks a million HellRazor.

[vermillion2083]

Good morning everyone,

I was able to resolve my issue, and I thought I would share my findings with everyone just in case anyone else runs into this problem. The problem lied in the DisplayTo method in SpellBook.cs:

		public void DisplayTo( Mobile to )
		{
			// The client must know about the spellbook or it will crash!

			if ( Parent == null )
			{
				to.Send( this.WorldPacket );
			}
			else if ( Parent is Item )
			{
				if ( to.NetState == null )
					return;

				// What will happen if the client doesn't know about our parent?
				if ( to.NetState.IsPost6017 )
					to.Send( new ContainerContentUpdate6017( this ) );
				else
					to.Send( new ContainerContentUpdate( this ) );
			}
			else if ( Parent is Mobile )
			{
				// What will happen if the client doesn't know about our parent?
				to.Send( new EquipUpdate( this ) );
			}

			to.Send( new DisplaySpellbook( this ) );

			if ( to.NetState == null )
				return;

			if ( Core.AOS ) {
				if ( to.NetState.Version != null && to.NetState.Version >= Version_400a ) {
					to.Send( new NewSpellbookContent( this, ItemID, BookOffset + 1, m_Content ) );
				} else {
					to.Send( new SpellbookContent( m_Count, BookOffset + 1, m_Content, this ) );
				}
			}
			else {
				if ( to.NetState.IsPost6017 ) {
					to.Send( new SpellbookContent6017( m_Count, BookOffset + 1, m_Content, this ) );
				} else {
					to.Send( new SpellbookContent( m_Count, BookOffset + 1, m_Content, this ) );
				}
			}
		}

The non highlighted section of code was how my Spellbook.cs appeared before, and the red code is what needed to be added to make the spell book function with a client version higher then 6.0.1.0. Hope this helps!

[HellRazor]

Just to clarify, those changes are already in the RUO SVN. So I think you only need to make these changes if you're not using the SVN.

[vermillion2083]

Originally Posted by HellRazor

Just to clarify, those changes are already in the RUO SVN. So I think you only need to make these changes if you're not using the SVN.

This is true, I have custom spell classes that required modifications to spellbook.cs. Since my spell classes are quite old the spellbook.cs script has not been updated for some time.