OnDragDrop help

[TheRockstar2253]

I'm having issues trying to get this script to compile. This is a test script for an npc quest giver.

Here's the error:

Errors:
 + Customs/test999.cs:
    CS0161: Line 90: 'Server.Mobiles.test999.OnDragDrop(Server.Mobile, Server.It
em)': not all code paths return a value

Here is the code:

  public override bool OnDragDrop( Mobile from, Item dropped )
                           {
                              Mobile m = from;
                              PlayerMobile mobile = m as PlayerMobile;
                              
                               if (mobile != null)
                              {
                               if (dropped is Katana)
                               {
                                  if (dropped.Amount!=1)
                                  {
                                       this.PrivateOverheadMessage(MessageType.Regular, 1153, false,"That's not the right amount here!",mobile.NetState);
                                       return false;
                                       
                                   }

                                  dropped.Delete();
                                  mobile.AddToBackpack(new Katana());
                                 this.PrivateOverheadMessage(MessageType.Regular, 1153, false,"hyhyhyh" , mobile.NetState);
                                   return true;
                             }
                             else if (dropped is Whip)
                             {
                             this.PrivateOverheadMessage(MessageType.Regular, 1153, 1054071, mobile.NetState);
                             return false;
                             }
                             else
                             {
                               this.PrivateOverheadMessage(MessageType.Regular, 1153, false,"I have no need for this... ",  mobile.NetState);
                               return false;
                             }
                             
                          }
                      }
                 }

Anyway help will be much appreciated! -Rock

[FingersMcSteal]

Your not returning a value... your error explains it a little...'not all code paths return a value'.

Your class is... 'public override bool OnDragDrop( Mobile from, Item item )'.

The class requires you to return a bool value, true or false.

*edit*
Looks like the null check at the start might be the cause, whats it return if the mobile's null ?

[Tassyon T]

So... which line is line 90? It would be nice if you posted the whole script.

Edit:

Try adding in this line in red:

    public override bool OnDragDrop(Mobile from, Item dropped)
    {
        Mobile m = from;
        PlayerMobile mobile = m as PlayerMobile;

        if (mobile != null)
        {
            if (dropped is Katana)
            {
                if (dropped.Amount != 1)
                {
                    this.PrivateOverheadMessage(MessageType.Regular, 1153, false, "That's not the right amount here!", mobile.NetState);
                    return false;
                }

                dropped.Delete();
                mobile.AddToBackpack(new Katana());
                this.PrivateOverheadMessage(MessageType.Regular, 1153, false, "hyhyhyh", mobile.NetState);
                return true;
            }
            else if (dropped is Whip)
            {
                this.PrivateOverheadMessage(MessageType.Regular, 1153, 1054071, mobile.NetState);
                return false;
            }
            else
            {
                this.PrivateOverheadMessage(MessageType.Regular, 1153, false, "I have no need for this... ", mobile.NetState);
                return false;
            }

        }
        else
        {
             return false;
             this.PrivateOverheadMessage(MessageType.Regular, 1153, false, "I have no need for this...", mobile.NetState);
        }
    }

Basically the compiler is asking you ... "what happens if the mobile is null?"
You haven't put in a return value (true/false) for that.

[TheRockstar2253]

Originally Posted by Tassyon T

So... which line is line 90? It would be nice if you posted the whole script.

Line 90 IS the OnDragDrop method. I don't really want to have to post the whole script because this is part of the script creator program I'm working on atm.

[Tassyon T]

Originally Posted by TheRockstar2253

Line 90 IS the OnDragDrop method. I don't really want to have to post the whole script because this is part of the script creator program I'm working on atm.

did you try my code suggestion? I posted the code in an edit on my previous reply.

[TheRockstar2253]

Originally Posted by Tassyon T

did you try my code suggestion? I posted the code in an edit on my previous reply.

That did the trick. Thanks for the help I appreciate it man.

[Zippy]

You should indent your code properly, it makes errors like this a lot easier to spot.

[FingersMcSteal]

Originally Posted by Zippy

You should indent your code properly, it makes errors like this a lot easier to spot.

yup... me = lazy

[Tassyon T]

Originally Posted by FingersMcSteal

yup... me = lazy

uh... not to nit pick, but you == lazy.