Serialization / Deserialization Issues

[CB0T]

Originally Posted by Soteric

Do you serialize version as 26?

Yeap! 26!

...
public override void Deserialize( GenericReader reader )
		{
			base.Deserialize( reader );
			int version = reader.ReadInt();

			switch ( version )
			{
				case 26:				
				{
					m_Race = (RaceType) reader.ReadInt();					
					goto case 25;
				}				
				case 25:
				{
					int recipeCount = reader.ReadInt();

					if( recipeCount > 0 )
...
 The rest is default. :)

[Soteric]

This is deserializing. You need Serialize method:

base.Serialize( writer );

writer.Write( (int) 26 ); // version

[LuxoR]

He has a serialize, stated in the original post. Could you post a few additional lines of your serialize method?

base.Serialize( writer );

writer.Write( (int) 26 ); // version

writer.Write( (int) m_Race );

...

Should look something like that.

[CB0T]

Look:

CheckAtrophies( this );

			base.Serialize( writer );
			
			writer.Write( (int) 25 ); // version

                        writer.Write( (int) m_Race );

			if( m_AcquiredRecipes == null )
			{
				writer.Write( (int)0 );
			}
			else
			{
				writer.Write( m_AcquiredRecipes.Count );

				foreach( KeyValuePair<int, bool> kvp in m_AcquiredRecipes )
				{
					writer.Write( kvp.Key );
					writer.Write( kvp.Value );
				}
			}
					
			writer.WriteDeltaTime( m_LastHonorLoss );

			ChampionTitleInfo.Serialize( writer, m_ChampionTitles );

The error is in RED, right?

[Soteric]

Right, it should look like in Luxor's post

[CB0T]

WOOOOOOOOOOOOOOOOOORKS!

THANK YOU very much Soteric/Alf!

THANK YOU very much LuxoR!

[CB0T]

O Myyy.

Now i need some help to serialize and deserialize BaseCreature.cs

private RaceType m_Race; 
		[CommandProperty(AccessLevel.GameMaster)]
        public RaceType RaceType
        {
            get { return (m_Race); }
            set { m_Race = (RaceType)value; }
        }

public override void Serialize( GenericWriter writer )
		{
			base.Serialize( writer );

			writer.Write( (int) 17 ); // version 16 to 17 here

			writer.Write( (int) m_Race );

public override void Deserialize( GenericReader reader )
		{
			base.Deserialize( reader );

			int version = reader.ReadInt();

			m_Race = (RaceType) reader.ReadInt();					
			
			m_CurrentAI = (AIType)reader.ReadInt();
			m_DefaultAI = (AIType)reader.ReadInt();

Thanks!

[Soteric]

Add m_Race serialization to the end of the Serialize() method, not after version

In Deserialize() go to the last version checking, add new checking after it and place m_Race deserialization there

[CB0T]

Hard Work.

public override void Serialize( GenericWriter writer )
		{
			base.Serialize( writer );

			writer.Write( (int) 17 ); // version

(...)

                        // Version 14
			writer.Write( (bool)m_RemoveIfUntamed );
			writer.Write( (int)m_RemoveStep );
			
			// Version 17???
			writer.Write( (int) m_Race );
		}

public override void Deserialize( GenericReader reader )
		{
			base.Deserialize( reader );

			int version = reader.ReadInt();

(...)

                        if ( version >= 16 ) // <16
				Loyalty *= 10;

			if (version < 17 )
				m_Race = (RaceType) reader.ReadInt();									
				
			double activeSpeed = m_dActiveSpeed;
			double passiveSpeed = m_dPassiveSpeed;

World: Loading...An error was encountered while loading a saved object
- Type: Server.Mobiles.Vagabond
- Serial: 0x00003CE7
Delete the object? (y/n)
After pressing return an exception will be thrown and the server will terminate

Error:
System.Exception: Load failed (items=False, mobiles=True, guilds=False, type=Ser
ver.Mobiles.Vagabond, serial=0x00003CE7) ---> System.Exception: ***** Bad serial
ize on Server.Mobiles.Vagabond *****
at Server.World.Load()
--- End of inner exception stack trace ---
at Server.World.Load()
at Server.ScriptCompiler.Compile(Boolean debug, Boolean cache)
at Server.Core.Main(String[] args)
This exception is fatal, press return to exit

[CB0T]

if (version >= 17 )
				m_Race = (RaceType) reader.ReadInt();

// Version 14
			writer.Write( (bool)m_RemoveIfUntamed );
			writer.Write( (int)m_RemoveStep );
			
			// Version 17???
			writer.Write( (int) m_Race );

WORKS!

Thanks Again Alf.

You are the boss.

[LuxoR]

That doesn't make much sense...

public override void Serialize( GenericWriter writer )
		{
			base.Serialize( writer );

			writer.Write( (int) 17 ); // version

			writer.Write( (int) m_Race );

                        // Version 14
			writer.Write( (bool)m_RemoveIfUntamed );
			writer.Write( (int)m_RemoveStep );
		}

Your serialize was fine. You want to save updates at the top, that way you can version control when you load up. The error is in your Deserialize, you are not using proper version control (ie: loading version 16 BaseCreatures as version 17.

public override void Deserialize( GenericReader reader )
		{
			base.Deserialize( reader );

			int version = reader.ReadInt();

			if (version > 16 )
				m_Race = (RaceType) reader.ReadInt();

(...)

                        if ( version >= 16 ) // <16
				Loyalty *= 10;

			double activeSpeed = m_dActiveSpeed;
			double passiveSpeed = m_dPassiveSpeed;

I suspect that there should be a switch statement in BaseCreature deserialize, why did you not just add to that?

[razzles]

Originally Posted by LuxoR

I suspect that there should be a switch statement in BaseCreature deserialize, why did you not just add to that?

I suspect that you haven't looked at the deserialization portion of BaseCreature.cs. It does NOT have a switch statement in it.

[LuxoR]

Originally Posted by razzles

I suspect that you haven't looked at the deserialization portion of BaseCreature.cs. It does NOT have a switch statement in it.

Clearly, the fact that I said *should be* would be indication. Suspect is also the primary word, meaning it's not 100% certain, it's a guess, a logical one based on the fact that just about everything else in the core follows that method of version control.

It's not like I said "There is a switch statement in BaseCreature. Just change that."