need help please

[mikeymaze]

hi im having a issue with a script it spawns a item you use the item to cut the corpse the corpse is suppose to drop a heart


here is what im having issues with
private void VampKnife1Target_Callback( Mobile from, object obj )
{
if( from.InRange( this.GetWorldLocation(), 2 ) == false )
{
from.SendLocalizedMessage( 500486 ); //That is too far away.
}
else if( obj is Corpse)
{
Corpse corpse = (Corpse)obj;

if( corpse.Killer == from )
{
if( corpse.Owner is Celeste )
{
from.AddToBackpack( new SilverHeart() );
//from.Hits -=70;
from.SendMessage( "You carve open the monsters chest" );
this.Delete();
corpse.Delete();
return;
}
else
{
from.SendMessage( "This corpse is not of Celeste!" );
}
}
else
{
from.SendMessage( "You did not slay this creature!" );
}
}
else
{
from.SendMessage( "This is not a corpse!" );
}
}
_________________________________


as you see its commented out but i still get the you did not slay this creature msg

[Lord_Greywolf]

post your script in code tags (copy then paste it, then highlight and click on the # symbol above the window) that way it keeps its formating

how are you killing it?
the kill command does set you as its killer, and you have to be the one that did themost damage to it to be classified as its killer

[mikeymaze]

using Server.Targeting;
using Server.Mobiles;

namespace Server.Items 
{ 
	[FlipableAttribute( 0xF52, 0xF51 )]
   	public class VampKnife1: Item 
   	{ 
		[Constructable]
		public VampKnife1() : base( 0xF52 ) 
		{
			ItemID = 2550;
			Weight = 0.1;
			Name = "the Blade of SIlver";
			Hue = 906;
		}

                private void VampKnife1Target_Callback( Mobile from, object obj ) 
                { 
			if( from.InRange( this.GetWorldLocation(), 2 ) == false )
			{
				from.SendLocalizedMessage( 500486 );	//That is too far away.
			}
            		else if( obj is Corpse) 
            		{
               			Corpse corpse = (Corpse)obj; 

               			if( corpse.Killer == from ) 
               			{
               				if( corpse.Owner is Celeste ) 
               				{
                                		from.AddToBackpack( new SilverHeart() ); 
                     				//from.Hits -=null;
						from.SendMessage( "You carve open the monsters chest" ); 
                     				this.Delete();
						corpse.Delete();
                     					return;
					} 
					else
					{
						from.SendMessage( "This corpse is not of Celeste!" );
					}
				}
				else
				{
					from.SendMessage( "You did not slay this creature!" );
				}
            		} 
			else
			{
				from.SendMessage( "This is not a corpse!" );
			}
		}

                public override void OnDoubleClick( Mobile from ) 
                { 
			if ( !IsChildOf( from.Backpack ) )
			{
				from.SendLocalizedMessage( 1042001 ); // That must be in your pack for you to use it.
                        } 
                        else 
                        { 
                                from.BeginTarget( -1, false, TargetFlags.Harmful, new TargetCallback( 

VampKnife1Target_Callback ) );
				from.SendMessage( "Target the corpse of Celeste." );
			}         
		}

            	public VampKnife1( Serial serial ) : base ( serial ) 
            	{             
           	} 
            
           	public override void Serialize( GenericWriter writer ) 
           	{ 
              		base.Serialize( writer ); 
              		writer.Write( (int) 0 ); 
           	} 
            
           	public override void Deserialize( GenericReader reader ) 
           	{ 
              		base.Deserialize( reader ); 
              		int version = reader.ReadInt(); 
           	} 
        } 
}

this doesnt throw errors cause i change it to =null but when i click the knife and the moster it will not let me skin the corpse to retreive the heart. I have tried killing it with a pet and it dont work i tried it on a player and admin account , ive also tried the block kill nothing seems to work, also tried to cast spells well attacking it with a pet

[mikeymaze]

using System;
using Server;
using Server.Misc;
using Server.Items;

namespace Server.Mobiles 
{ 
	[CorpseName( "an Vampiriac corpse" )] 
	public class Celeste : BaseCreature 
	{ 
		[Constructable] 
		public Celeste() : base( AIType.AI_Mage, FightMode.Closest, 10, 1, 0.2, 0.4 ) 
		{ 
			Title = "the Queen of the Underworld";
			Name = "Celeste";
			Body = 745;
			Hue = 0;  

			SetStr( 900, 940 );
			SetDex( 191, 115 );
			SetInt( 670, 690 );

			SetHits( 1520, 1700 );

			SetDamage( 15, 18 );

			SetDamageType( ResistanceType.Physical, 100 );
	
			VirtualArmor = 55;

			SetSkill( SkillName.EvalInt, 100.0, 120.0 );
			SetSkill( SkillName.Tactics, 95.1, 110.0 );
			SetSkill( SkillName.MagicResist, 75.0, 97.5 );
			SetSkill( SkillName.Wrestling, 90.2, 110.0 );
			SetSkill( SkillName.Meditation, 120.0);
			SetSkill( SkillName.Focus, 120.0);
			SetSkill( SkillName.Magery, 120.0 );

			Fame = 15000;
			Karma = -15000;
            							
			VampireLeatherChest chest = new VampireLeatherChest();
			chest.Movable = false;
			chest.Hue = 906;
   			AddItem(chest);
   			
   			VampireLeatherGloves gloves = new VampireLeatherGloves();
   			gloves.Movable = false;
			gloves.Hue = 906;
  			AddItem(gloves);
  			
  			VampireLeatherGorget gorget = new VampireLeatherGorget();
  			gorget.Movable = false;
			gorget.Hue = 906;
 			AddItem(gorget);
 			
 			VampireLeatherLegs legs = new VampireLeatherLegs();
 			legs.Movable = false;
			legs.Hue = 906;
			AddItem(legs);

			VampireLeatherArms arms = new VampireLeatherArms();
			arms.Movable = false;
			arms.Hue = 906;
			AddItem(arms);

			VampireRobe VampireRobe = new VampireRobe();
			VampireRobe.Hue = 906;
			VampireRobe.Movable = false;
			AddItem(VampireRobe);
			
			Sandals sandals = new Sandals();
			sandals.Hue = 906;
			AddItem( sandals );

			HalfApron halfapron = new HalfApron();
			halfapron.Movable = false;
			halfapron.Hue = 906;
			halfapron.Layer = Layer.Waist;
			AddItem(halfapron);

			Item weapon = new ScytheOfFaith();
				weapon.Movable = false;
				weapon.Hue = 906;
			AddItem( weapon );

		}

		public override void GenerateLoot()
		{
			switch ( Utility.Random( 20 ))
			{
				case 0: PackItem( new ScytheOfFaith() ); break;
					
			}
			
			switch ( Utility.Random( 10 ))
			{
				case 0: PackItem( new VampireLeatherChest() ); break;
				case 1: PackItem( new VampireLeatherGloves() ); break;
				case 2: PackItem( new VampireLeatherGorget() ); break;
				case 3: PackItem( new VampireLeatherLegs() ); break;
				case 4: PackItem( new VampireLeatherArms() ); break;
				case 5: PackItem( new SilverHeart() ); break;
			}
					

			PackGold( 1575, 1700);
			AddLoot( LootPack.MedScrolls, 2 );
			AddLoot( LootPack.Gems, 5 );
		}

		public override bool AlwaysMurderer{ get{ return true; } }

		public Celeste( Serial serial ) : base( serial )
		{
		}

		public override void Serialize( GenericWriter writer )
		{
			base.Serialize( writer );
			writer.Write( (int) 0 );
		}

		public override void Deserialize( GenericReader reader )
		{
			base.Deserialize( reader );
			int version = reader.ReadInt();
		}
	}
}

was thinking about giving up the knifes and just having the head appear on the corpse but its random and i am not sure how to change it to say 80% of the time ... think it maybe better but the quest guy will still hand out the knifes. also having the same issues with another part on collecting Gems and Target the creature says i did not slay this creature

[mikeymaze]

Mistake sorry

[Lord_Greywolf]

you are missing some stuff in your targeting for 1 (refering back to the knove and other stuff)
also at that pint (in the tatgeting) "this" now referes to the target, etc
and missing stuff of "using" also

here is a script i wrote that target a corpse, checks to see if it has been carved or not, if so increases the hides, chance for a heart, etc also (it uses my custom critters, so you need to modify it)
it does leave the corpse behind so they can loot it, but can not carve it again, etc
so use the parts you want, butcher it up, etc
but everything you need to fix yours is in there
(ps mine requires forensics skill to use also lol)

using System;
using Server.Network;
using Server;
using Server.Targeting;
using Server.Items;
using Server.Mobiles;
using Server.Targets;

namespace Server.Items
{
	[FlipableAttribute( 0x13F6, 0x13F7 )]
	public class ForensicsScalpel : BaseKnife, IUsesRemaining
	{
		public override WeaponAbility PrimaryAbility{ get{ return WeaponAbility.InfectiousStrike; } }
		public override WeaponAbility SecondaryAbility{ get{ return WeaponAbility.Disarm; } }

		public override int AosStrengthReq{ get{ return 5; } }
		public override int AosMinDamage{ get{ return 9; } }
		public override int AosMaxDamage{ get{ return 11; } }
		public override int AosSpeed{ get{ return 49; } }

		public override int InitMinHits{ get{ return 31; } }
		public override int InitMaxHits{ get{ return 40; } }

		private int m_UsesRemaining;
		private bool m_ShowUsesRemaining;

		[CommandProperty( AccessLevel.GameMaster )]
		public int UsesRemaining
		{
			get { return m_UsesRemaining; }
			set { m_UsesRemaining = value; InvalidateProperties(); }
		}

		[CommandProperty( AccessLevel.GameMaster )]
		public bool ShowUsesRemaining
		{
			get { return m_ShowUsesRemaining; }
			set { m_ShowUsesRemaining = value; InvalidateProperties(); }
		}

		[Constructable]
		public ForensicsScalpel() : this( 50 ){}

		[Constructable]
		public ForensicsScalpel( int uses ) : base( 0x13F6 )
		{
			Hue = 2370;
			UsesRemaining = uses;
			ShowUsesRemaining = true;
			Name = "Forensics Scalpel";
		}

		public override void OnDoubleClick( Mobile from )
		{
			if ( !IsChildOf( from.Backpack ) )
			{
				from.SendLocalizedMessage( 1042001 );
			}
			else if ( from.Skills[SkillName.Forensics].Base < 49.9 )
			{
				from.SendMessage( "You do not understand how to use this." );
			}
			else
			{
				from.Target = new ForensicsScalpelTarget( this );
				from.SendMessage( "Which corpse you want to carve?" );
			}
		}

		private class ForensicsScalpelTarget : Target
		{
			private ForensicsScalpel m_Knife;

			public ForensicsScalpelTarget( ForensicsScalpel knife ) : base( 15, false, TargetFlags.None )
			{
				m_Knife = knife;
			}

			protected override void OnTarget( Mobile from, object target )
			{
				if ( target is ForensicsScalpel && target != m_Knife )
				{
					ForensicsScalpel tknife = target as ForensicsScalpel;
					if (tknife != null)
					{
						int knifeuses = tknife.UsesRemaining;
						m_Knife.UsesRemaining += knifeuses;
						tknife.Delete();
					}
				}
				else if ( target is Corpse )
				{
					Corpse c = (Corpse)target;
					if (c.Owner is BaseCreature)
					{
						BaseCreature cowner = c.Owner as BaseCreature;
						if (c.Carved == false)
						{
							Map map = from.Map;
							if ( map == null )
								return;
							int wool = (int)(((BaseCreature)c.Owner).Wool / 2);
							int feathers = (int)(((BaseCreature)c.Owner).Feathers / 2);
							int meat = (int)(((BaseCreature)c.Owner).Meat / 2);
							int hides = (int)(((BaseCreature)c.Owner).Hides / 2);
							int scales = (int)(((BaseCreature)c.Owner).Scales / 2);
							double skillper = (from.Skills.Forensics.Value / 2000);

							if (m_Knife != null )
							{
								if ( feathers != 0 )
								{
									c.DropItem( new Feather( feathers ) );
									from.SendMessage("Your knowledge allowed you to get more feathers from the corpse");
								}

								if ( wool != 0 )
								{
									c.DropItem( new Wool( wool ) );
									from.SendMessage("Your knowledge allowed you to get more wool from the corpse");
								}

								if ( meat >= 1)
								{
									if ( ((BaseCreature)c.Owner).MeatType == MeatType.Ribs )
										c.DropItem( new RawRibs( meat ) );
									else if ( ((BaseCreature)c.Owner).MeatType == MeatType.Bird )
										c.DropItem( new RawBird( meat ) );
									else if ( ((BaseCreature)c.Owner).MeatType == MeatType.LambLeg )
										c.DropItem( new RawLambLeg( meat ) );

									from.SendMessage("Your knowledge allowed you to get more meat from the corpse");
								}

								if ( hides >= 1)
								{
									if (((BaseCreature)c.Owner).HideType == HideType.Regular )
										c.DropItem( new Hides( hides ) );
									else if (((BaseCreature)c.Owner).HideType == HideType.Spined )
										c.DropItem( new SpinedHides( hides ) );
									else if (((BaseCreature)c.Owner).HideType == HideType.Horned )
										c.DropItem( new HornedHides( hides ) );
									else if (((BaseCreature)c.Owner).HideType == HideType.Barbed )
										c.DropItem( new BarbedHides( hides ) );
									else if (((BaseCreature)c.Owner).HideType == HideType.Polar )
										c.DropItem( new PolarHides( hides ) );
									else if (((BaseCreature)c.Owner).HideType == HideType.Amphibisch )
										c.DropItem( new AmphibischHides( hides ) );
									else if (((BaseCreature)c.Owner).HideType == HideType.Blaze )
										c.DropItem( new BlazeHides( hides ) );
									else if (((BaseCreature)c.Owner).HideType == HideType.Daemonic )
										c.DropItem( new DaemonicHides( hides ) );
									else if (((BaseCreature)c.Owner).HideType == HideType.Shadow )
										c.DropItem( new ShadowHides( hides ) );
									else if (((BaseCreature)c.Owner).HideType == HideType.Frost )
										c.DropItem( new FrostHides( hides ) );
									else if (((BaseCreature)c.Owner).HideType == HideType.Ethereal )
										c.DropItem( new EtherealHides( hides ) );
									else if ( ((BaseCreature)c.Owner).HideType == HideType.All )
									{
										c.DropItem( new Hides( hides ) );
										c.DropItem( new SpinedHides( hides ) );
										c.DropItem( new HornedHides( hides ) );
										c.DropItem( new BarbedHides( hides ) );
										c.DropItem( new PolarHides( hides ) );
										c.DropItem( new AmphibischHides( hides ) );
										c.DropItem( new BlazeHides( hides ) );
										c.DropItem( new DaemonicHides( hides ) );
										c.DropItem( new ShadowHides( hides ) );
										c.DropItem( new FrostHides( hides ) );
										c.DropItem( new EtherealHides( hides ) );
									}
									else if ( ((BaseCreature)c.Owner).HideType == HideType.Random )
									{
										int i_RandomHide = Utility.RandomMinMax( 1, 11 );
										switch (i_RandomHide)
										{
											case 1: default: c.DropItem( new Hides( hides ) );break;
											case 2: c.DropItem( new SpinedHides( hides ) );break;
											case 3: c.DropItem( new HornedHides( hides ) );break;
											case 4: c.DropItem( new BarbedHides( hides ) );break;
											case 5: c.DropItem( new PolarHides( hides ) );break;
											case 6: c.DropItem( new AmphibischHides( hides ) );break;
											case 7: c.DropItem( new BlazeHides( hides ) );break;
											case 8: c.DropItem( new DaemonicHides( hides ) );break;
											case 9: c.DropItem( new ShadowHides( hides ) );break;
											case 10: c.DropItem( new FrostHides( hides ) );break;
											case 11: c.DropItem( new EtherealHides( hides ) );break;
										}
									}
									else if ( ((BaseCreature)c.Owner).HideType == HideType.HighRandom )
									{
										int i_RandomHide = Utility.RandomMinMax( 4, 11 );
										switch (i_RandomHide)
										{
											case 4: c.DropItem( new BarbedHides( hides ) );break;
											case 5: c.DropItem( new PolarHides( hides ) );break;
											case 6: c.DropItem( new AmphibischHides( hides ) );break;
											case 7: c.DropItem( new BlazeHides( hides ) );break;
											case 8: c.DropItem( new DaemonicHides( hides ) );break;
											case 9: c.DropItem( new ShadowHides( hides ) );break;
											case 10: c.DropItem( new FrostHides( hides ) );break;
											case 11: c.DropItem( new EtherealHides( hides ) );break;
										}
									}
									from.SendMessage("Your knowledge allowed you to get more hides from the corpse");
								}

								if ( scales >= 1)
								{
									if (((BaseCreature)c.Owner).ScaleType == ScaleType.Red )
										c.DropItem( new RedScales( scales ) );
									else if (((BaseCreature)c.Owner).ScaleType == ScaleType.Yellow )
										c.DropItem( new YellowScales( scales ) );
									else if (((BaseCreature)c.Owner).ScaleType == ScaleType.Black )
										c.DropItem( new BlackScales( scales ) );
									else if (((BaseCreature)c.Owner).ScaleType == ScaleType.Green )
										c.DropItem( new GreenScales( scales ) );
									else if (((BaseCreature)c.Owner).ScaleType == ScaleType.White )
										c.DropItem( new WhiteScales( scales ) );
									else if (((BaseCreature)c.Owner).ScaleType == ScaleType.Blue )
										c.DropItem( new BlueScales( scales ) );
									else if (((BaseCreature)c.Owner).ScaleType == ScaleType.Copper )
										c.DropItem( new CopperScales( scales ) );
									else if (((BaseCreature)c.Owner).ScaleType == ScaleType.Silver )
										c.DropItem( new SilverScales( scales ) );
									else if (((BaseCreature)c.Owner).ScaleType == ScaleType.Gold )
										c.DropItem( new GoldScales( scales ) );
									else if (((BaseCreature)c.Owner).ScaleType == ScaleType.All )
									{
										c.DropItem( new RedScales( scales ) );
										c.DropItem( new YellowScales( scales ) );
										c.DropItem( new BlackScales( scales ) );
										c.DropItem( new GreenScales( scales ) );
										c.DropItem( new WhiteScales( scales ) );
										c.DropItem( new BlueScales( scales ) );
										c.DropItem( new CopperScales( scales ) );
										c.DropItem( new SilverScales( scales ) );
										c.DropItem( new GoldScales( scales ) );
									}
									else if (((BaseCreature)c.Owner).ScaleType == ScaleType.Random )
									{
										int i_RandomScale = Utility.RandomMinMax( 1, 9 );
										switch (i_RandomScale)
										{
											case 1:	c.DropItem( new RedScales( scales ) ); break;
											case 2:	c.DropItem( new YellowScales( scales ) ); break;
											case 3:	c.DropItem( new BlackScales( scales ) ); break;
											case 4:	c.DropItem( new GreenScales( scales ) ); break;
											case 5:	c.DropItem( new WhiteScales( scales ) ); break;
											case 6:	c.DropItem( new BlueScales( scales ) ); break;
											case 7:	c.DropItem( new CopperScales( scales ) ); break;
											case 8:	c.DropItem( new SilverScales( scales ) ); break;
											case 9:	c.DropItem( new GoldScales( scales ) ); break;
										}
									}
									from.SendMessage("Your knowledge allowed you to get more Scales from the corpse");
								}

								if ( skillper >= Utility.RandomDouble() )
								{
									if (cowner is Dragon || cowner is Random1to5Dragons || cowner is Random6to10Dragons || cowner is Random11to15Dragons ||
										cowner is Random16to20Dragons || cowner is Random21to25Dragons || cowner is RandomDragons )
									{
										c.DropItem( new DragonHeart() );
										from.SendMessage("Your knowledge allowed you to get the heart of the creature");
									}

									if (cowner is RandomPoison1to5Dragons || cowner is RandomPoison6to10Dragons || cowner is RandomPoison11to15Dragons ||
										cowner is RandomPoison16to20Dragons || cowner is RandomPoison21to25Dragons || cowner is RandomPoisonDragons )
									{
										c.DropItem( new PoisonDragonHeart() );
										from.SendMessage("Your knowledge allowed you to get the heart of the creature");
									}

									if (cowner is WhiteWyrm || cowner is ShadowWyrm || cowner is Random1to5Wyrms || cowner is Random6to10Wyrms || cowner is Random11to15Wyrms ||
										cowner is Random16to20Wyrms || cowner is Random21to25Wyrms || cowner is RandomWyrms )
									{
										c.DropItem( new WyrmHeart() );
										from.SendMessage("Your knowledge allowed you to get the heart of the creature");
									}

									if (cowner is AncientWyrm || cowner is Random1to5AncientWyrms || cowner is Random6to10AncientWyrms || cowner is Random11to15AncientWyrms ||
										cowner is Random16to20AncientWyrms || cowner is Random21to25AncientWyrms || cowner is RandomAncientWyrms )
									{
										c.DropItem( new AncientWyrmHeart() );
										from.SendMessage("Your knowledge allowed you to get the heart of the creature");
									}

									if (cowner is SerpentineDragon || cowner is RandomSerpentine1to5Dragons || cowner is RandomSerpentine6to10Dragons || cowner is RandomSerpentine11to15Dragons ||
										cowner is RandomSerpentine16to20Dragons || cowner is RandomSerpentine21to25Dragons || cowner is RandomSerpentinDragons )
									{
										c.DropItem( new DragonHeart() );
										from.SendMessage("Your knowledge allowed you to get the heart of the creature");
									}

									if (cowner is Random1to5Hydras || cowner is Random6to10Hydras || cowner is Random11to15Hydras ||
										cowner is Random16to20Hydras || cowner is Random21to25Hydras || cowner is RandomHydras )
									{
										c.DropItem( new HydraHeart() );
										from.SendMessage("Your knowledge allowed you to get the heart of the creature");
									}

									if (cowner is SkeletalDragon || cowner is RandomSkeletal1to5Dragons || cowner is RandomSkeletal6to10Dragons || cowner is RandomSkeletal11to15Dragons ||
										cowner is RandomSkeletal16to20Dragons || cowner is RandomSkeletal21to25Dragons || cowner is RandomSkeletalDragons )
									{
										c.DropItem( new DragonBone() );
										from.SendMessage("Your knowledge allowed you to get the special bone of the creature");
									}

									if (cowner.BodyValue == 745 || cowner.BodyValue == 744 || cowner.BodyValue == 401 || cowner.BodyValue == 400 || cowner.BodyValue == 186 ||
										cowner.BodyValue == 185 || cowner.BodyValue == 184 || cowner.BodyValue == 183 || cowner.BodyValue == 751 || cowner.BodyValue == 750)
									{
										c.DropItem( new SpineBones() );
										from.SendMessage("Your knowledge allowed you to get the spine of the creature");
									}

								}

								if (m_Knife.UsesRemaining > 1)
									m_Knife.UsesRemaining--;
								else
								{
									m_Knife.Delete();
									from.SendMessage("You used up your Forensics Scalpel");
								}
								from.SendMessage("You carve the corpse.");
								if ( c is ICarvable ) ((ICarvable)c).Carve( from, m_Knife );
								c.Carved = true;
							}
						}
						else from.SendMessage("You see nothing useful to carve from the corpse.");
						c.Carved = true;
					}
				}
			}
		}

		public ForensicsScalpel( Serial serial ) : base( serial ) { }
		public override void Serialize( GenericWriter writer )
		{
			base.Serialize( writer );
			writer.Write( (int) 0 );
			writer.Write( (bool) m_ShowUsesRemaining );
			writer.Write( (int) m_UsesRemaining );
		}

		public override void Deserialize( GenericReader reader )
		{
			base.Deserialize( reader );
			int version = reader.ReadInt();
			m_ShowUsesRemaining = reader.ReadBool();
			m_UsesRemaining = reader.ReadInt();
		}
	}
}