Threaded WorldSave overlook?

[UOT]

Right now in the Save method of world you have

			if ( m_MultiProcessor )
			{
				Thread saveThread = new Thread( new ThreadStart( SaveItems ) );

				saveThread.Name = "Item Save Subset";
				saveThread.Start();

				SaveMobiles();
				SaveGuilds();
				SaveRegions();

				saveThread.Join();
			}
			else
			{
				SaveMobiles();
				SaveItems();
				SaveGuilds();
				SaveRegions();
			}

Isn't SaveItems missing from the threaded save?

			if ( m_MultiProcessor )
			{
				Thread saveThread = new Thread( new ThreadStart( SaveItems ) );

				saveThread.Name = "Item Save Subset";
				saveThread.Start();

				SaveMobiles();
				SaveItems();
				SaveGuilds();
				SaveRegions();

				saveThread.Join();
			}
			else
			{
				SaveMobiles();
				SaveItems();
				SaveGuilds();
				SaveRegions();
			}

[Zippy]

No, the whole purpose of the threaded save is that it saves items concurrently in a thread started at the begining instead of saving them in line with everything else.

Thus this:

Thread saveThread = new Thread( new ThreadStart( SaveItems ) );

				saveThread.Name = "Item Save Subset";
				saveThread.Start();

Calls SaveItems() from a new thread.... The old thread then continues on to save mobiles, etc.

[UOT]

Can't beleive I didn't see the save items in the new thread. I'll go hide under a rock now :P

[KillerBeeZ]

does this mean that RunUO does indeed support multithreading? and how recent a change was this (as in which version was it implimented)?

[Zippy]

RunUO has always been "multithreaded"

This change went in with 1.0.0, prior to that there was a different type of "threaded" world save that was implimented around beta 20. And RunUO's network has always been fully multithreaded.

[KillerBeeZ]

Originally Posted by Zippy

RunUO has always been "multithreaded"

This change went in with 1.0.0, prior to that there was a different type of "threaded" world save that was implimented around beta 20. And RunUO's network has always been fully multithreaded.

Thank you

I was told a while ago that RunUO doesnt use multithreading, would this be the same as hyperthreading? if not, then that might be what I heard

[TheOutkastDev]

Basicly, Hyperthreading is where you have one physical processor that represents itself as two "virtual" processors to the operating system, allowing it to execute 2 threads in parallel.

Whenever a thread executes on one of the processor's pipelines, it may do something that causes the thread to stall, ie.. floating point calculation, memory read ect... Whenever this happens, an HT enabled system can throw other threads into the other unused parts of the pipeline.