Crash every 3 days or so using RunUO 2.0 RC1

[Shanira]

Server Crash Report
===================

RunUO Version 2.0, Build 2357.32527
Operating System: Microsoft Windows NT 5.2.3790 Service Pack 1
.NET Framework: 2.0.50727.42
Time: 06-11-2006 16:40:28
Mobiles: 7047
Items: 66543
Clients:
- Count: 0

Exception:
System.IndexOutOfRangeException: Index was outside the bounds of the array.
at Server.Core.Main(String[] args)

Really not sure what to make of this one. It keeps happening at semi-regular intervals. Does anyone else get anything like this, or is it just me? I even looked at Core.Main and couldn't figure out where it was erroring. What's also baffling is the lack of information despite starting with -debug.

Um, any ideas?

[daat99]

Debug crash report might bring up more ideas.

[Shanira]

That is the report after I turned on debug though... O_o

I mean, here's the console dump for the server starting:

RunUO - [www.runuo.com] Version 2.0, Build 2357.32527
Core: Running on .NET Framework Version 2.0.50727
Core: Running with arguments: -debug
Core: Optimizing for 2 processors
Scripts: Compiling C# scripts...done (cached)

[Kenny164]

Are you running it from the command prompt?

I may be wrong, but I think I heard somebody on this forum (lately) saying that was cause of a similar problem.

[Shanira]

Well I use a custom solution that restarts the server and lets me remotely stop or restart it as well. So it might be that, but I just spent a good half hour searching for something about this and coming up with a lot of blanks.

If anyone has the solution to this I'd much appreciate knowing.

[Thistle]

Well I use a custom solution that restarts the server ...

Why not remove that and see if the problem goes away?

[Joeku]

Is your server completely stock, or do you have custom system(s) installed?

[Shanira]

Well without that solution it becomes really hard to manage the server? >_> I suppose I can try that.

And yes, I have a bunch of scripts installed including XmlSpawners, Knives' Townhouses, Sleepable Beds, QuickRestart and a custom script I made for a dye remover item.

I fail to see how any of them would throw an exception in Core.Main() though, if it was a script erroring out wouldn't it give me a stack trace to a script and give a lot more information if it's in debug mode?

Meh, this thing has me completely dumbfounded.

EDIT: Oh AND they always happen when nobody's on, so far. Which makes it even more mysterious.

[Malaperth]

Unfortunately, this is exactly why 2.0 is not recommended to be run on a production shard.

[GameOva]

Have you deleted the
Scripts.cs.dll
Scripts.cs.hash
From the Scripts output folder ? If not do so

Also the reportHistory.xml and StaffHistory.xml from the main directory

I would do that before anything else if you have made or added any new scripts and that should fix it. As long as its not a script issue.

Good Luck

[RavonTUS]

Greetings,

I could be a timer in a script. Do you have a weather or season script installed that may change or a save/backup that only runs every few days?

One other question, did you modify your core or is it stock?

-Ravon

[Shanira]

If nobody runs a shard with it bugs like this might not come to the surface though?

Well I let a more schooled friend of mine look at him and according to him the problem is in the core file Main.cs, in Core.Main() (stock, I haven't done core modifications)

					if ( ( ++sample % sampleInterval ) == 0 ) {
						now = DateTime.Now;
						m_CyclesPerSecond[m_CycleIndex++ % m_CyclesPerSecond.Length] =
							ticksPerSecond / ( now.Ticks - last.Ticks );
						last = now;
					}

This is run in an infinite loop and so eventually m_CycleIndex will become too large and the server exits by throwing an Index Out Of Range error.

I'll uh, think of a fix later when I'm not distracted by playing PSU but this basically seems to be where the problem is.

[daat99]

Actually it use the operator % in order to ensure that it will never go out of bounds.

[Shanira]

Asked him again about it today, and explained what you said here. As I understand m_CycleIndex will increase every loop through. The modulus operator will make sure it won't get out of bounds, I just realized.

Only problem comes up when m_CycleIndex is 2147483647.

Apparantly in C# 2147483647 + 1 = -2147483648

I never thought of that as I'm used to getting overflow errors if I try a stunt like that.

-2147483648 mod 100 = -48

m_CyclesPerSecond[-48] = ticksPerSecond / ( now.Ticks - last.Ticks );

And considering:

private static float[] m_CyclesPerSecond = new float[100];

BOOM index out of range exception, server blows up. Considering the crash was about every 3 days, this should be what's happening as far as I can tell.

[snicker7]

I can confirm this. Initialize m_CycleIndex to 2147483646, recompile the core and launch, give it a few seconds and you'll get the same crash.

[snicker7]

probably should just add an accessor for CycleIndex, and reset it to 0 whenever it is == to m_CyclesPerSecond.Length.

[noobie]

change it to unsigned int

[snicker7]

it will still overflow eventually, and while it wont crash, it may cause some silly shit with the cyclespersecond counter. I guess that's not that important, but to do it the right way...

[krrios]

Great catch! I don't have SVN access from this machine, but I'll make sure this gets resolved.

[Zippy]

Fixed in SVN Rev 100 and 101.

[Shanira]

Glad I could be of service.

[Kenko]

Great fix Zippy/krrios!

[Andromeda]

Originally Posted by Zippy

Fixed in SVN Rev 100 and 101.

I have the same error on RUNUO 2.0 RC1, so I really would like this fix, but where can I get it.
Searching on SVN comes out with no pages.

So if you would be so kind to hand the link.
Thank you

[Kenko]

Download TortoiseSVN and follow the link in Announcements forum, there is a thread about SVN Repository.

[Andromeda]

hmm dunno what you mean but in announcements there is no where the link to: Fixed in SVN Rev 100 and 101. It has only links to TortoiseSVN
and I need to know where to download that as the Main.cs is fixed in there for this problem.