Faction Crafting

[munkie]

My players (and me testing the issues) are not able to craft faction items. They have the skill and silver needed to make the items, but it never asks them if they want it to be a faction item. We also made sure they tried it in a city they currently control and still no change. Any idea why this wouldn't work?

[Nevaeh the Genie]

I have no issues with this. You are testing this with a crafter that is active in the faction? If so then when the crafter in the faction double clicks a tinkers tool they go to the second page and see the gumps to make traps?

[munkie]

Yes I see the traps menu under tinkering, but I'm still not sure why I cant make faction armor/weapons.

[munkie]

I've tried to reset the factions using [factionreset, [factiontownreset, and [factionitemreset but every time i do it, i get the following error then the shard crashes:

Server Crash Report
===================

RunUO Version 2.0, Build 2357.32527
Operating System: Microsoft Windows NT 5.2.3790 Service Pack 1
.NET Framework: 2.0.50727.42
Time: 4/8/2007 3:40:12 AM
Mobiles: 14433
Items: 118769
Clients:
- Count: 1
+ 68.206.15.150: (account = <account name removed>) (mobile = 0x5 '<mobile name removed>')

Exception:
System.NullReferenceException: Object reference not set to an instance of an object.
at Server.Factions.Town.Capture(Faction f)
at Server.Factions.Faction.FactionReset_OnCommand(Com mandEventArgs e)
at Server.Commands.CommandSystem.Handle(Mobile from, String text, MessageType type)
at Server.Mobile.DoSpeech(String text, Int32[] keywords, MessageType type, Int32 hue)
at Server.Mobiles.PlayerMobile.DoSpeech(String text, Int32[] keywords, MessageType type, Int32 hue)
at Server.Engines.PartySystem.Chat3Guild.UnicodeSpeec hChat3(NetState state, PacketReader pvSrc)
at Server.Network.MessagePump.HandleReceive(NetState ns)
at Server.Network.MessagePump.Slice()
at Server.Core.Main(String[] args)

I have even removed all faction items and booted all faction players and regenerated and still the same problem.

Any idea how I can resolve this?

[Malaperth]

Run your server in debug mode to hopefully find the exact location of the crash.

How to run your server in DEBUG

and what specific command crashes the server or is it all of those commands?

[munkie]

I ran the server in debug, and the error didn't change. I'm not sure the server went into debug though, even though I put the correct switch on the end of the shortcut. Any ideas?

[Malaperth]

If you are running 2.0, it will tell you when you start that you are in debug mode. The errors should be very similar but with line numbers in the error.

[munkie]

I get the following error when I put it in debug, but I have not changed any of the files its referring too.

Exception:
System.NullReferenceException: Object reference not set to an instance of an object.
at Server.Factions.Town.Capture(Faction f) in c:\RunUO\Scripts\Engines\Factions\Core\Town.cs:lin e 444
at Server.Factions.Town.set_Owner(Faction value) in c:\RunUO\Scripts\Engines\Factions\Core\Town.cs:lin e 37
at Server.Factions.Faction.FactionReset_OnCommand(Com mandEventArgs e) in c:\RunUO\Scripts\Engines\Factions\Core\Faction.cs: line 621
at Server.Commands.CommandSystem.Handle(Mobile from, String text, MessageType type)
at Server.Mobile.DoSpeech(String text, Int32[] keywords, MessageType type, Int32 hue)
at Server.Mobiles.PlayerMobile.DoSpeech(String text, Int32[] keywords, MessageType type, Int32 hue) in c:\RunUO\Scripts\Mobiles\PlayerMobile.cs:line 2162
at Server.Network.PacketHandlers.UnicodeSpeech(NetSta te state, PacketReader pvSrc)
at Server.Network.MessagePump.HandleReceive(NetState ns)
at Server.Network.MessagePump.Slice()
at Server.Core.Main(String[] args)

[Malaperth]

That appears to be a bug in the RC1 code. This is the Capture method from one of the SVN versions. You can try replacing yours with this:

		public void Capture( Faction f )
		{
			f.Silver += SilverCaptureBonus;

			if ( m_State.Owner == f )
				return;

			if ( m_State.Owner == null ) // going from unowned to owned
				LastIncome = DateTime.Now;
			else if ( f == null ) // going from owned to unowned
				LastIncome = DateTime.MinValue;
			// otherwise changing hands, income timer doesn't change

			m_State.Owner = f;

			Sheriff = null;
			Finance = null;

			TownMonolith monolith = this.Monolith;

			if ( monolith != null )
				monolith.Faction = f;

			VendorListCollection vendorLists = VendorLists;

			for ( int i = 0; i < vendorLists.Count; ++i )
			{
				VendorList vendorList = vendorLists[i];
				FactionVendorCollection vendors = vendorList.Vendors;

				for ( int j = vendors.Count - 1; j >= 0; --j )
					vendors[j].Delete();
			}

			GuardListCollection guardLists = GuardLists;

			for ( int i = 0; i < guardLists.Count; ++i )
			{
				GuardList guardList = guardLists[i];
				FactionGuardCollection guards = guardList.Guards;

				for ( int j = guards.Count - 1; j >= 0; --j )
					guards[j].Delete();
			}

			ConstructGuardLists();
		}

[munkie]

Thanks I'll give it a try. Would it be worth doing to upgrade to the lastest SVN?

[Malaperth]

I think it would, yes. Especially since it will get you at least started on the updates that will eventually be necessary to use the next release of 2.0 since much has changed in the SVN code.

[munkie]

Could you point me in the general direction on how to obtain the latest SVN? I'm not seeing it on the forums.

[Malaperth]

RunUO 2.0 SVN open to public, Update on 2.0 Release

There is also a thread in FAQ forum about how to compile your new server you will need.

[munkie]

Thanks for all of your help, I'll get right on updating my shard!

[munkie]

Alright so, I've updated my shard to the latest SVN (the server and scripts) and I am (or players) still not able to craft faction items in a town controlled by the faction.

The update did fix the crashing when i used the faction commands though. Does anyone have any other ideas?

[munkie]

I am going to go out on a lim here and ask this...could the problem be that I am forcing the towns to be taken over faster then 24hours (setting the CorruptionStart to a day before), so we can test the factions quicker?

I'm not sure why this would change anything but I just thought I would ask it anyway.