Region Loading mistake - RunUO

Arahil · 08-20-2005, 09:09 AM

When the world is loaded at server startup (the call to World.Load in ScriptsCompiler.cs), the regions are not loaded from the XML file. Region.Load is called in the MainLoop directly after the ScriptCompiler, but at this time the deserialization of the Regions is already finished.

But since there are no regions known by the server before Region.Load is called, FindRegionByUId, which is called while reading saves/regions/regions.idx always returns null, which prevents any further loading.

so to fix this problem the order of the actions has to be changed a little bit.
Regions.Load should be called after the deserialisation of mobiles, items and guilds, and when the xml file is read regions can be deserialized.

but since no region in the standard distro uses region serilization, this bug is not really critical

Arahil · 08-23-2005, 07:54 PM

I#m sorry, i overlooked one little thing: before Region.Load is called, the Initialize()-Methods of all the Scripts ar called, and there (in all the Subtypes of Region) are some Region-registration calls.

Just wanted to let you know that this was a mistake of me, not a RunUO-bug - even though it seems that no one cared anyway

Phantom · 08-23-2005, 08:04 PM

So the order is wrong, or its right and you just didn't follow the code

Arahil · 08-24-2005, 09:12 AM

it's correct, but it is pretty tricky

Phenos · 09-23-2005, 10:24 AM

Anyway the region system has been completely rewritten for the next version.
The region serialization is no longer supported while the regions.xml capabilities have been greatly improved.

The order in which regions are loaded has been changed too

XxSP1DERxX · 09-23-2005, 12:18 PM

Thats not to say that you couldn't still have a single item in the world which has a custom region on it, and serialize its properties with it on world save, and then on world load, create the region back again, and deserialize its properties, and then just add it back with all the rest. I would assume that would work with the new system

Or you could go the XML route as well.

Phantom · 09-23-2005, 01:22 PM

Quote:

Originally Posted by Phenos

Anyway the region system has been completely rewritten for the next version.
The region serialization is no longer supported while the regions.xml capabilities have been greatly improved.

The order in which regions are loaded has been changed too

Reminds himself to smack Asayre, in order to get Phenos a moderator title...

Phenos · 09-24-2005, 05:58 AM

Quote:

Originally Posted by XxSP1DERxX

Thats not to say that you couldn't still have a single item in the world which has a custom region on it, and serialize its properties with it on world save, and then on world load, create the region back again, and deserialize its properties, and then just add it back with all the rest. I would assume that would work with the new system

Yes of course: that's in fact the recommended way to implement dynamic regions.

autumntwilight · 10-02-2005, 12:51 AM

Quote:

Originally Posted by Phantom

Reminds himself to smack Asayre, in order to get Phenos a moderator title...

I was about to say... Who is Phenos? How the hell does he know? I don't think it's fair if anyone not on the RunUO team gets to know before everyone else, but I can't stop it so hey what can I say?

Phantom · 10-02-2005, 12:57 AM

Quote:

Originally Posted by autumntwilight

I was about to say... Who is Phenos? How the hell does he know? I don't think it's fair if anyone not on the RunUO team gets to know before everyone else, but I can't stop it so hey what can I say?

He is on the RunUO Team, he has been for about 6 months, your just slow

08-20-2005, 09:09 AM	#1 (permalink)
Arahil Forum Novice Join Date: Oct 2003 Location: Vienna, Austria Age: 22 Posts: 127	Region Loading mistake When the world is loaded at server startup (the call to World.Load in ScriptsCompiler.cs), the regions are not loaded from the XML file. Region.Load is called in the MainLoop directly after the ScriptCompiler, but at this time the deserialization of the Regions is already finished. But since there are no regions known by the server before Region.Load is called, FindRegionByUId, which is called while reading saves/regions/regions.idx always returns null, which prevents any further loading. so to fix this problem the order of the actions has to be changed a little bit. Regions.Load should be called after the deserialisation of mobiles, items and guilds, and when the xml file is read regions can be deserialized. but since no region in the standard distro uses region serilization, this bug is not really critical

09-23-2005, 10:24 AM	#5 (permalink)
Phenos Join Date: Jan 2003 Posts: 134	Anyway the region system has been completely rewritten for the next version. The region serialization is no longer supported while the regions.xml capabilities have been greatly improved. The order in which regions are loaded has been changed too __________________ Phenos - Lorenzo Castelli E-Mail: gcastelli@racine.ra.it

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

08-23-2005, 07:54 PM	#2 (permalink)
Arahil Forum Novice Join Date: Oct 2003 Location: Vienna, Austria Age: 22 Posts: 127	I#m sorry, i overlooked one little thing: before Region.Load is called, the Initialize()-Methods of all the Scripts ar called, and there (in all the Subtypes of Region) are some Region-registration calls. Just wanted to let you know that this was a mistake of me, not a RunUO-bug - even though it seems that no one cared anyway

08-23-2005, 08:04 PM	#3 (permalink)
Phantom Account Terminated Join Date: Sep 2002 Age: 26 Posts: 3,846	So the order is wrong, or its right and you just didn't follow the code

08-24-2005, 09:12 AM	#4 (permalink)
Arahil Forum Novice Join Date: Oct 2003 Location: Vienna, Austria Age: 22 Posts: 127	it's correct, but it is pretty tricky

09-23-2005, 12:18 PM	#6 (permalink)
XxSP1DERxX Join Date: Oct 2002 Age: 23 Posts: 4,689	Thats not to say that you couldn't still have a single item in the world which has a custom region on it, and serialize its properties with it on world save, and then on world load, create the region back again, and deserialize its properties, and then just add it back with all the rest. I would assume that would work with the new system Or you could go the XML route as well.

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)