RunUO Community
This is a sample guest message. Register a free account today to become a member! Once signed in, you'll be able to participate on this site by adding your own topics and posts, as well as connect with other members through your own private inbox!
[RunUO 2.0 RC1] Player Government System Version 2
- Thread starter Avelyn
- Start date
Tru;712741 said:
Each time a player tries to purchase an already placed home within the city limits, just double clicking the sign crashes the shard. The crash report is from that. I still have to test if the shard crashes outside the city limits.
This never happened until I installed the player govt script today. I so want to use this, my players are so excited about the possiblities this will give them.
I wish we could associate the stone with static houseing using townhouse script, but I am not that good at scripts yet. I digress lol
Edited to add: without any cities set up, the shard does not crash when dbl clking the townhouse sign. As soon as I set up a town region using the deed, my player dbl clked the townhouse sign within the city limits, and the shard crashed.
Tru
Knight
madron;712752 said:
Can you run your shard in debug mode and crash it again then post that crash log....as it stands its not the player government system crashing its the Town House system. Debug info may help pin down the cause.
*After Thought* Did you change BaseHouse for both systems? If so the problem may be there.
I did not use the patches for the townhouses, so no mods were done for basehouse regarding the townhouse system.
I got on my own player account, not my GM staff/player, we use a stone to go back and forth. I was able to buy the home, and then set up the city hall without crashing the shard. I have not tested if another player can come along and buy a home yet...I will do this tomorrow.
I will run this in debug and get my player to help me recreate this again. But it will not be until tomorrow, as its getting late for me here. Tru, thank you for taking the time to help me out here, it is appreciated.
I will post more tomorrow, thank you again.
I am posting my basehouse for you to look at, perhaps I have overlooked something. I am also using SVN 237, and what a difference an upgraded SVN makes.
basehouse:
Thanks again Tru
I got on my own player account, not my GM staff/player, we use a stone to go back and forth. I was able to buy the home, and then set up the city hall without crashing the shard. I have not tested if another player can come along and buy a home yet...I will do this tomorrow.
I will run this in debug and get my player to help me recreate this again. But it will not be until tomorrow, as its getting late for me here. Tru, thank you for taking the time to help me out here, it is appreciated.
I will post more tomorrow, thank you again.
I am posting my basehouse for you to look at, perhaps I have overlooked something. I am also using SVN 237, and what a difference an upgraded SVN makes.
basehouse:
Thanks again Tru
Tru I figured this out and I am posting for others in case they run into this issue.
My issue was with City Limits, the house was within the city limits, and it was static. I had this for my first level 50; // 200x200 Area, however it did not like that, as soon as I realized my error and changed the line to 100;// 200x200 players were able to purchase static houing using townhouse script and be joined ont he stone without any crashes or errors. This was a tough one as it was pointing to townhouse script, but was in fact my own math calculations...
*note..never do math on 4 hours of sleep at 10 pm int he evening**
*smiles from ear to ear*
thank you for your help Tru, your always a great help to me
My issue was with City Limits, the house was within the city limits, and it was static. I had this for my first level 50; // 200x200 Area, however it did not like that, as soon as I realized my error and changed the line to 100;// 200x200 players were able to purchase static houing using townhouse script and be joined ont he stone without any crashes or errors. This was a tough one as it was pointing to townhouse script, but was in fact my own math calculations...
*note..never do math on 4 hours of sleep at 10 pm int he evening***smiles from ear to ear*
thank you for your help Tru, your always a great help to me
EvilPounder
Wanderer
this is the error that i get... anyone know how to fix it?
this is my PlayerGovernmentSystem.cs script
Code:
Errors:
+ Custom Scripts/Misc/Player Government System 2[1].21/Government System/PlayerGovernmentSystem.cs:
CS1502: Line 280: The best overloaded method match for 'System.Collections.Generic.List<Server.Multis.BaseHouse>.AddRange(Sy
stem.Collections.Generic.IEnumerable<Server.Multis.BaseHouse>)' has some invalid arguments
CS1503: Line 280: Argument '1': cannot convert from 'System.Collections.ArrayList' to 'System.Collections.Generic.IEnumerabl
e<Server.Multis.BaseHouse>'
CS0029: Line 292: Cannot implicitly convert type 'System.Collections.ArrayList' to 'System.Collections.Generic.List<Server.M
ultis.BaseHouse>'this is my PlayerGovernmentSystem.cs script
Code:
using System;
using Server;
using Server.Items;
using Server.Gumps;
using Server.Multis;
using Server.Mobiles;
using Server.Regions;
using Server.Accounting;
using System.Collections;
using System.Collections.Generic;
using System.Xml;
using System.IO;
using System.Globalization;
namespace Server
{
public class PlayerGovernmentSystem
{
//System Version
public static readonly string SystemVersion = "2.21";
public static string FileName = "Data/GovernmentVersion.xml";
public static string FileVersion = "0.0";
//Forensics Requirement
public static bool NeedsForensics = false;
public static double ForensicsRequirement = 35.0;
// Global Start Timer
public static readonly TimeSpan StartUpdate = TimeSpan.FromHours( 24.0 ); // Default 1140 = 24 hours
// City Update Time
public static readonly TimeSpan CityUpdate = TimeSpan.FromDays( 1.0 ); // Default 10080 = 7 days
// Mayor Voting Time
public static readonly TimeSpan VoteUpdate = TimeSpan.FromDays( 120.0 ); // Default 20160 = 14 Days
// Staring Treasury Amount RECOMMENDED: At least 20k so if player forgets to add, and dont lose on first update.
public static int TreasuryAmount = 20000; // Default 20000
// Level 1 City Limit Offset // See Docs On How To Set this.
public static int L1CLOffset = 25; // 50x50 Area
// Level 2 City Limit Offset // See Docs On How To Set this.
public static int L2CLOffset = 38; // 75x75 Area (Is really 76x76)
// Level 3 City Limit Offset // See Docs On How To Set this.
public static int L3CLOffset = 50; // 100x100 Area
// Level 4 City Limit Offset // See Docs On How To Set this.
public static int L4CLOffset = 75; // 150x150 Area
// Level 5 City Limit Offset // See Docs On How To Set this.
public static int L5CLOffset = 88; // 175x175 Area (Is really 176x176)
// Level 6 City Limit Offset // See Docs On How To Set this.
public static int L6CLOffset = 100; // 200x200 Area
// Set the amount of tiles the system checks for cities in range. // See Docs On How To Set This.
public static int CityRangeOffset = 100; // 200x200 Area
// Number of Max Lockdowns per City, Per Level
public static int Level1LD = 10; // Default 10
public static int Level2LD = 50; // Default 50
public static int Level3LD = 100; // Default 100
public static int Level4LD = 200; // Default 200
public static int Level5LD = 300; // Default 300
public static int Level6LD = 500; // Default 500
// Number of citizens needed for each city level.
public static int Level1 = 12; // Default 20 12
public static int Level2 = 20; // Default 40 20
public static int Level3 = 35; // Default 60 35
public static int Level4 = 45; // Default 80 45
public static int Level5 = 50; // Default 100 50
public static int Level6 = 56; // Default 200 55
/*
* Member Rules
*
* As long as a member has a house withing the city limits they can bacome an member of the city.
* Member cannot be a member of another city. Unless multi houses per account is enabled.
* However the same member cannot be a member of 2 differant cities.
* A member can join as many charactors to the city from thier account as they wish.
* Each charactor from the members account counts as a member to the citys total population.
* So in theory one account counts as 6 members to the city. (If 6 chars are enabled.) & if all are joined.
*/
// Title for cities at each level.
public static string Title1 = "outpost";
public static string Title2 = "village";
public static string Title3 = "township";
public static string Title4 = "city";
public static string Title5 = "metropolis";
public static string Title6 = "empire";
// Enable city placement for Ilshenar (Note: need to let players place houses as well in ilsh.)
public static bool EnableIlshenar = false;
// Max amounts of cities per map.
public static int MaxCitiesForFelucca = 25;
public static int MaxCitiesForTrammel = 25;
public static int MaxCitiesForIlshenar = 0; //No Housing In Ilshenar.. However can be changed.
public static int MaxCitiesForMalas = 0;
public static int MaxCitiesForTokuno = 0;
//Max number of citizens per city
public static int MaxCitizensPerCity = 300;
//Max number of banned players NOTE: if 0 will disable city banning.
public static int MaxBannedPerCity = 50;
public static void Initialize()
{
CheckCitySystemVersion();
}
public static void PlaceCityHall( Mobile from, Point3D p, CityDeed deed )
{
if ( CheckPlacement( from, p, deed.MultiID, deed.Offset ) )
{
if ( !CheckCitiesInRange( from, p ) )
{
deed.FinishPlacement( from, p );
from.SendGump( new CityWarningGump() );
}
else
{
int offset = CityRangeOffset * 2;
from.SendMessage( "Another city is to close to place your city hall here." );
from.SendMessage( 38, "You must be at least {0} yards (Steps) away from any other city in order to place your city hall.", offset );
}
}
}
public static void PlaceCivic( Mobile from, Point3D p, CityDeed deed )
{
if ( CheckPlacement( from, p, deed.MultiID, deed.Offset ) )
{
deed.FinishPlacement( from, p );
}
}
public static bool CheckPlacement( Mobile from, Point3D p, int multiId, Point3D offset )
{
ArrayList toMove;
Point3D center = new Point3D( p.X - offset.X, p.Y - offset.Y, p.Z - offset.Z );
HousePlacementResult res = HousePlacement.Check( from, multiId, center, out toMove );
if ( res == HousePlacementResult.Valid )
{
return true;
}
else if ( res == HousePlacementResult.BadItem || res == HousePlacementResult.BadLand || res == HousePlacementResult.BadStatic || res == HousePlacementResult.BadRegionHidden )
{
from.SendLocalizedMessage( 1043287 ); // The house could not be created here. Either something is blocking the house, or the house would not be on valid terrain.
return false;
}
else if ( res == HousePlacementResult.NoSurface )
{
from.SendMessage( "The house could not be created here. Part of the foundation would not be on any surface." );
return false;
}
else if ( res == HousePlacementResult.BadRegion )
{
from.SendLocalizedMessage( 501265 ); // Housing cannot be created in this area.
return false;
}
else
{
return false;
}
}
public static bool CheckIfInIlsh( Mobile from )
{
if ( from.Map == Map.Ilshenar && EnableIlshenar == false )
return true;
return false;
}
public static bool CheckIfCanBeMayor( Mobile from )
{
if ( NeedsForensics )
if ( from.Skills[SkillName.Forensics].Base >= 35.0 )
return true;
else return false;
else
return true;
}
public static bool CheckCitiesInRange( Mobile from, Point3D p )
{
// Very Speical Thanks To ArteGordon For His Help On This Bool
Map map = from.Map;
int offset = CityRangeOffset;
int offset2 = offset * 3;
int x1 = p.X - offset;
int y1 = p.Y - offset;
int width = offset2;
int height = offset2;
int depth = p.Z;
for( int x = x1; x <= x1 + width; x += Map.SectorSize )
{
for( int y = y1; y <= y1 + height; y += Map.SectorSize )
{
Sector s = map.GetSector( new Point3D( x, y, depth ) );
foreach ( RegionRect rect in s.RegionRects )
{
Region r = rect.Region;
if ( r is GuardedRegion || r is PlayerCityRegion )
return true;
}
}
}
return false;
}
public static bool CheckIfMayor( Mobile from )
{
foreach ( Item item in World.Items.Values )
{
if ( item is CityManagementStone )
{
CityManagementStone stone = (CityManagementStone)item;
if ( stone.Mayor == from )
return true;
}
}
return false;
}
public static bool CheckIfCitizen( Mobile from )
{
foreach ( Item item in World.Items.Values )
{
if ( item is CityManagementStone )
{
CityManagementStone stone = (CityManagementStone)item;
foreach ( Mobile m in stone.Citizens )
{
if ( from == m )
return true;
}
}
}
return false;
}
public static List<BaseHouse> GetAllHouses( Mobile m ) // thanks to bripbrip
{
List<BaseHouse> allHouses = new List<BaseHouse>();
Account a = m.Account as Account;
if ( a == null )
return allHouses;
for ( int i = 0; i < a.Length; ++i )
{
Mobile mob = a[i];
if ( mob != null )
allHouses.AddRange( BaseHouse.GetHouses( mob ) );
}
return allHouses;
}
public static bool CheckIfHouseInCity( Mobile from, Region region )
{
if ( from == null )
return false;
if ( region == null )
return false;
List<BaseHouse> list = BaseHouse.GetHouses( from );
if ( list != null )
{
for ( int i = 0; i < list.Count; i++ )
{
BaseHouse h = list[i];
if ( h != null )
{
int X = h.Sign.X;
int Y = h.Sign.Y + 1;
int Z = h.Sign.Z;
Point3D hsp = new Point3D( X, Y, Z );
Map hsm = h.Sign.Map;
Region reg = Region.Find( hsp, hsm );
if( reg == region )
return true;
else if ( list.Count > 1 && i < (list.Count - 1) )
continue;
else
{
return false;
}
}
}
}
foreach ( BaseHouse h in GetAllHouses( from ) )
{
if ( h != null )
{
int X = h.Sign.X;
int Y = h.Sign.Y + 1;
int Z = h.Sign.Z;
Point3D hsp = new Point3D( X, Y, Z );
Map hsm = h.Sign.Map;
Region reg = Region.Find( hsp, hsm );
if ( reg == region )
{
Mobile owner = h.Owner;
Account acct = (Account)from.Account;
Account acct2 = (Account)owner.Account;
if ( acct == null || acct2 == null )
return false;
else if ( acct == acct2 )
return true;
else
continue;
}
else
continue;
}
else
{
return false;
}
}
return false;
}
public static bool CheckMapCityLimit( Mobile from )
{
ArrayList count = new ArrayList();
foreach ( Item item in World.Items.Values )
{
if ( item is CityManagementStone )
{
if ( item.Map == from.Map )
count.Add( item );
}
}
if ( from.Map == Map.Felucca )
{
if ( count.Count >= MaxCitiesForFelucca )
return true;
}
else if ( from.Map == Map.Trammel )
{
if ( count.Count >= MaxCitiesForTrammel )
return true;
}
else if ( from.Map == Map.Ilshenar )
{
if ( count.Count >= MaxCitiesForIlshenar )
return true;
}
else if ( from.Map == Map.Malas )
{
if ( count.Count >= MaxCitiesForMalas )
return true;
}
else if ( from.Map == Map.Tokuno )
{
if ( count.Count >= MaxCitiesForTokuno )
return true;
}
else
{
return true;
}
return false;
}
public static bool CheckCityName( string text )
{
foreach ( Item item in World.Items.Values )
{
if ( item is CityManagementStone )
{
CityManagementStone stone = (CityManagementStone)item;
if ( stone.CityName == text )
return true;
}
}
return false;
}
public static bool CheckIfBanned( Mobile from, Mobile target )
{
if ( from is PlayerMobile && target is PlayerMobile )
{
if ( target.Region is PlayerCityRegion && from.Region is PlayerCityRegion )
{
PlayerMobile pm = (PlayerMobile)from;
CityManagementStone stone = pm.City;
if ( stone != null )
{
if ( stone.PCRegion == target.Region )
{
bool isBanned = false;
bool isMember = false;
foreach ( Mobile checkBan in stone.Banned )
{
if ( target == checkBan )
isBanned = true;
}
foreach ( Mobile checkMem in stone.Citizens )
{
if ( from == checkMem )
isMember = true;
}
if ( isBanned == true && isMember == true )
return true;
}
}
}
}
return false;
}
public static bool CheckBanLootable( Mobile from, Mobile target )
{
if ( from is PlayerMobile && target is PlayerMobile )
{
if ( from.Region is PlayerCityRegion )
{
PlayerMobile pm = (PlayerMobile)from;
CityManagementStone stone = pm.City;
if ( stone != null )
{
bool isBanned = false;
foreach ( Mobile checkBan in stone.Banned )
{
if ( target == checkBan )
isBanned = true;
}
if ( isBanned == true )
return true;
}
}
}
return false;
}
public static bool CheckAtWarWith( Mobile from, Mobile target )
{
if ( from is PlayerMobile && target is PlayerMobile )
{
PlayerMobile pm1 = (PlayerMobile)from;
PlayerMobile pm2 = (PlayerMobile)target;
CityManagementStone fromCity = pm1.City;
CityManagementStone targCity = pm2.City;
if ( fromCity != null && targCity != null )
{
if ( fromCity.Waring.Contains( targCity ) )
return true;
}
}
return false;
}
public static bool CheckCityAlly( Mobile from, Mobile target )
{
if ( from is PlayerMobile && target is PlayerMobile )
{
PlayerMobile pm1 = (PlayerMobile)from;
PlayerMobile pm2 = (PlayerMobile)target;
CityManagementStone fromCity = pm1.City;
CityManagementStone targCity = pm2.City;
if ( fromCity != null )
{
if ( fromCity.Citizens.Contains( target ) )
return true;
if ( fromCity.Allegiances.Contains( targCity ) )
return true;
}
}
return false;
}
public static bool IsCityLevelReached( Mobile from, int level )
{
PlayerMobile pm = (PlayerMobile)from;
if ( pm.City.Mayor == from )
{
if ( pm.City.Level >= level )
return true;
}
return false;
}
public static bool IsAtCity( Mobile from, Mobile to )
{
PlayerMobile pm = (PlayerMobile)from;
CityManagementStone city = pm.City;
Region cityreg = Region.Find( from.Location, from.Map );
Region targregion = Region.Find( to.Location, to.Map );
if ( city != null && cityreg != null && targregion != null )
{
if ( ( cityreg == city.PCRegion ) && ( cityreg == targregion ) )
return true;
}
return false;
}
public static bool IsAtCity( Mobile from )
{
PlayerMobile pm = (PlayerMobile)from;
CityManagementStone city = pm.City;
Region cityreg = Region.Find( from.Location, from.Map );
if ( cityreg != null && city != null )
{
if ( cityreg == city.PCRegion )
return true;
}
return false;
}
public static bool IsAtCity( Item item )
{
Region reg = Region.Find( item.Location, item.Map );
if ( reg != null )
{
if ( reg is PlayerCityRegion )
return true;
else
return false;
}
return false;
}
public static bool IsMemberOf( Mobile from, CityManagementStone stone )
{
PlayerMobile pm = (PlayerMobile)from;
if ( pm.City == null )
return false;
foreach ( Mobile mob in stone.Citizens )
{
if ( mob == from )
{
return true;
break;
}
}
return false;
}
public static Rectangle3D[] FormatRegion( Rectangle2D box )
{
Rectangle3D area = Server.Region.ConvertTo3D( box );
List<Rectangle3D> arealist = new List<Rectangle3D>();
arealist.Add( area );
Rectangle3D[] regarea = arealist.ToArray();
return regarea;
}
public static bool IsIteminCity( Mobile from, Item item )
{
PlayerMobile pm = (PlayerMobile)from;
if ( pm.City == null )
return false;
else
{
CityManagementStone stone = pm.City;
Point3D p = new Point3D( item.X, item.Y, item.Z );
Region target = Region.Find( p, item.Map );
if ( stone.PCRegion == target )
return true;
else
return false;
}
}
public static bool AreThereVendors( Mobile from )
{
if ( from == null )
return false;
foreach ( BaseHouse h in BaseHouse.GetHouses( from ) )
{
if ( h != null )
{
if ( h.HasPersonalVendors || h.HasRentedVendors )
return true;
else
return false;
}
}
return false;
}
public static void CheckCitySystemVersion()
{
bool SystemUpgrade = false;
if ( !File.Exists( FileName ) )
SystemUpgrade = true;
else
{
try
{
XmlDocument xml = new XmlDocument();
xml.Load( FileName );
XmlElement system = xml["Version"];
FileVersion = system.InnerText;
if ( FileVersion == "0.0" )
{
Console.WriteLine( "Government System: Error Loading Version Variable!" );
return;
}
if ( FileVersion != SystemVersion )
SystemUpgrade = true;
}
catch
{
Console.WriteLine( "Error Reading City Version File!" );
return;
}
}
if ( SystemUpgrade )
Console.WriteLine( "The city system needs to be upgraded, please run the [upgradecitysystem command!" );
else
Console.WriteLine( "City system current. Version {0}", SystemVersion );
}
}
}EvilPounder
Wanderer
i looked for it but couldnt find anything on that error =/
Errors:
+ Government System/PlayerGovernmentSystem.cs:
CS1502: Line 281: The best overloaded method match for 'System.Col
List<Server.Multis.BaseHouse>.AddRange(System.Collections.Generic.IEnu
ltis.BaseHouse>)' has some invalid arguments
CS1503: Line 281: Argument '1': cannot convert from 'System.Collec
to 'System.Collections.Generic.IEnumerable<Server.Multis.BaseHouse>'
whats the problem?
+ Government System/PlayerGovernmentSystem.cs:
CS1502: Line 281: The best overloaded method match for 'System.Col
List<Server.Multis.BaseHouse>.AddRange(System.Collections.Generic.IEnu
ltis.BaseHouse>)' has some invalid arguments
CS1503: Line 281: Argument '1': cannot convert from 'System.Collec
to 'System.Collections.Generic.IEnumerable<Server.Multis.BaseHouse>'
Code:
//added - improved house check
public static List<BaseHouse> GetAllHouses(Mobile m)
{
List<BaseHouse> allHouses = new List<BaseHouse>();
Account a = m.Account as Account;
if ( a == null )
return allHouses;
for ( int i = 0; i < a.Length; ++i )
{
Mobile mob = a[i];
if ( mob != null )
allHouses.AddRange( BaseHouse.GetHouses( mob ) );
}
return allHouses;
}
//end added
//this method was modified
public static bool CheckIfHouseInCity( Mobile from, Region region )
{
if ( from == null )
return false;
if ( region == null )
return false;
foreach ( BaseHouse h in GetAllHouses( from ) )
{
if ( h != null )
{
int X = h.Sign.X;
int Y = h.Sign.Y + 1;
int Z = h.Sign.Z;
Point3D hsp = new Point3D( X, Y, Z );
Map hsm = h.Sign.Map;
Region reg = Region.Find( hsp, hsm );
if( reg == region )
return true;
else
continue; //was return false
}
}
return false;
/*
foreach ( Item item in World.Items.Values )
{
if ( item is HouseSign )
{
HouseSign hs = (HouseSign)item;
Mobile owner = hs.Owner.Owner;
if ( owner == null )
continue; //was return false
int X = hs.X;
int Y = hs.Y + 1;
int Z = hs.Z;
Point3D hsp = new Point3D( X, Y, Z );
Map hsm = hs.Map;
Region reg = Region.Find( hsp, hsm );
Account acct = (Account)from.Account;
Account acct2 = (Account)owner.Account;
if ( acct == null || acct2 == null || reg == null )
continue; //was return false
if ( reg == region && acct == acct2 )
return true;
}
}
return false;*/
}whats the problem?
The script is trying to fill a generic basehouse list with object members. Runuo 2.0 RC1 uses arraylist whereas this script uses generic lists.
I changed the following in PlayerGovernmentSystem.cs
to
And it works fine for me
I changed the following in PlayerGovernmentSystem.cs
Code:
public static List<BaseHouse> GetAllHouses( Mobile m ) // thanks to bripbrip
{
List<BaseHouse> allHouses = new List<BaseHouse>();
Account a = m.Account as Account;
if ( a == null )
return allHouses;
for ( int i = 0; i < a.Length; ++i )
{
Mobile mob = a[i];
if ( mob != null )
allHouses.AddRange( BaseHouse.GetHouses( mob ) );
}
return allHouses;
}
public static bool CheckIfHouseInCity( Mobile from, Region region )
{
if ( from == null )
return false;
if ( region == null )
return false;
List<BaseHouse> list = BaseHouse.GetHouses( from );
if ( list != null )
{
for ( int i = 0; i < list.Count; i++ )
{
BaseHouse h = list[i];
if ( h != null )
{
int X = h.Sign.X;
int Y = h.Sign.Y + 1;
int Z = h.Sign.Z;
Point3D hsp = new Point3D( X, Y, Z );
Map hsm = h.Sign.Map;
Region reg = Region.Find( hsp, hsm );
if( reg == region )
return true;
else if ( list.Count > 1 && i < (list.Count - 1) )
continue;
else
{
return false;
}
}
}
}
foreach ( BaseHouse h in GetAllHouses( from ) )
{
if ( h != null )
{
int X = h.Sign.X;
int Y = h.Sign.Y + 1;
int Z = h.Sign.Z;
Point3D hsp = new Point3D( X, Y, Z );
Map hsm = h.Sign.Map;
Region reg = Region.Find( hsp, hsm );
if ( reg == region )
{
Mobile owner = h.Owner;
Account acct = (Account)from.Account;
Account acct2 = (Account)owner.Account;
if ( acct == null || acct2 == null )
return false;
else if ( acct == acct2 )
return true;
else
continue;
}
else
continue;
}
else
{
return false;
}
}
return false;
}to
Code:
public static ArrayList GetAllHouses( Mobile m ) // thanks to bripbrip
{
ArrayList allHouses = new ArrayList();
Account a = m.Account as Account;
if ( a == null )
return allHouses;
for ( int i = 0; i < a.Length; ++i )
{
Mobile mob = a[i];
if ( mob != null )
allHouses.AddRange( BaseHouse.GetHouses( mob ) );
}
return allHouses;
}
public static bool CheckIfHouseInCity( Mobile from, Region region )
{
if ( from == null )
return false;
if ( region == null )
return false;
ArrayList list = BaseHouse.GetHouses(from);
if ( list != null )
{
for ( int i = 0; i < list.Count; i++ )
{
BaseHouse h = (BaseHouse)list[i];
if ( h != null )
{
int X = h.Sign.X;
int Y = h.Sign.Y + 1;
int Z = h.Sign.Z;
Point3D hsp = new Point3D( X, Y, Z );
Map hsm = h.Sign.Map;
Region reg = Region.Find( hsp, hsm );
if( reg == region )
return true;
else if ( list.Count > 1 && i < (list.Count - 1) )
continue;
else
{
return false;
}
}
}
}
foreach ( BaseHouse h in GetAllHouses( from ) )
{
if ( h != null )
{
int X = h.Sign.X;
int Y = h.Sign.Y + 1;
int Z = h.Sign.Z;
Point3D hsp = new Point3D( X, Y, Z );
Map hsm = h.Sign.Map;
Region reg = Region.Find( hsp, hsm );
if ( reg == region )
{
Mobile owner = h.Owner;
Account acct = (Account)from.Account;
Account acct2 = (Account)owner.Account;
if ( acct == null || acct2 == null )
return false;
else if ( acct == acct2 )
return true;
else
continue;
}
else
continue;
}
else
{
return false;
}
}
return false;
}And it works fine for me
ThalmagusPL
Wanderer
I have one problem..
Anybody help?
PublicMoongate.cs
Anybody help?
PublicMoongate.cs
Code:
CS0246: Line 413: The type or namespace name 'ArrayList' could not found <are you missing a using directive or an assembly reference??>ThalmagusPL
Wanderer
Yea i using svn282.
Please help
This is my PublicMoongate.cs
Please help
This is my PublicMoongate.cs
Code:
using System;
using System.Collections.Generic;
using Server;
using Server.Commands;
using Server.Gumps;
using Server.Mobiles;
using Server.Network;
using Server.Spells;
using Server.Regions;
namespace Server.Items
{
public class PublicMoongate : Item
{
public override bool ForceShowProperties{ get{ return ObjectPropertyList.Enabled; } }
[Constructable]
public PublicMoongate() : base( 0xF6C )
{
Movable = false;
Light = LightType.Circle300;
}
public PublicMoongate( Serial serial ) : base( serial )
{
}
public override void OnDoubleClick( Mobile from )
{
if ( !from.Player )
return;
if ( from.InRange( GetWorldLocation(), 1 ) )
UseGate( from );
else
from.SendLocalizedMessage( 500446 ); // That is too far away.
}
public override bool OnMoveOver( Mobile m )
{
// Changed so criminals are not blocked by it.
if ( m.Player )
UseGate( m );
return true;
}
public override bool HandlesOnMovement{ get{ return true; } }
public override void OnMovement( Mobile m, Point3D oldLocation )
{
if ( m is PlayerMobile )
{
if ( !Utility.InRange( m.Location, this.Location, 1 ) && Utility.InRange( oldLocation, this.Location, 1 ) )
m.CloseGump( typeof( MoongateGump ) );
}
}
public bool UseGate( Mobile m )
{
if ( m.Criminal )
{
m.SendLocalizedMessage( 1005561, "", 0x22 ); // Thou'rt a criminal and cannot escape so easily.
return false;
}
else if ( SpellHelper.CheckCombat( m ) )
{
m.SendLocalizedMessage( 1005564, "", 0x22 ); // Wouldst thou flee during the heat of battle??
return false;
}
else if ( m.Spell != null )
{
m.SendLocalizedMessage( 1049616 ); // You are too busy to do that at the moment.
return false;
}
else
{
m.CloseGump( typeof( MoongateGump ) );
m.SendGump( new MoongateGump( m, this ) );
if ( !m.Hidden || m.AccessLevel == AccessLevel.Player )
Effects.PlaySound( m.Location, m.Map, 0x20E );
return true;
}
}
public override void Serialize( GenericWriter writer )
{
base.Serialize( writer );
writer.Write( (int) 0 ); // version
}
public override void Deserialize( GenericReader reader )
{
base.Deserialize( reader );
int version = reader.ReadInt();
}
public static void Initialize()
{
CommandSystem.Register( "MoonGen", AccessLevel.Administrator, new CommandEventHandler( MoonGen_OnCommand ) );
}
[Usage( "MoonGen" )]
[Description( "Generates public moongates. Removes all old moongates." )]
public static void MoonGen_OnCommand( CommandEventArgs e )
{
DeleteAll();
int count = 0;
count += MoonGen( PMList.Trammel );
count += MoonGen( PMList.Felucca );
count += MoonGen( PMList.Ilshenar );
count += MoonGen( PMList.Malas );
count += MoonGen( PMList.Tokuno );
World.Broadcast( 0x35, true, "{0} moongates generated.", count );
}
private static void DeleteAll()
{
List<Item> list = new List<Item>();
foreach ( Item item in World.Items.Values )
{
if ( item is PublicMoongate )
list.Add( item );
}
foreach ( Item item in list )
item.Delete();
if ( list.Count > 0 )
World.Broadcast( 0x35, true, "{0} moongates removed.", list.Count );
}
private static int MoonGen( PMList list )
{
foreach ( PMEntry entry in list.Entries )
{
Item item = new PublicMoongate();
item.MoveToWorld( entry.Location, list.Map );
if ( entry.Number == 1060642 ) // Umbra
item.Hue = 0x497;
}
return list.Entries.Length;
}
}
public class PMEntry
{
private Point3D m_Location;
private int m_Number;
public Point3D Location
{
get
{
return m_Location;
}
}
public int Number
{
get
{
return m_Number;
}
}
public PMEntry( Point3D loc, int number )
{
m_Location = loc;
m_Number = number;
}
}
public class PMList
{
private int m_Number, m_SelNumber;
private Map m_Map;
private PMEntry[] m_Entries;
public int Number
{
get
{
return m_Number;
}
}
public int SelNumber
{
get
{
return m_SelNumber;
}
}
public Map Map
{
get
{
return m_Map;
}
}
public PMEntry[] Entries
{
get
{
return m_Entries;
}
}
public PMList( int number, int selNumber, Map map, PMEntry[] entries )
{
m_Number = number;
m_SelNumber = selNumber;
m_Map = map;
m_Entries = entries;
}
public static readonly PMList Trammel =
new PMList( 1012000, 1012012, Map.Trammel, new PMEntry[]
{
new PMEntry( new Point3D( 4467, 1283, 5 ), 1012003 ), // Moonglow
new PMEntry( new Point3D( 1336, 1997, 5 ), 1012004 ), // Britain
new PMEntry( new Point3D( 1499, 3771, 5 ), 1012005 ), // Jhelom
new PMEntry( new Point3D( 771, 752, 5 ), 1012006 ), // Yew
new PMEntry( new Point3D( 2701, 692, 5 ), 1012007 ), // Minoc
new PMEntry( new Point3D( 1828, 2948,-20), 1012008 ), // Trinsic
new PMEntry( new Point3D( 643, 2067, 5 ), 1012009 ), // Skara Brae
new PMEntry( new Point3D( 3563, 2139, 34), 1012010 ), // Magincia
new PMEntry( new Point3D( 3763, 2771, 50), 1078098 ) // New Haven
} );
public static readonly PMList Felucca =
new PMList( 1012001, 1012013, Map.Felucca, new PMEntry[]
{
new PMEntry( new Point3D( 4467, 1283, 5 ), 1012003 ), // Moonglow
new PMEntry( new Point3D( 1336, 1997, 5 ), 1012004 ), // Britain
new PMEntry( new Point3D( 1499, 3771, 5 ), 1012005 ), // Jhelom
new PMEntry( new Point3D( 771, 752, 5 ), 1012006 ), // Yew
new PMEntry( new Point3D( 2701, 692, 5 ), 1012007 ), // Minoc
new PMEntry( new Point3D( 1828, 2948,-20), 1012008 ), // Trinsic
new PMEntry( new Point3D( 643, 2067, 5 ), 1012009 ), // Skara Brae
new PMEntry( new Point3D( 3563, 2139, 34), 1012010 ), // Magincia
new PMEntry( new Point3D( 2711, 2234, 0 ), 1019001 ) // Buccaneer's Den
} );
public static readonly PMList Ilshenar =
new PMList( 1012002, 1012014, Map.Ilshenar, new PMEntry[]
{
new PMEntry( new Point3D( 1215, 467, -13 ), 1012015 ), // Compassion
new PMEntry( new Point3D( 722, 1366, -60 ), 1012016 ), // Honesty
new PMEntry( new Point3D( 744, 724, -28 ), 1012017 ), // Honor
new PMEntry( new Point3D( 281, 1016, 0 ), 1012018 ), // Humility
new PMEntry( new Point3D( 987, 1011, -32 ), 1012019 ), // Justice
new PMEntry( new Point3D( 1174, 1286, -30 ), 1012020 ), // Sacrifice
new PMEntry( new Point3D( 1532, 1340, - 3 ), 1012021 ), // Spirituality
new PMEntry( new Point3D( 528, 216, -45 ), 1012022 ), // Valor
new PMEntry( new Point3D( 1721, 218, 96 ), 1019000 ) // Chaos
} );
public static readonly PMList Malas =
new PMList( 1060643, 1062039, Map.Malas, new PMEntry[]
{
new PMEntry( new Point3D( 1015, 527, -65 ), 1060641 ), // Luna
new PMEntry( new Point3D( 1997, 1386, -85 ), 1060642 ) // Umbra
} );
public static readonly PMList Tokuno =
new PMList( 1063258, 1063415, Map.Tokuno, new PMEntry[]
{
new PMEntry( new Point3D( 1169, 998, 41 ), 1063412 ), // Isamu-Jima
new PMEntry( new Point3D( 802, 1204, 25 ), 1063413 ), // Makoto-Jima
new PMEntry( new Point3D( 270, 628, 15 ), 1063414 ) // Homare-Jima
} );
public static readonly PMList[] UORLists = new PMList[] { Trammel, Felucca };
public static readonly PMList[] UORListsYoung = new PMList[] { Trammel };
public static readonly PMList[] LBRLists = new PMList[] { Trammel, Felucca, Ilshenar };
public static readonly PMList[] LBRListsYoung = new PMList[] { Trammel, Ilshenar };
public static readonly PMList[] AOSLists = new PMList[] { Trammel, Felucca, Ilshenar, Malas };
public static readonly PMList[] AOSListsYoung = new PMList[] { Trammel, Ilshenar, Malas };
public static readonly PMList[] SELists = new PMList[] { Trammel, Felucca, Ilshenar, Malas, Tokuno };
public static readonly PMList[] SEListsYoung = new PMList[] { Trammel, Ilshenar, Malas, Tokuno };
public static readonly PMList[] RedLists = new PMList[] { Felucca };
public static readonly PMList[] SigilLists = new PMList[] { Felucca };
}
public class MoongateGump : Gump
{
private Mobile m_Mobile;
private Item m_Moongate;
private PMList[] m_Lists;
public MoongateGump( Mobile mobile, Item moongate ) : base( 100, 100 )
{
m_Mobile = mobile;
m_Moongate = moongate;
PMList[] checkLists;
if ( mobile.Player )
{
if ( Factions.Sigil.ExistsOn( mobile ) )
{
checkLists = PMList.SigilLists;
}
else if ( mobile.Kills >= 5 )
{
checkLists = PMList.RedLists;
}
else
{
int flags = mobile.NetState == null ? 0 : mobile.NetState.Flags;
bool young = mobile is PlayerMobile ? ((PlayerMobile)mobile).Young : false;
if ( Core.SE && (flags & 0x10) != 0 )
checkLists = young ? PMList.SEListsYoung : PMList.SELists;
else if ( Core.AOS && (flags & 0x8) != 0 )
checkLists = young ? PMList.AOSListsYoung : PMList.AOSLists;
else if ( (flags & 0x4) != 0 )
checkLists = young ? PMList.LBRListsYoung : PMList.LBRLists;
else
checkLists = young ? PMList.UORListsYoung : PMList.UORLists;
}
}
else
{
checkLists = PMList.SELists;
}
m_Lists = new PMList[checkLists.Length];
for ( int i = 0; i < m_Lists.Length; ++i )
m_Lists[i] = checkLists[i];
for ( int i = 0; i < m_Lists.Length; ++i )
{
if ( m_Lists[i].Map == mobile.Map )
{
PMList temp = m_Lists[i];
m_Lists[i] = m_Lists[0];
m_Lists[0] = temp;
break;
}
}
AddPage( 0 );
AddBackground( 0, 0, 380, 280, 5054 );
AddButton( 10, 185, 4005, 4007, 2, GumpButtonType.Reply, 0 );
AddHtml( 45, 185, 140, 25, @"Player City Menu", false, false );
AddButton( 10, 210, 4005, 4007, 1, GumpButtonType.Reply, 0 );
AddHtmlLocalized( 45, 210, 140, 25, 1011036, false, false ); // OKAY
AddButton( 10, 235, 4005, 4007, 0, GumpButtonType.Reply, 0 );
AddHtmlLocalized( 45, 235, 140, 25, 1011012, false, false ); // CANCEL
AddHtmlLocalized( 5, 5, 200, 20, 1012011, false, false ); // Pick your destination:
for ( int i = 0; i < checkLists.Length; ++i )
{
AddButton( 10, 35 + (i * 25), 2117, 2118, 0, GumpButtonType.Page, Array.IndexOf( m_Lists, checkLists[i] ) + 1 );
AddHtmlLocalized( 30, 35 + (i * 25), 150, 20, checkLists[i].Number, false, false );
}
for ( int i = 0; i < m_Lists.Length; ++i )
RenderPage( i, Array.IndexOf( checkLists, m_Lists[i] ) );
}
private void RenderPage( int index, int offset )
{
PMList list = m_Lists[index];
AddPage( index + 1 );
AddButton( 10, 35 + (offset * 25), 2117, 2118, 0, GumpButtonType.Page, index + 1 );
AddHtmlLocalized( 30, 35 + (offset * 25), 150, 20, list.SelNumber, false, false );
PMEntry[] entries = list.Entries;
for ( int i = 0; i < entries.Length; ++i )
{
AddRadio( 200, 35 + (i * 25), 210, 211, false, (index * 100) + i );
AddHtmlLocalized( 225, 35 + (i * 25), 150, 20, entries[i].Number, false, false );
}
}
public override void OnResponse( NetState state, RelayInfo info )
{
if ( info.ButtonID == 0 ) // Cancel
return;
else if ( m_Mobile.Deleted || m_Moongate.Deleted || m_Mobile.Map == null )
return;
if ( info.ButtonID == 2 )
{
ArrayList a = new ArrayList();
foreach ( Item i in World.Items.Values )
{
if ( i is CityManagementStone )
{
CityManagementStone s = (CityManagementStone)i;
if ( s.HasMoongate == true && s.IsRegistered == true )
a.Add( i );
}
}
if ( a.Count == 0 )
{
m_Mobile.SendGump( new NoCitiesGump() );
}
else
{
m_Mobile.SendGump( new PCMoongateGump( m_Moongate, 0, null, null ) );
}
}
int[] switches = info.Switches;
if ( switches.Length == 0 )
return;
int switchID = switches[0];
int listIndex = switchID / 100;
int listEntry = switchID % 100;
if ( listIndex < 0 || listIndex >= m_Lists.Length )
return;
PMList list = m_Lists[listIndex];
if ( listEntry < 0 || listEntry >= list.Entries.Length )
return;
PMEntry entry = list.Entries[listEntry];
if ( !m_Mobile.InRange( m_Moongate.GetWorldLocation(), 1 ) || m_Mobile.Map != m_Moongate.Map )
{
m_Mobile.SendLocalizedMessage( 1019002 ); // You are too far away to use the gate.
}
else if ( m_Mobile.Player && m_Mobile.Kills >= 5 && list.Map != Map.Felucca )
{
m_Mobile.SendLocalizedMessage( 1019004 ); // You are not allowed to travel there.
}
else if ( Factions.Sigil.ExistsOn( m_Mobile ) && list.Map != Factions.Faction.Facet )
{
m_Mobile.SendLocalizedMessage( 1019004 ); // You are not allowed to travel there.
}
else if ( m_Mobile.Criminal )
{
m_Mobile.SendLocalizedMessage( 1005561, "", 0x22 ); // Thou'rt a criminal and cannot escape so easily.
}
else if ( SpellHelper.CheckCombat( m_Mobile ) )
{
m_Mobile.SendLocalizedMessage( 1005564, "", 0x22 ); // Wouldst thou flee during the heat of battle??
}
else if ( m_Mobile.Spell != null )
{
m_Mobile.SendLocalizedMessage( 1049616 ); // You are too busy to do that at the moment.
}
else if ( m_Mobile.Map == list.Map && m_Mobile.InRange( entry.Location, 1 ) )
{
m_Mobile.SendLocalizedMessage( 1019003 ); // You are already there.
}
else
{
CityManagementStone outgoingCity = null;
Region currentRegion = Region.Find( m_Mobile.Location, m_Mobile.Map );
if ( currentRegion != null )
{
if ( currentRegion is PlayerCityRegion )
{
PlayerCityRegion pcr = (PlayerCityRegion)currentRegion;
outgoingCity = pcr.Stone;
}
}
if ( outgoingCity != null && outgoingCity.TravelTax >= 1 )
{
m_Mobile.SendGump( new PCMoongateToll2Gump( m_Moongate, outgoingCity, entry.Location, list.Map ) );
}
else
{
BaseCreature.TeleportPets( m_Mobile, entry.Location, list.Map );
m_Mobile.Combatant = null;
m_Mobile.Warmode = false;
m_Mobile.Hidden = true;
m_Mobile.MoveToWorld( entry.Location, list.Map );
Effects.PlaySound( entry.Location, list.Map, 0x1FE );
}
}
}
}
}ThalmagusPL
Wanderer
I Dont know how change, please help.
Great system, but we're having problems after the mayor of one town deleted his characters. Every time the city updates, the shard will crash. Tried setting the mayor manually in [props but no go.
Also tried to recreate this on my test shard by deleting a mayor character but wasn't able to get it to crash, any suggestions?
Also tried to recreate this on my test shard by deleting a mayor character but wasn't able to get it to crash, any suggestions?
Code:
Server Crash Report
===================
RunUO Version 2.0, Build 2727.20904
Operating System: Microsoft Windows NT 5.1.2600 Service Pack 2
.NET Framework: 2.0.50727.42
Time: 3/22/2008 8:21:30 AM
Mobiles: 117128
Items: 655078
Exception:
System.NullReferenceException: Object reference not set to an instance of an object.
at Server.Items.CityManagementStone.DoUpdate() in c:\Documents and Settings\user\Desktop\Arc update\Arc update\Scripts\Custom\Systems\Player Government System\Items\Stones\CityManagementStone.cs:line 1166
at Server.Items.CityManagementStone.CityUpdateTimer.OnTick() in c:\Documents and Settings\user\Desktop\Arc update\Arc update\Scripts\Custom\Systems\Player Government System\Items\Stones\CityManagementStone.cs:line 1601
at Server.Timer.Slice() in C:\Documents and Settings\owner\Local Settings\Application Data\Temporary Projects\Runuo Arc update\Server\Timer.cs:line 400
at Server.Core.Main(String[] args) in C:\Documents and Settings\owner\Local Settings\Application Data\Temporary Projects\Runuo Arc update\Server\Main.cs:line 458
Code:
Server Crash Report
===================
RunUO Version 2.0, Build 2727.20904
Operating System: Microsoft Windows NT 5.1.2600 Service Pack 2
.NET Framework: 2.0.50727.42
Time: 3/22/2008 5:14:16 AM
Mobiles: 117446
Items: 661208
Exception:
System.NullReferenceException: Object reference not set to an instance of an object.
at Server.Items.CityManagementStone.DeadMayor() in c:\Documents and Settings\user\Desktop\Arc update\Arc update\Scripts\Custom\Systems\Player Government System\Items\Stones\CityManagementStone.cs:line 713
at Server.Items.CityManagementStone.DoUpdate() in c:\Documents and Settings\user\Desktop\Arc update\Arc update\Scripts\Custom\Systems\Player Government System\Items\Stones\CityManagementStone.cs:line 955
at Server.Items.CityManagementStone.CityUpdateTimer.OnTick() in c:\Documents and Settings\user\Desktop\Arc update\Arc update\Scripts\Custom\Systems\Player Government System\Items\Stones\CityManagementStone.cs:line 1601
at Server.Timer.Slice() in C:\Documents and Settings\owner\Local Settings\Application Data\Temporary Projects\Runuo Arc update\Server\Timer.cs:line 400
at Server.Core.Main(String[] args) in C:\Documents and Settings\owner\Local Settings\Application Data\Temporary Projects\Runuo Arc update\Server\Main.cs:line 458I am getting this error when trying to upgrade...im not sure what version im upgrading from.
is there any new edits i need to have done? or anything i can show that might inform you of what version im using? currently it works, but im trying to update for some of the new features
thanks for any help....let me know if you need additional info
EDIT: Nevermind....found the fix a couple of posts up i believe...post #199 has it
is there any new edits i need to have done? or anything i can show that might inform you of what version im using? currently it works, but im trying to update for some of the new features
Code:
+ Custom/New Scripts/Systems/Player Gov System/PlayerGovernmentSystem.cs:
CS1502: Line 280: The best overloaded method match for 'System.Collections.G
eneric.List<Server.Multis.BaseHouse>.AddRange(System.Collections.Generic.IEnumer
able<Server.Multis.BaseHouse>)' has some invalid arguments
CS1503: Line 280: Argument '1': cannot convert from 'System.Collections.Arra
yList' to 'System.Collections.Generic.IEnumerable<Server.Multis.BaseHouse>'
CS0029: Line 292: Cannot implicitly convert type 'System.Collections.ArrayLi
st' to 'System.Collections.Generic.List<Server.Multis.BaseHouse>'EDIT: Nevermind....found the fix a couple of posts up i believe...post #199 has it
seanandre
Sorceror
I've gone through this system and this entire thread and corrected everything accordingly, but when I start my server, I keep getting the following errors:
Any help would be greatly appreciated.
Thanks,
Sean
Code:
Errors:
+ Customs/Misc/FS Player Government System/PlayerGovernmentSystem.cs:
CS0029: Line 292: Cannot implicitly convert type 'System.Collections.Generic
.List<Server.Multis.BaseHouse>' to 'System.Collections.ArrayList'
+ Items/Misc/PlayerVendorDeed.cs:
CS1525: Line 54: Invalid expression term 'else'
CS1002: Line 54: ; expected
+ Items/Misc/PublicMoongate.cs:
CS0246: Line 411: The type or namespace name 'ArrayList' could not be found
(are you missing a using directive or an assembly reference?)
CS0246: Line 411: The type or namespace name 'ArrayList' could not be found
(are you missing a using directive or an assembly reference?)
Scripts: One or more scripts failed to compile or no script files were found.Any help would be greatly appreciated.
Thanks,
Sean