Sounds great....I didn't try opening and closing the book without targeting an instrument.!
I could drop any songscroll onto the book and cast it however, not sure why it crashed for you.
As to the other changes, that is great! Glad you could use it.
Note: However, now it crashes the server
-add a songbook
-add a song (I used icecarol)
-drop song on book and it appears in book
-click song and it prompts you for instrument if you dont have one set. So far so good, that is what it should do.
- add instrument
- click song, get prompted and click instrument.
- click song...it starts to cast and server crashes
same crash that was happening before I made the changes.
Code:
Exception:
System.NullReferenceException: Object reference not set to an instance of an object.
at Server.Spells.Song.IceCarolSong.OnCast()
at Server.Spells.CastTimer.OnTick()
at Server.Timer.Slice()
at Server.Core.Main(String[] args)
If I don't get a chance today, I'll take a look at it tonight when I get home.
ok ok, did another quick test...if you close book without selecting anything it acts as if you meant to cast a spell. You get the "you need an instrument selected to cast that spell. That probably is related to the crash.
yeah, crashes everytime you cast a spell now. tried a different spell as well....with instrument selected before, with instrument not selected yet, etc.